Skip to content

drm + usb-type-c: Add support for out-of-band hotplug notification (v4)

Hans de Goede dri-devel intel-gfx linux-usb platform-driver-x86 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 4 repliesIn review

Changes in v4 from the cover letter

- Rebase on top of latest drm-tip
- Add forward declaration for struct fwnode_handle to drm_crtc_internal.h (fixes warning reported by kernel test robot <[email protected]>)
- Add Heikki's Reviewed-by to patch 7 & 8
- Add Heikki's Tested-by to the series

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/connector: Give connector sysfs devices there own device_typedrivers/gpu/drm/drm_sysfs.c+37 -130 replies
2/8drm/connector: Add a fwnode pointer to drm_connector and register with ACPI (v2)drivers/gpu/drm/drm_connector.c drivers/gpu/drm/drm_sysfs.c include/drm/drm_connector.h+47 -00 replies
3/8drm/connector: Add drm_connector_find_by_fwnode() function (v3)drivers/gpu/drm/drm_connector.c drivers/gpu/drm/drm_crtc_internal.h include/drm/drm_connector.h+60 -00 replies
4/8drm/connector: Add support for out-of-band hotplug notification (v3)drivers/gpu/drm/drm_connector.c include/drm/drm_connector.h+36 -00 replies
5/8drm/i915: Associate ACPI connector nodes with connector entries (v2)drivers/gpu/drm/i915/display/intel_acpi.c drivers/gpu/drm/i915/display/intel_acpi.h drivers/gpu/drm/i915/display/intel_display.c+50 -00 replies
6/8drm/i915/dp: Add support for out-of-bound hotplug eventsdrivers/gpu/drm/i915/display/intel_dp.c+12 -00 replies
7/8usb: typec: altmodes/displayport: Make dp_altmode_notify() more genericdrivers/usb/typec/altmodes/displayport.c+13 -221 reply
8/8usb: typec: altmodes/displayport: Notify drm subsys of hotplug eventsdrivers/usb/typec/altmodes/Kconfig drivers/usb/typec/altmodes/displayport.c+24 -01 reply

Reviews trailers per patch

2 of 8 patches have a Reviewed-by or Acked-by.

PatchHeikki KrogerusGreg Kroah-Hartman
1/8T-b
2/8T-b
3/8T-b
4/8T-b
5/8T-b
6/8T-b
7/8R-b T-b R-b
8/8R-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] drm + usb-type-c: Add support for out-of-band hotplug notification (v4)

Here is v3 of my patchset making DP over Type-C work on devices where the Type-C controller does not drive the HPD pin on the GPU, but instead we need to forward HPD events from the Type-C controller to the DRM driver.

Changes in v4:
- Rebase on top of latest drm-tip
- Add forward declaration for struct fwnode_handle to drm_crtc_internal.h (fixes warning reported by kernel test robot <[email protected]>)
- Add Heikki's Reviewed-by to patch 7 & 8
- Add Heikki's Tested-by to the series

Changes in v3:
- Base on top of latest drm-tip, which should fix the CI being unable to apply (and thus to test) the patches
- Make intel_acpi_assign_connector_fwnodes() take a ref on the fwnode it stores in connector->fwnode and have drm_connector_cleanup() put this reference
- Drop data argument from drm_connector_oob_hotplug_event()
- Make the Type-C DP altmode code only call drm_connector_oob_hotplug_event() when the HPD bit in the status vdo changes
- Drop the platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference patch, this will be merged independently through the pdx86 tree

Changes in v2:
- Replace the bogus "drm/connector: Make the drm_sysfs connector->kdev device hold a reference to the connector" patch with:
"drm/connector: Give connector sysfs devices there own device_type" the new patch is a dep for patch 2/9 see the patches

- Stop using a class-dev-iter, instead at a global connector list to drm_connector.c and use that to find the connector by the fwnode, similar to how we already do this in drm_panel.c and drm_bridge.c

- Make drm_connector_oob_hotplug_event() take a fwnode pointer as argument, rather then a drm_connector pointer and let it do the lookup itself. This allows making drm_connector_find_by_fwnode() a drm-internal function and avoids code outside the drm subsystem potentially holding on the a drm_connector reference for a longer period.

This series not only touches drm subsys files but it also touches drivers/usb/typec/altmodes/typec_displayport.c, that file usually does not see a whole lot of changes. So I believe it would be best to just merge the entire series through drm-misc, Assuming we can get an ack from Greg for merging the typec_displayport.c changes this way.

Regards,

Hans

Hans de Goede (7):
drm/connector: Give connector sysfs devices there own device_type drm/connector: Add a fwnode pointer to drm_connector and register with

    ACPI (v2)

drm/connector: Add drm_connector_find_by_fwnode() function (v3) drm/connector: Add support for out-of-band hotplug notification (v3) drm/i915/dp: Add support for out-of-bound hotplug events
usb: typec: altmodes/displayport: Make dp_altmode_notify() more
generic
usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

Heikki Krogerus (1):
drm/i915: Associate ACPI connector nodes with connector entries (v2)

 drivers/gpu/drm/drm_connector.c              | 79 ++++++++++++++++++
 drivers/gpu/drm/drm_crtc_internal.h          |  2 +
 drivers/gpu/drm/drm_sysfs.c                  | 87 +++++++++++++++++---
 drivers/gpu/drm/i915/display/intel_acpi.c    | 46 +++++++++++
 drivers/gpu/drm/i915/display/intel_acpi.h    |  3 +
 drivers/gpu/drm/i915/display/intel_display.c |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c      | 12 +++
 drivers/usb/typec/altmodes/Kconfig           |  1 +
 drivers/usb/typec/altmodes/displayport.c     | 58 ++++++++-----
 include/drm/drm_connector.h                  | 25 ++++++
 10 files changed, 279 insertions(+), 35 deletions(-)
Signature · 1 line
2.31.1