Skip to content

DEVICE_UNPLUG_ERROR QAPI event

Daniel Henrique Barboza qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest7 patches 16 repliesIn review
  2. v57 patches 8 repliesSuperseded
  3. v43 patches 14 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v33 patches4 repliesSuperseded
v22 patches11 repliesSuperseded

Changes in v6 from the cover letter

- patch 1:
* fixed function name in commit msg
-patch 6:
* kept error message in a single line
- all patches:
* added Greg's R-b
- v5 link: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg03239.html

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7hw/acpi/memory_hotplug.c: avoid sending MEM_UNPLUG_ERROR if dev->id is NULLhw/acpi/memory_hotplug.c+7 -22 replies
2/7spapr.c: avoid sending MEM_UNPLUG_ERROR if dev->id is NULLhw/ppc/spapr.c+5 -31 reply
3/7spapr_drc.c: do not error_report() when drc->dev->id == NULLhw/ppc/spapr_drc.c+5 -22 replies
4/7qapi/qdev.json: fix DEVICE_DELETED parameters docqapi/qdev.json+2 -21 reply
5/7qapi/qdev.json: add DEVICE_UNPLUG_ERROR QAPI eventdocs/about/deprecated.rst qapi/machine.json qapi/qdev.json +1 more+51 -21 reply
6/7spapr: use DEVICE_UNPLUG_ERROR to report unplug errorshw/ppc/spapr.c hw/ppc/spapr_drc.c+20 -74 replies
7/7memory_hotplug.c: send DEVICE_UNPLUG_ERROR in acpi_memory_hotplug_write()hw/acpi/memory_hotplug.c+10 -04 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchGreg KurzMichael S. TsirkinMarkus Armbruster
1/7R-b
2/7R-b
3/7R-b R-b
4/7R-b R-b
5/7R-b R-b
6/7R-b
7/7R-b A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH for-6.2 v6 0/7] DEVICE_UNPLUG_ERROR QAPI event

Hi,

This version was rebased with QEMU master @ 7457b407edd6e8555e4b4 and has a few simple changes based on Greg's review.

changes from v5:
- patch 1:
* fixed function name in commit msg
-patch 6:
* kept error message in a single line
- all patches:
* added Greg's R-b
- v5 link: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg03239.html

changes from v4:
- patch 1 (new):
* avoid emitting MEM_UNPLUG_ERROR when dev->id == NULL in
memory_hotplug.c
- patch 2 (new):
* avoid emitting MEM_UNPLUG_ERROR when dev->id == NULL in
spapr.c
- patch 3 (new):
* do not error_report() when drc->dev->id == NULL
- patch 4 (new):
* update DEVICE_DELETED API docs
- patch 5 (former 1):
* added 2 spaces after each sentence
* appended "Some errors cannot be detected." in DEVICE_UNPLUG_ERROR
docs
* changed release from 6.1 to 6.2 in docs
* changed DEVICE_UNPLUG_ERROR API to behave more like device_deleted
- patches 6 and 7:
* changed to use the new DEVICE_UNPLUG_ERROR API
- v4 link: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01355.html

changes from v3:
- patch 1:
* fixed format
- all patches:
* rebased with master
* added David's R-b
- v3 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05842.html

changes from v2:
- patch 1:
* moved DEVICE_UNPLUG_ERROR declaration to qapi/qdev.json
* updated 'device_del' description
* added 'deprecated' notice on MEM_UNPLUG_ERROR
* added MEM_UNPLUG_ERROR 'deprecated' info in docs/system/deprecated.rst
- patch 2:
* send both MEM_UNPLUG_ERROR and DEVICE_UNPLUG_ERROR
- patch 3 (new):
* send DEVICE_UNPLUG_ERROR in acpi/memory_hotplug.c
- v2 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg01304.html

changes from v1:
- former patches 1 and 2: dropped
- patch 1 (former 3): changed the version to '6.1'
- patch 2 (former 4): add a DEVICE_UNPLUG_ERROR event in the device unplug error path of CPUs and DIMMs
- v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg04682.html

Daniel Henrique Barboza (7):
hw/acpi/memory_hotplug.c: avoid sending MEM_UNPLUG_ERROR if dev->id is
NULL
spapr.c: avoid sending MEM_UNPLUG_ERROR if dev->id is NULL spapr_drc.c: do not error_report() when drc->dev->id == NULL qapi/qdev.json: fix DEVICE_DELETED parameters doc qapi/qdev.json: add DEVICE_UNPLUG_ERROR QAPI event
spapr: use DEVICE_UNPLUG_ERROR to report unplug errors memory_hotplug.c: send DEVICE_UNPLUG_ERROR in
acpi_memory_hotplug_write()

 docs/about/deprecated.rst | 10 ++++++++++
 hw/acpi/memory_hotplug.c  | 19 +++++++++++++++++--
 hw/ppc/spapr.c            | 17 +++++++++++++----
 hw/ppc/spapr_drc.c        | 21 +++++++++++++++------
 qapi/machine.json         |  6 +++++-
 qapi/qdev.json            | 34 +++++++++++++++++++++++++++++++---
 stubs/qdev.c              |  7 +++++++
 7 files changed, 98 insertions(+), 16 deletions(-)
Signature · 1 line
2.31.1