DEVICE_UNPLUG_ERROR QAPI event
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest7 patches 16 repliesIn review
- v57 patches 8 repliesSuperseded
- v43 patches 14 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 3 patches | 4 replies | Superseded | |
| v2 | 2 patches | 11 replies | Superseded |
Changes in v6 from the cover letter
- patch 1:
* fixed function name in commit msg
-patch 6:
* kept error message in a single line
- all patches:
* added Greg's R-b
- v5 link: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg03239.html
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | hw/acpi/memory_hotplug.c: avoid sending MEM_UNPLUG_ERROR if dev->id is NULLhw/ | +7 | 2 replies | |
| 2/7 | spapr.c: avoid sending MEM_UNPLUG_ERROR if dev->id is NULLhw/ | +5 | 1 reply | |
| 3/7 | spapr_drc.c: do not error_report() when drc->dev->id == NULLhw/ | +5 | 2 replies | |
| 4/7 | qapi/qdev.json: fix DEVICE_DELETED parameters docqapi/ | +2 | 1 reply | |
| 5/7 | qapi/qdev.json: add DEVICE_UNPLUG_ERROR QAPI eventdocs/ qapi/ qapi/ +1 more | +51 | 1 reply | |
| 6/7 | spapr: use DEVICE_UNPLUG_ERROR to report unplug errorshw/ hw/ | +20 | 4 replies | |
| 7/7 | memory_hotplug.c: send DEVICE_UNPLUG_ERROR in acpi_memory_hotplug_write()hw/ | +10 | 4 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Greg Kurz | Michael S. Tsirkin | Markus Armbruster |
|---|---|---|---|
| 1/7 | R-b | ||
| 2/7 | R-b | ||
| 3/7 | R-b | R-b | |
| 4/7 | R-b | R-b | |
| 5/7 | R-b | R-b | |
| 6/7 | R-b | ||
| 7/7 | R-b | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH for-6.2 v6 0/7] DEVICE_UNPLUG_ERROR QAPI event
Hi,
This version was rebased with QEMU master @ 7457b407edd6e8555e4b4 and has a few simple changes based on Greg's review.
changes from v5:
- patch 1:
* fixed function name in commit msg
-patch 6:
* kept error message in a single line
- all patches:
* added Greg's R-b
- v5 link: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg03239.html
changes from v4:
- patch 1 (new):
* avoid emitting MEM_UNPLUG_ERROR when dev->id == NULL inmemory_hotplug.c
- patch 2 (new):
* avoid emitting MEM_UNPLUG_ERROR when dev->id == NULL inspapr.c
- patch 3 (new):
* do not error_report() when drc->dev->id == NULL
- patch 4 (new):
* update DEVICE_DELETED API docs
- patch 5 (former 1):
* added 2 spaces after each sentence
* appended "Some errors cannot be detected." in DEVICE_UNPLUG_ERROR
docs
* changed release from 6.1 to 6.2 in docs
* changed DEVICE_UNPLUG_ERROR API to behave more like device_deleted
- patches 6 and 7:
* changed to use the new DEVICE_UNPLUG_ERROR API
- v4 link: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01355.html
changes from v3:
- patch 1:
* fixed format
- all patches:
* rebased with master
* added David's R-b
- v3 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05842.html
changes from v2:
- patch 1:
* moved DEVICE_UNPLUG_ERROR declaration to qapi/qdev.json
* updated 'device_del' description
* added 'deprecated' notice on MEM_UNPLUG_ERROR
* added MEM_UNPLUG_ERROR 'deprecated' info in docs/system/deprecated.rst
- patch 2:
* send both MEM_UNPLUG_ERROR and DEVICE_UNPLUG_ERROR
- patch 3 (new):
* send DEVICE_UNPLUG_ERROR in acpi/memory_hotplug.c
- v2 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg01304.html
changes from v1:
- former patches 1 and 2: dropped
- patch 1 (former 3): changed the version to '6.1'
- patch 2 (former 4): add a DEVICE_UNPLUG_ERROR event in the device unplug error path of CPUs and DIMMs
- v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg04682.html
Daniel Henrique Barboza (7):
hw/acpi/memory_hotplug.c: avoid sending MEM_UNPLUG_ERROR if dev->id is
NULL
spapr.c: avoid sending MEM_UNPLUG_ERROR if dev->id is NULL spapr_drc.c: do not error_report() when drc->dev->id == NULL qapi/qdev.json: fix DEVICE_DELETED parameters doc qapi/qdev.json: add DEVICE_UNPLUG_ERROR QAPI event
spapr: use DEVICE_UNPLUG_ERROR to report unplug errors memory_hotplug.c: send DEVICE_UNPLUG_ERROR in
acpi_memory_hotplug_write()
docs/about/deprecated.rst | 10 ++++++++++ hw/acpi/memory_hotplug.c | 19 +++++++++++++++++-- hw/ppc/spapr.c | 17 +++++++++++++---- hw/ppc/spapr_drc.c | 21 +++++++++++++++------ qapi/machine.json | 6 +++++- qapi/qdev.json | 34 +++++++++++++++++++++++++++++++--- stubs/qdev.c | 7 +++++++ 7 files changed, 98 insertions(+), 16 deletions(-)
Signature · 1 line
2.31.1