submodule--helper: introduce subcommands for sh to C conversion
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest3 patches 0 repliesNew
- v53 patches 0 repliesSuperseded
- v43 patches 6 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 2 patches | 3 replies | Superseded | |
| v2 | 2 patches | 6 replies | Superseded | |
| v1 | 2 patches | 4 replies | Superseded |
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | submodule--helper: refactor module_clone()builtin/ | +128 | 0 replies | |
| 2/3 | submodule--helper: introduce add-clone subcommandbuiltin/ git-submodule.sh | +178 | 0 replies | |
| 3/3 | submodule--helper: introduce add-config subcommandbuiltin/ git-submodule.sh | +126 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by.
| Patch | Christian Couder | Shourya Shukla | Prathamesh Chavan | Đoàn Trần Công Danh |
|---|---|---|---|---|
| 1/3 | Mentored-by | Mentored-by | ||
| 2/3 | Mentored-by | Mentored-by Based-on-patch-by | Based-on-patch-by | Helped-by |
| 3/3 | Mentored-by | Mentored-by Based-on-patch-by | Based-on-patch-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [GSoC] [PATCH v6 0/3] submodule--helper: introduce subcommands for sh to C conversion
In [2/3]:
I noticed that my previous code fails to parse prefixes properly when it has not been explicitly stated by the subcommand caller.
Atharva Raykar (3):
submodule--helper: refactor module_clone()
submodule--helper: introduce add-clone subcommand
submodule--helper: introduce add-config subcommand
builtin/submodule--helper.c | 543 ++++++++++++++++++++++++++++-------- git-submodule.sh | 66 +---- 2 files changed, 432 insertions(+), 177 deletions(-)
Range-diff against v5:
1: 068568f997 = 1: 068568f997 submodule--helper: refactor module_clone()
1: 10734cf91a ! 2: 06b2075580 submodule--helper: introduce add-clone subcommand
@@ builtin/submodule--helper.c: static int module_set_branch(int argc, const char *
+ OPT_STRING('b', "branch", &add_data.branch,
+ N_("branch"),
+ N_("branch of repository to checkout on cloning")),
-+ OPT_STRING(0, "prefix", &add_data.prefix,
++ OPT_STRING(0, "prefix", &prefix,
+ N_("path"),
+ N_("alternative anchor for relative paths")),
+ OPT_STRING(0, "path", &add_data.sm_path,
@@ builtin/submodule--helper.c: static int module_set_branch(int argc, const char *
+ if (argc != 0)
+ usage_with_options(usage, options);
+
++ add_data.prefix = prefix;
+ add_data.progress = !!progress;
+ add_data.dissociate = !!dissociate;
+ add_data.force = !!force;2: 383f0b6217 = 3: 3e827a3858 submodule--helper: introduce add-config subcommand
--
2.31.1