Skip to content

python: move qmp-shell into qemu.qmp package

John Snow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest42 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/42scripts/qmp-shell: apply isort rulesscripts/qmp/qmp-shell+7 -50 replies
2/42scripts/qmp-shell: Apply flake8 rulesscripts/qmp/qmp-shell+43 -210 replies
3/42scripts/qmp-shell: fix show_banner signaturescripts/qmp/qmp-shell+2 -20 replies
4/42scripts/qmp-shell: fix exception handlingscripts/qmp/qmp-shell+1 -10 replies
5/42scripts/qmp-shell: fix connect method signaturescripts/qmp/qmp-shell+1 -10 replies
6/42scripts/qmp-shell: remove shadowed variable from _print()scripts/qmp/qmp-shell+2 -20 replies
7/42scripts/qmp-shell: use @classmethod where appropriatescripts/qmp/qmp-shell+4 -20 replies
8/42scripts/qmp-shell: Use python3-style super()scripts/qmp/qmp-shell+3 -30 replies
9/42scripts/qmp-shell: declare verbose in __init__scripts/qmp/qmp-shell+1 -00 replies
10/42scripts/qmp-shell: use triple-double-quote docstring stylescripts/qmp/qmp-shell+5 -20 replies
11/42scripts/qmp-shell: ignore visit_Name namescripts/qmp/qmp-shell+1 -10 replies
12/42scripts/qmp-shell: make QMPCompleter returns explicitscripts/qmp/qmp-shell+3 -30 replies
13/42scripts/qmp-shell: rename one and two-letter variablesscripts/qmp/qmp-shell+12 -120 replies
14/42scripts/qmp-shell: fix shell history exception handlingscripts/qmp/qmp-shell+6 -90 replies
15/42scripts/qmp-shell: remove if-raise-else patternsscripts/qmp/qmp-shell+4 -40 replies
16/42scripts/qmp-shell: use isinstance() instead of type()scripts/qmp/qmp-shell+2 -20 replies
17/42scripts/qmp-shell: use argparsescripts/qmp/qmp-shell+32 -500 replies
18/42scripts/qmp-shell: Add pretty attribute to HMP shellscripts/qmp/qmp-shell+4 -70 replies
19/42scripts/qmp-shell: Make verbose a public attributescripts/qmp/qmp-shell+6 -100 replies
20/42scripts/qmp-shell: move get_prompt() to prompt propertyscripts/qmp/qmp-shell+5 -40 replies
21/42scripts/qmp-shell: remove prompt argument from read_exec_commandscripts/qmp/qmp-shell+3 -30 replies
22/42scripts/qmp-shell: move the REPL functionality into QMPShellscripts/qmp/qmp-shell+7 -30 replies
23/42scripts/qmp-shell: Fix "FuzzyJSON" parserscripts/qmp/qmp-shell+10 -100 replies
24/42scripts/qmp-shell: refactor QMPCompleterscripts/qmp/qmp-shell+11 -30 replies
25/42scripts/qmp-shell: initialize completer earlyscripts/qmp/qmp-shell+1 -10 replies
26/42python/qmp: add QMPObject type aliaspython/qemu/qmp/__init__.py+3 -00 replies
27/42scripts/qmp-shell: add mypy typesscripts/qmp/qmp-shell+41 -260 replies
28/42scripts/qmp-shell: Accept SocketAddrT instead of stringscripts/qmp/qmp-shell+7 -50 replies
29/42scripts/qmp-shell: unprivatize 'pretty' propertyscripts/qmp/qmp-shell+4 -50 replies
30/42python/qmp: return generic type from context managerpython/qemu/qmp/__init__.py+4 -10 replies
31/42scripts/qmp-shell: Use context manager instead of atexitscripts/qmp/qmp-shell+18 -150 replies
32/42scripts/qmp-shell: use logging to show warningsscripts/qmp/qmp-shell+8 -20 replies
33/42scripts/qmp-shell: remove TODOscripts/qmp/qmp-shell+0 -20 replies
34/42scripts/qmp-shell: Fix empty-transaction invocationscripts/qmp/qmp-shell+8 -60 replies
35/42scripts/qmp-shell: Remove too-broad-exceptionscripts/qmp/qmp-shell+7 -40 replies
36/42scripts/qmp-shell: convert usage comment to docstringscripts/qmp/qmp-shell+72 -560 replies
37/42scripts/qmp-shell: remove double-underscoresscripts/qmp/qmp-shell+26 -260 replies
38/42scripts/qmp-shell: make QMPShellError inherit QMPErrorscripts/qmp/qmp-shell+1 -10 replies
39/42scripts/qmp-shell: add docstringsscripts/qmp/qmp-shell+38 -10 replies
40/42scripts/qmp-shell: move to python/qemu/qmp/qmp_shell.pypython/qemu/qmp/qmp_shell.py+0 -30 replies
41/42python: add qmp-shell entry pointpython/setup.cfg+1 -00 replies
42/42scripts/qmp-shell: add redirection shimscripts/qmp/qmp-shell+11 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/42] python: move qmp-shell into qemu.qmp package

Based-on: <[email protected]>
Based-on: <[email protected]>
CI: https://gitlab.com/jsnow/qemu/-/pipelines/316425665
GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-qmp-shell

This series follows:

1. [PATCH v3 00/19] Python: move /scripts/qmp/qom* to /python/qemu/qmp/qom*​
2. [PATCH 00/11] python: move /scripts/qmp/gemu-ga-client.py to qemu.qmp package

and finishes moving stuff in ./scripts/qmp/ into ./python/qemu/qmp/*.

The benefits of this are:

1. Improved protection against accidental regression in qmp-using scripts as we refactor QMP to introduce Async QMP and OOB support
2. Availability of common qmp command-line tools as part of the qemu.qmp package
3. No more sys.path hacking for qemu.qmp-using utilities
4. Newly 100% clean linting baseline to use as an aid in reviewing future patches.

This series is largely minor refactors, linting and typing cleanups, followed by the move into the python packaging folder at the very end of the series.

John Snow (42):
scripts/qmp-shell: apply isort rules scripts/qmp-shell: Apply flake8 rules scripts/qmp-shell: fix show_banner signature scripts/qmp-shell: fix exception handling scripts/qmp-shell: fix connect method signature scripts/qmp-shell: remove shadowed variable from _print() scripts/qmp-shell: use @classmethod where appropriate scripts/qmp-shell: Use python3-style super() scripts/qmp-shell: declare verbose in __init__ scripts/qmp-shell: use triple-double-quote docstring style scripts/qmp-shell: ignore visit_Name name scripts/qmp-shell: make QMPCompleter returns explicit scripts/qmp-shell: rename one and two-letter variables scripts/qmp-shell: fix shell history exception handling scripts/qmp-shell: remove if-raise-else patterns scripts/qmp-shell: use isinstance() instead of type() scripts/qmp-shell: use argparse
scripts/qmp-shell: Add pretty attribute to HMP shell scripts/qmp-shell: Make verbose a public attribute scripts/qmp-shell: move get_prompt() to prompt property scripts/qmp-shell: remove prompt argument from read_exec_command scripts/qmp-shell: move the REPL functionality into QMPShell scripts/qmp-shell: Fix "FuzzyJSON" parser scripts/qmp-shell: refactor QMPCompleter scripts/qmp-shell: initialize completer early python/qmp: add QMPObject type alias scripts/qmp-shell: add mypy types
scripts/qmp-shell: Accept SocketAddrT instead of string scripts/qmp-shell: unprivatize 'pretty' property python/qmp: return generic type from context manager scripts/qmp-shell: Use context manager instead of atexit scripts/qmp-shell: use logging to show warnings scripts/qmp-shell: remove TODO
scripts/qmp-shell: Fix empty-transaction invocation scripts/qmp-shell: Remove too-broad-exception scripts/qmp-shell: convert usage comment to docstring scripts/qmp-shell: remove double-underscores scripts/qmp-shell: make QMPShellError inherit QMPError scripts/qmp-shell: add docstrings
scripts/qmp-shell: move to python/qemu/qmp/qmp_shell.py
python: add qmp-shell entry point
scripts/qmp-shell: add redirection shim

 python/qemu/qmp/__init__.py  |   8 +-
 python/qemu/qmp/qmp_shell.py | 535 +++++++++++++++++++++++++++++++++++
 python/setup.cfg             |   1 +
 scripts/qmp/qmp-shell        | 437 +---------------------------
 4 files changed, 546 insertions(+), 435 deletions(-)
 create mode 100644 python/qemu/qmp/qmp_shell.py
Signature · 1 line
2.31.1