Skip to content

i915 TTM sync accelerated migration and clear

Thomas Hellström dri-devel intel-gfx 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest12 patches 2 repliesIn review
  2. v412 patches 2 repliesSuperseded
  3. v312 patches 6 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v29 patches13 repliesSuperseded
v19 patches7 repliesSuperseded

Changes in v5 from the cover letter

- Minor rebase on buddy series.
- Added R-Bs for the last patches.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12drm/i915: Reference objects on the ww object listdrivers/gpu/drm/i915/gem/i915_gem_object.h drivers/gpu/drm/i915/i915_gem.c+10 -21 reply
2/12drm/i915: Break out dma_resv ww locking utilities to separate filesdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gem/i915_gem_object.h drivers/gpu/drm/i915/gt/intel_renderstate.h +4 more+87 -680 replies
3/12drm/i915: Introduce a ww transaction helperdrivers/gpu/drm/i915/i915_gem_ww.h+30 -10 replies
4/12drm/i915/gt: Add an insert_entry for gen8_ppgttdrivers/gpu/drm/i915/gt/gen8_ppgtt.c+19 -00 replies
5/12drm/i915/gt: Add a routine to iterate over the pagetables of a GTTdrivers/gpu/drm/i915/gt/gen8_ppgtt.c drivers/gpu/drm/i915/gt/intel_gtt.h+56 -00 replies
6/12drm/i915/gt: Export the pinned context constructor and destructordrivers/gpu/drm/i915/gt/intel_engine.h drivers/gpu/drm/i915/gt/intel_engine_cs.c+28 -100 replies
7/12drm/i915/gt: Pipelined page migrationdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gt/intel_engine.h drivers/gpu/drm/i915/gt/intel_gpu_commands.h +6 more+899 -01 reply
8/12drm/i915/gt: Pipelined cleardrivers/gpu/drm/i915/gt/intel_migrate.c drivers/gpu/drm/i915/gt/intel_migrate.h drivers/gpu/drm/i915/gt/selftest_migrate.c+326 -00 replies
9/12drm/i915/gt: Setup a default migration context on the GTdrivers/gpu/drm/i915/gt/intel_gt.c drivers/gpu/drm/i915/gt/intel_gt_types.h drivers/gpu/drm/i915/gt/intel_migrate.c +2 more+236 -110 replies
10/12drm/i915/ttm: accelerated move implementationdrivers/gpu/drm/i915/gem/i915_gem_ttm.c+75 -130 replies
11/12drm/i915/gem: Zap the client blt codedrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gem/i915_gem_client_blt.c drivers/gpu/drm/i915/gem/i915_gem_client_blt.h +1 more+2 -4900 replies
12/12drm/i915/gem: Zap the i915_gem_object_blt codedrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gem/i915_gem_object_blt.c drivers/gpu/drm/i915/gem/i915_gem_object_blt.h +4 more+14 -11070 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchMatthew AuldThomas HellströmDaniel Vetter
1/12R-b A-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/12] i915 TTM sync accelerated migration and clear

This patchset implements synchronous accelerated migration and clearing for i915 on TTM. We plan to follow up with these operations made asynchronous to the extent of TTM support for that:

A couple of patches from Chris which implement pipelined migration and clears by atomically writing the PTEs in place before performing the actual blit.

Some ww utilities mainly for the accompanying selftests added by Thomas, as well as modified the above patches for ww locking- and lmem support.

Hooked up to our TTM backend by Ramalingam

Finally, on request from Daniel, we ditch old blit code which is now obsolete.

v2:
- A couple of minor style fixes pointed out by Matthew Auld
- Export and use intel_engine_destroy_pinned_context() to address a CI warning / failure.
v3:
- Acceleration hooked up to TTM
- Minor fixes to review comments (Pointed out by Matthew Auld)
- Fix pipelined blit handling of engine instances (Pointed out by Matthew Auld)
- Ditch old blit code, (Pointed out by Daniel)
v4:
- Rescue a selftest that was removed with the old blit code (Pointed out by Matthew Auld)
- Extended gpu waits in the TTM accel move function
(Pointed out by Thomas Hellström)
v5:
- Minor rebase on buddy series.
- Added R-Bs for the last patches.

Chris Wilson (6):
drm/i915/gt: Add an insert_entry for gen8_ppgtt drm/i915/gt: Add a routine to iterate over the pagetables of a GTT drm/i915/gt: Export the pinned context constructor and destructor drm/i915/gt: Pipelined page migration
drm/i915/gt: Pipelined clear
drm/i915/gt: Setup a default migration context on the GT

Ramalingam C (1):
drm/i915/ttm: accelerated move implementation

Thomas Hellström (5):
drm/i915: Reference objects on the ww object list drm/i915: Break out dma_resv ww locking utilities to separate files drm/i915: Introduce a ww transaction helper drm/i915/gem: Zap the client blt code
drm/i915/gem: Zap the i915_gem_object_blt code

 drivers/gpu/drm/i915/Makefile                 |   5 +-
 .../gpu/drm/i915/gem/i915_gem_client_blt.c    | 355 ---------
 .../gpu/drm/i915/gem/i915_gem_client_blt.h    |  21 -
 drivers/gpu/drm/i915/gem/i915_gem_object.h    |   9 +-
 .../gpu/drm/i915/gem/i915_gem_object_blt.c    | 461 ------------
 .../gpu/drm/i915/gem/i915_gem_object_blt.h    |  39 -
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c       |  88 ++-
 .../i915/gem/selftests/i915_gem_client_blt.c  | 114 +--
 .../i915/gem/selftests/i915_gem_object_blt.c  | 597 ---------------
 drivers/gpu/drm/i915/gt/gen8_ppgtt.c          |  68 ++
 drivers/gpu/drm/i915/gt/intel_engine.h        |  12 +
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  27 +-
 drivers/gpu/drm/i915/gt/intel_gpu_commands.h  |   2 +
 drivers/gpu/drm/i915/gt/intel_gt.c            |   4 +
 drivers/gpu/drm/i915/gt/intel_gt_types.h      |   3 +
 drivers/gpu/drm/i915/gt/intel_gtt.h           |   7 +
 drivers/gpu/drm/i915/gt/intel_migrate.c       | 687 ++++++++++++++++++
 drivers/gpu/drm/i915/gt/intel_migrate.h       |  65 ++
 drivers/gpu/drm/i915/gt/intel_migrate_types.h |  15 +
 drivers/gpu/drm/i915/gt/intel_renderstate.h   |   1 +
 drivers/gpu/drm/i915/gt/intel_ring.h          |   1 +
 drivers/gpu/drm/i915/gt/selftest_migrate.c    | 669 +++++++++++++++++
 drivers/gpu/drm/i915/i915_gem.c               |  52 --
 drivers/gpu/drm/i915/i915_gem.h               |  12 -
 drivers/gpu/drm/i915/i915_gem_ww.c            |  63 ++
 drivers/gpu/drm/i915/i915_gem_ww.h            |  50 ++
 .../drm/i915/selftests/i915_live_selftests.h  |   2 +-
 .../drm/i915/selftests/i915_perf_selftests.h  |   2 +-
 .../drm/i915/selftests/intel_memory_region.c  |  21 +-
 29 files changed, 1766 insertions(+), 1686 deletions(-)
 delete mode 100644 drivers/gpu/drm/i915/gem/i915_gem_client_blt.c
 delete mode 100644 drivers/gpu/drm/i915/gem/i915_gem_client_blt.h
 delete mode 100644 drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
 delete mode 100644 drivers/gpu/drm/i915/gem/i915_gem_object_blt.h
 delete mode 100644 drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
 create mode 100644 drivers/gpu/drm/i915/gt/intel_migrate.c
 create mode 100644 drivers/gpu/drm/i915/gt/intel_migrate.h
 create mode 100644 drivers/gpu/drm/i915/gt/intel_migrate_types.h
 create mode 100644 drivers/gpu/drm/i915/gt/selftest_migrate.c
 create mode 100644 drivers/gpu/drm/i915/i915_gem_ww.c
 create mode 100644 drivers/gpu/drm/i915/i915_gem_ww.h
Signature · 6 lines
2.31.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx