libsepol: miscellaneous cleanup
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest23 patches 23 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/23 | libsepol: fix typoslibsepol/ libsepol/ libsepol/ +1 more | +4 | 1 reply | |
| 2/23 | libsepol: resolve missing prototypeslibsepol/ libsepol/ libsepol/ +2 more | +14 | 1 reply | |
| 3/23 | libsepol: remove unused functionslibsepol/ libsepol/ libsepol/ | +0 | 1 reply | |
| 4/23 | libsepol: ignore UBSAN false-positiveslibsepol/ libsepol/ libsepol/ | +18 | 5 replies | |
| 5/23 | libsepol: avoid implicit conversionslibsepol/ libsepol/ libsepol/ | +3 | 4 replies | |
| 6/23 | libsepol: avoid unsigned integer overflowlibsepol/ | +2 | 1 reply | |
| 7/23 | libsepol: follow declaration-after-statementlibsepol/ libsepol/ libsepol/ +4 more | +50 | 1 reply | |
| 8/23 | libsepol/cil: follow declaration-after-statementlibsepol/ libsepol/ libsepol/ +4 more | +18 | 1 reply | |
| 9/23 | libsepol: remove dead storeslibsepol/ libsepol/ | +2 | 0 replies | |
| 10/23 | libsepol: mark read-only parameters of ebitmap interfaces constlibsepol/ libsepol/ | +17 | 1 reply | |
| 11/23 | libsepol: mark read-only parameters of type_set_ interfaces constlibsepol/ libsepol/ | +5 | 1 reply | |
| 12/23 | libsepol: do not allocate memory of size 0libsepol/ libsepol/ | +8 | 1 reply | |
| 13/23 | libsepol: assure string NUL-terminationlibsepol/ | +2 | 4 replies | |
| 14/23 | libsepol: remove dead storeslibsepol/ | +2 | 0 replies | |
| 15/23 | libsepol/cil: silence cast warninglibsepol/ | +2 | 1 reply | |
| 16/23 | libsepol/cil: drop extra semicolonlibsepol/ | +1 | 1 reply | |
| 17/23 | libsepol/cil: drop dead storelibsepol/ | +1 | 1 reply | |
| 18/23 | libsepol/cil: drop unnecessary castslibsepol/ | +6 | 1 reply | |
| 19/23 | libsepol/cil: avoid using maybe uninitialized variableslibsepol/ | +6 | 1 reply | |
| 20/23 | libsepol: drop repeated semicolonslibsepol/ libsepol/ | +2 | 1 reply | |
| 21/23 | libsepol: drop unnecessary castslibsepol/ | +3 | 1 reply | |
| 22/23 | libsepol: declare file local variable staticlibsepol/ | +1 | 1 reply | |
| 23/23 | libsepol: declare read-only arrays constlibsepol/ libsepol/ libsepol/ +5 more | +23 | 1 reply |
Reviews trailers per patch
21 of 23 patches have a Reviewed-by or Acked-by.
| Patch | James Carter | Nicolas Iooss |
|---|---|---|
| 1/23 | A-b | |
| 2/23 | A-b | |
| 3/23 | A-b | |
| 4/23 | A-b | |
| 5/23 | A-b | |
| 6/23 | A-b | |
| 7/23 | A-b | |
| 8/23 | A-b | |
| 9/23 | ||
| 10/23 | A-b | |
| 11/23 | A-b | |
| 12/23 | A-b | |
| 13/23 | A-b | |
| 14/23 | ||
| 15/23 | A-b | |
| 16/23 | A-b | |
| 17/23 | A-b | |
| 18/23 | A-b | |
| 19/23 | A-b | |
| 20/23 | A-b | |
| 21/23 | A-b | |
| 22/23 | A-b | |
| 23/23 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/23] libsepol: miscellaneous cleanup
Clean up several code smells, compiler warnings, static analyzer issues and UBSAN findings in libsepol.
Also declare local functions and variables static and some interface parameters const to improve maintainability.
Christian Göttsche (23):
libsepol: fix typos
libsepol: resolve missing prototypes
libsepol: remove unused functions
libsepol: ignore UBSAN false-positives
libsepol: avoid implicit conversions
libsepol: avoid unsigned integer overflow
libsepol: follow declaration-after-statement libsepol/cil: follow declaration-after-statement
libsepol: remove dead stores
libsepol: mark read-only parameters of ebitmap interfaces const
libsepol: mark read-only parameters of type_set_ interfaces const
libsepol: do not allocate memory of size 0
libsepol: assure string NUL-termination
libsepol: remove dead stores
libsepol/cil: silence cast warning
libsepol/cil: drop extra semicolon
libsepol/cil: drop dead store
libsepol/cil: drop unnecessary casts
libsepol/cil: avoid using maybe uninitialized variables
libsepol: drop repeated semicolons
libsepol: drop unnecessary casts
libsepol: declare file local variable static
libsepol: declare read-only arrays const
libsepol/cil/src/cil_binary.c | 19 +-- libsepol/cil/src/cil_build_ast.c | 9 +- libsepol/cil/src/cil_fqn.c | 3 +- libsepol/cil/src/cil_list.c | 7 +- libsepol/cil/src/cil_post.c | 2 +- libsepol/cil/src/cil_resolve_ast.c | 8 +- libsepol/cil/src/cil_strpool.c | 16 +-- libsepol/cil/src/cil_write_ast.c | 4 +- libsepol/include/sepol/policydb/conditional.h | 2 +- libsepol/include/sepol/policydb/ebitmap.h | 16 +-- libsepol/include/sepol/policydb/policydb.h | 6 +- libsepol/src/assertion.c | 2 +- libsepol/src/avrule_block.c | 2 +- libsepol/src/avtab.c | 8 +- libsepol/src/booleans.c | 6 +- libsepol/src/conditional.c | 3 - libsepol/src/context_internal.h | 1 + libsepol/src/debug.c | 2 +- libsepol/src/ebitmap.c | 29 +++-- libsepol/src/expand.c | 8 +- libsepol/src/ibendport_record.c | 4 +- libsepol/src/kernel_to_cil.c | 7 +- libsepol/src/kernel_to_conf.c | 5 +- libsepol/src/link.c | 2 +- libsepol/src/module.c | 2 +- libsepol/src/module_to_cil.c | 14 +- libsepol/src/nodes.c | 6 +- libsepol/src/polcaps.c | 2 +- libsepol/src/policydb.c | 70 +++++----- libsepol/src/policydb_internal.h | 2 +- libsepol/src/policydb_validate.c | 2 +- libsepol/src/private.h | 6 +- libsepol/src/services.c | 120 ++++++------------ libsepol/src/sidtab.c | 31 ----- libsepol/src/symtab.c | 6 + libsepol/src/util.c | 2 +- libsepol/src/write.c | 8 +- 37 files changed, 187 insertions(+), 255 deletions(-)
Signature · 1 line
2.32.0