Skip to content

libsepol: miscellaneous cleanup

Christian Göttsche selinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest23 patches 23 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23libsepol: fix typoslibsepol/cil/src/cil_build_ast.c libsepol/cil/src/cil_resolve_ast.c libsepol/src/module_to_cil.c +1 more+4 -41 reply
2/23libsepol: resolve missing prototypeslibsepol/src/assertion.c libsepol/src/context_internal.h libsepol/src/expand.c +2 more+14 -131 reply
3/23libsepol: remove unused functionslibsepol/src/policydb.c libsepol/src/services.c libsepol/src/sidtab.c+0 -961 reply
4/23libsepol: ignore UBSAN false-positiveslibsepol/src/avtab.c libsepol/src/policydb.c libsepol/src/symtab.c+18 -05 replies
5/23libsepol: avoid implicit conversionslibsepol/include/sepol/policydb/conditional.h libsepol/include/sepol/policydb/policydb.h libsepol/src/expand.c+3 -34 replies
6/23libsepol: avoid unsigned integer overflowlibsepol/src/policydb.c+2 -21 reply
7/23libsepol: follow declaration-after-statementlibsepol/src/booleans.c libsepol/src/debug.c libsepol/src/ebitmap.c +4 more+50 -461 reply
8/23libsepol/cil: follow declaration-after-statementlibsepol/cil/src/cil_binary.c libsepol/cil/src/cil_build_ast.c libsepol/cil/src/cil_fqn.c +4 more+18 -131 reply
9/23libsepol: remove dead storeslibsepol/src/conditional.c libsepol/src/services.c+2 -50 replies
10/23libsepol: mark read-only parameters of ebitmap interfaces constlibsepol/include/sepol/policydb/ebitmap.h libsepol/src/ebitmap.c+17 -171 reply
11/23libsepol: mark read-only parameters of type_set_ interfaces constlibsepol/include/sepol/policydb/policydb.h libsepol/src/policydb.c+5 -51 reply
12/23libsepol: do not allocate memory of size 0libsepol/src/kernel_to_cil.c libsepol/src/kernel_to_conf.c+8 -21 reply
13/23libsepol: assure string NUL-terminationlibsepol/src/ibendport_record.c+2 -24 replies
14/23libsepol: remove dead storeslibsepol/src/services.c+2 -20 replies
15/23libsepol/cil: silence cast warninglibsepol/cil/src/cil_write_ast.c+2 -21 reply
16/23libsepol/cil: drop extra semicolonlibsepol/cil/src/cil_build_ast.c+1 -11 reply
17/23libsepol/cil: drop dead storelibsepol/cil/src/cil_binary.c+1 -11 reply
18/23libsepol/cil: drop unnecessary castslibsepol/cil/src/cil_strpool.c+6 -91 reply
19/23libsepol/cil: avoid using maybe uninitialized variableslibsepol/cil/src/cil_binary.c+6 -61 reply
20/23libsepol: drop repeated semicolonslibsepol/src/kernel_to_cil.c libsepol/src/module.c+2 -21 reply
21/23libsepol: drop unnecessary castslibsepol/src/services.c+3 -31 reply
22/23libsepol: declare file local variable staticlibsepol/src/module_to_cil.c+1 -11 reply
23/23libsepol: declare read-only arrays constlibsepol/src/avrule_block.c libsepol/src/avtab.c libsepol/src/link.c +5 more+23 -231 reply

Reviews trailers per patch

21 of 23 patches have a Reviewed-by or Acked-by.

PatchJames CarterNicolas Iooss
1/23A-b
2/23A-b
3/23A-b
4/23A-b
5/23A-b
6/23A-b
7/23A-b
8/23A-b
9/23
10/23A-b
11/23A-b
12/23A-b
13/23A-b
14/23
15/23A-b
16/23A-b
17/23A-b
18/23A-b
19/23A-b
20/23A-b
21/23A-b
22/23A-b
23/23A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/23] libsepol: miscellaneous cleanup

Clean up several code smells, compiler warnings, static analyzer issues and UBSAN findings in libsepol.

Also declare local functions and variables static and some interface parameters const to improve maintainability.

Christian Göttsche (23):
libsepol: fix typos
libsepol: resolve missing prototypes
libsepol: remove unused functions
libsepol: ignore UBSAN false-positives
libsepol: avoid implicit conversions
libsepol: avoid unsigned integer overflow
libsepol: follow declaration-after-statement libsepol/cil: follow declaration-after-statement
libsepol: remove dead stores
libsepol: mark read-only parameters of ebitmap interfaces const
libsepol: mark read-only parameters of type_set_ interfaces const
libsepol: do not allocate memory of size 0
libsepol: assure string NUL-termination
libsepol: remove dead stores
libsepol/cil: silence cast warning
libsepol/cil: drop extra semicolon
libsepol/cil: drop dead store
libsepol/cil: drop unnecessary casts
libsepol/cil: avoid using maybe uninitialized variables
libsepol: drop repeated semicolons
libsepol: drop unnecessary casts
libsepol: declare file local variable static
libsepol: declare read-only arrays const

 libsepol/cil/src/cil_binary.c                 |  19 +--
 libsepol/cil/src/cil_build_ast.c              |   9 +-
 libsepol/cil/src/cil_fqn.c                    |   3 +-
 libsepol/cil/src/cil_list.c                   |   7 +-
 libsepol/cil/src/cil_post.c                   |   2 +-
 libsepol/cil/src/cil_resolve_ast.c            |   8 +-
 libsepol/cil/src/cil_strpool.c                |  16 +--
 libsepol/cil/src/cil_write_ast.c              |   4 +-
 libsepol/include/sepol/policydb/conditional.h |   2 +-
 libsepol/include/sepol/policydb/ebitmap.h     |  16 +--
 libsepol/include/sepol/policydb/policydb.h    |   6 +-
 libsepol/src/assertion.c                      |   2 +-
 libsepol/src/avrule_block.c                   |   2 +-
 libsepol/src/avtab.c                          |   8 +-
 libsepol/src/booleans.c                       |   6 +-
 libsepol/src/conditional.c                    |   3 -
 libsepol/src/context_internal.h               |   1 +
 libsepol/src/debug.c                          |   2 +-
 libsepol/src/ebitmap.c                        |  29 +++--
 libsepol/src/expand.c                         |   8 +-
 libsepol/src/ibendport_record.c               |   4 +-
 libsepol/src/kernel_to_cil.c                  |   7 +-
 libsepol/src/kernel_to_conf.c                 |   5 +-
 libsepol/src/link.c                           |   2 +-
 libsepol/src/module.c                         |   2 +-
 libsepol/src/module_to_cil.c                  |  14 +-
 libsepol/src/nodes.c                          |   6 +-
 libsepol/src/polcaps.c                        |   2 +-
 libsepol/src/policydb.c                       |  70 +++++-----
 libsepol/src/policydb_internal.h              |   2 +-
 libsepol/src/policydb_validate.c              |   2 +-
 libsepol/src/private.h                        |   6 +-
 libsepol/src/services.c                       | 120 ++++++------------
 libsepol/src/sidtab.c                         |  31 -----
 libsepol/src/symtab.c                         |   6 +
 libsepol/src/util.c                           |   2 +-
 libsepol/src/write.c                          |   8 +-
 37 files changed, 187 insertions(+), 255 deletions(-)
Signature · 1 line
2.32.0