Skip to content

CAMSS: SM8250 support (and some fixes)

Jonathan Marek linux-arm-msm linux-devicetree linux-media lkml oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 8 repliesIn review

v2 from the cover letter

- Fixed some typos in commit messages (patches 02 and 08)
- patch 03 ("media: camss: csiphy-3ph: add support for SM8250 CSI DPHY"):
- moved definition of CAMSS_8250 to this patch,
- removed unused lane_enable variable
- added a default unreachable case to avoid a warning
- added a is_gen2 variable (minor rework)
- Undo DECODE_FORMAT_PAYLOAD_ONLY change, add comment instead (patch 04)
- "ops" reworks in addition to removing dead code (patch 12)
- renamed csid-170 to csid-gen2, added defines for offsets, add missing camnoc_axi clock to sm8250 vfe resources (patch 16/17)

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17media: camss: csiphy-3ph: don't print HW version as an errordrivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c+1 -10 replies
2/17media: camss: csiphy-3ph: disable interruptsdrivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c+3 -320 replies
3/17media: camss: csiphy-3ph: add support for SM8250 CSI DPHYdrivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c drivers/media/platform/qcom/camss/camss.h+139 -90 replies
4/17media: camss: csid-170: fix non-10bit formatsdrivers/media/platform/qcom/camss/camss-csid-170.c+3 -20 replies
5/17media: camss: csid-170: don't enable unused irqsdrivers/media/platform/qcom/camss/camss-csid-170.c+0 -60 replies
6/17media: camss: csid-170: remove stray commentdrivers/media/platform/qcom/camss/camss-csid-170.c+1 -10 replies
7/17media: camss: csid-170: support more than one lite vfedrivers/media/platform/qcom/camss/camss-csid-170.c+1 -10 replies
8/17media: camss: csid-170: set the right HALT_CMD when disableddrivers/media/platform/qcom/camss/camss-csid-170.c+6 -20 replies
9/17media: camss: csid: allow csid to work without a regulatordrivers/media/platform/qcom/camss/camss-csid.c+11 -61 reply
10/17media: camss: remove vdda-csiN from sdm845 resourcesdrivers/media/platform/qcom/camss/camss.c+3 -30 replies
11/17media: camss: fix VFE irq namedrivers/media/platform/qcom/camss/camss-vfe.c+1 -20 replies
12/17media: camss: remove some vfe ops and clean up dead vfe-170 codedrivers/media/platform/qcom/camss/camss-vfe-170.c drivers/media/platform/qcom/camss/camss-vfe-4-1.c drivers/media/platform/qcom/camss/camss-vfe-4-7.c +5 more+169 -2381 reply
13/17media: camss: vfe-170: fix "VFE halt timeout" errordrivers/media/platform/qcom/camss/camss-vfe-170.c+1 -110 replies
14/17media: camss: Add initial support for VFE hardware version Titan 480drivers/media/platform/qcom/camss/Makefile drivers/media/platform/qcom/camss/camss-vfe-480.c drivers/media/platform/qcom/camss/camss-vfe.h+547 -01 reply
15/17media: camss: add support for V4L2_PIX_FMT_GREY for sdm845 HWdrivers/media/platform/qcom/camss/camss-csid-170.c drivers/media/platform/qcom/camss/camss-csiphy.c drivers/media/platform/qcom/camss/camss-vfe.c +1 more+11 -00 replies
16/17media: camss: add support for SM8250 camssdrivers/media/platform/qcom/camss/Makefile drivers/media/platform/qcom/camss/camss-csid-gen2.c drivers/media/platform/qcom/camss/camss-csid.c +5 more+227 -261 reply
17/17media: dt-bindings: media: camss: Add qcom,sm8250-camss bindingDocumentation/devicetree/bindings/media/qcom,sm8250-camss.yaml+399 -03 replies

Reviews trailers per patch

16 of 17 patches have a Reviewed-by or Acked-by.

PatchRobert Foss
1/17R-b
2/17R-b
3/17R-b
4/17R-b
5/17R-b
6/17R-b
7/17R-b
8/17R-b
9/17R-b
10/17R-b
11/17R-b
12/17R-b
13/17R-b
14/17R-b
15/17R-b
16/17R-b
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/17] CAMSS: SM8250 support (and some fixes)

This adds initial support for SM8250 and its 4 VFEs and 6 CSIPHYs. The only big change is the added camss-vfe-480.c to support the Titan 480 VFE.

v2:
- Fixed some typos in commit messages (patches 02 and 08)
- patch 03 ("media: camss: csiphy-3ph: add support for SM8250 CSI DPHY"):
- moved definition of CAMSS_8250 to this patch,
- removed unused lane_enable variable
- added a default unreachable case to avoid a warning
- added a is_gen2 variable (minor rework)
- Undo DECODE_FORMAT_PAYLOAD_ONLY change, add comment instead (patch 04)
- "ops" reworks in addition to removing dead code (patch 12)
- renamed csid-170 to csid-gen2, added defines for offsets, add missing camnoc_axi clock to sm8250 vfe resources (patch 16/17)

Jonathan Marek (17):
media: camss: csiphy-3ph: don't print HW version as an error
media: camss: csiphy-3ph: disable interrupts
media: camss: csiphy-3ph: add support for SM8250 CSI DPHY
media: camss: csid-170: fix non-10bit formats
media: camss: csid-170: don't enable unused irqs
media: camss: csid-170: remove stray comment
media: camss: csid-170: support more than one lite vfe
media: camss: csid-170: set the right HALT_CMD when disabled
media: camss: csid: allow csid to work without a regulator
media: camss: remove vdda-csiN from sdm845 resources
media: camss: fix VFE irq name
media: camss: remove some vfe ops and clean up dead vfe-170 code
media: camss: vfe-170: fix "VFE halt timeout" error
media: camss: Add initial support for VFE hardware version Titan 480
media: camss: add support for V4L2_PIX_FMT_GREY for sdm845 HW
media: camss: add support for SM8250 camss
media: dt-bindings: media: camss: Add qcom,sm8250-camss binding

 .../bindings/media/qcom,sm8250-camss.yaml     | 399 +++++++++++++
 drivers/media/platform/qcom/camss/Makefile    |   3 +-
 .../{camss-csid-170.c => camss-csid-gen2.c}   |  32 +-
 .../media/platform/qcom/camss/camss-csid.c    |  45 +-
 .../media/platform/qcom/camss/camss-csid.h    |   2 +-
 .../qcom/camss/camss-csiphy-3ph-1-0.c         | 184 ++++--
 .../media/platform/qcom/camss/camss-csiphy.c  |   9 +-
 .../media/platform/qcom/camss/camss-vfe-170.c | 101 +---
 .../media/platform/qcom/camss/camss-vfe-4-1.c |  25 +-
 .../media/platform/qcom/camss/camss-vfe-4-7.c |  63 +-
 .../media/platform/qcom/camss/camss-vfe-4-8.c |  65 +--
 .../media/platform/qcom/camss/camss-vfe-480.c | 545 ++++++++++++++++++
 .../platform/qcom/camss/camss-vfe-gen1.c      |  94 +--
 .../platform/qcom/camss/camss-vfe-gen1.h      |  39 +-
 drivers/media/platform/qcom/camss/camss-vfe.c |  29 +-
 drivers/media/platform/qcom/camss/camss-vfe.h |  17 +-
 .../media/platform/qcom/camss/camss-video.c   |   5 +-
 drivers/media/platform/qcom/camss/camss.c     | 205 ++++++-
 drivers/media/platform/qcom/camss/camss.h     |   1 +
 19 files changed, 1523 insertions(+), 340 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
 rename drivers/media/platform/qcom/camss/{camss-csid-170.c => camss-csid-gen2.c} (95%)
 create mode 100644 drivers/media/platform/qcom/camss/camss-vfe-480.c
Signature · 1 line
2.26.1