Skip to content

Improve I/O priority support

Bart Van Assche linux-block 2 versions – Applied

Status from this message: Applied, thanks Bart.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 23 repliesApplied
  2. v114 patches 30 repliesSuperseded

Changes in v3 from the cover letter

- For the blk-ioprio rq-qos policy, switched from numeric to textual policy names.
- Moved rq_qos_id_to_name() into debugfs code.
- Moved the mq-deadline I/O statistics into io.stat.
- Introduced the dd_per_prio data structure.
- Switched from a single sort list to one sort list per I/O priority.
- Removed the WARN_ON_ONCE(blkcg == NULL) statements.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/16block/Kconfig: Make the BLK_WBT and BLK_WBT_MQ entries consecutiveblock/Kconfig+7 -72 replies
2/16block/blk-cgroup: Swap the blk_throtl_init() and blk_iolatency_init() callsblock/blk-cgroup.c+4 -53 replies
3/16block/blk-rq-qos: Move a function from a header file into a C fileblock/blk-mq-debugfs.c block/blk-rq-qos.h+13 -132 replies
4/16block: Introduce the ioprio rq-qos policyDocumentation/admin-guide/cgroup-v2.rst block/Kconfig block/Makefile +5 more+354 -01 reply
5/16block/mq-deadline: Add several commentsblock/mq-deadline.c+18 -01 reply
6/16block/mq-deadline: Add two lockdep_assert_held() statementsblock/mq-deadline.c+4 -01 reply
7/16block/mq-deadline: Remove two local variablesblock/mq-deadline.c+2 -61 reply
8/16block/mq-deadline: Rename dd_init_queue() and dd_exit_queue()block/mq-deadline.c+4 -41 reply
9/16block/mq-deadline: Improve compile-time argument checkingblock/mq-deadline.c+49 -471 reply
10/16block/mq-deadline: Improve the sysfs show and store macrosblock/mq-deadline.c+29 -371 reply
11/16block/mq-deadline: Reserve 25% of scheduler tags for synchronous requestsblock/mq-deadline.c+55 -00 replies
12/16block/mq-deadline: Micro-optimize the batching algorithmblock/mq-deadline.c+5 -60 replies
13/16block/mq-deadline: Add I/O priority supportblock/mq-deadline.c+228 -1140 replies
14/16block/mq-deadline: Track I/O statisticsblock/mq-deadline.c+100 -00 replies
15/16block/mq-deadline: Add cgroup supportblock/Kconfig.iosched block/Makefile block/mq-deadline-cgroup.c +2 more+308 -140 replies
16/16block/mq-deadline: Prioritize high-priority requestsblock/mq-deadline-main.c+37 -58 replies

Reviews trailers per patch

9 of 16 patches have a Reviewed-by or Acked-by.

PatchDamien Le MoalJohannes ThumshirnHannes ReineckeHimanshu MadhaniChaitanya KulkarniTejun Heo
1/16R-b R-b R-b R-b
2/16R-b R-b R-b R-b A-b
3/16R-b
4/16
5/16R-b R-b R-b
6/16R-b R-b R-b R-b R-b
7/16R-b R-b R-b R-b R-b
8/16R-b R-b R-b R-b R-b
9/16R-b R-b R-b R-b
10/16
11/16
12/16
13/16
14/16
15/16
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/16] Improve I/O priority support

Hi Jens,

A feature that is missing from the Linux kernel for storage devices that support I/O priorities is to set the I/O priority in requests involving page cache writeback. Since the identity of the process that triggers page cache writeback is not known in the writeback code, the priority set by ioprio_set() is ignored. However, an I/O cgroup is associated with writeback requests by certain filesystems. Hence this patch series that implements the following changes:
* Add an rq-qos policy that makes the I/O priority configurable per I/O cgroup and also that changes the I/O priority of requests to the lower of (request I/O priority, cgroup I/O priority).
* Introduce one queue per I/O priority in the mq-deadline scheduler.
* Dispatch the highest priority requests first.

Please consider this patch series for kernel v5.14.

Thanks,

Bart.

Changes compared to v2:
- For the blk-ioprio rq-qos policy, switched from numeric to textual policy names.
- Moved rq_qos_id_to_name() into debugfs code.
- Moved the mq-deadline I/O statistics into io.stat.
- Introduced the dd_per_prio data structure.
- Switched from a single sort list to one sort list per I/O priority.
- Removed the WARN_ON_ONCE(blkcg == NULL) statements.

Changes compared to v1:
- Moved the code for assigning an I/O priority into a new rq-qos policy.
- Dropped patch "block/mq-deadline: Reduce the read expiry time for non-rotational media".
- Made sure that dd->async_depth >= 1.
- Implemented an aging mechanism such that lower priority requests are not postponed forever.

Bart Van Assche (16):
block/Kconfig: Make the BLK_WBT and BLK_WBT_MQ entries consecutive block/blk-cgroup: Swap the blk_throtl_init() and blk_iolatency_init()
calls
block/blk-rq-qos: Move a function from a header file into a C file
block: Introduce the ioprio rq-qos policy block/mq-deadline: Add several comments
block/mq-deadline: Add two lockdep_assert_held() statements block/mq-deadline: Remove two local variables block/mq-deadline: Rename dd_init_queue() and dd_exit_queue() block/mq-deadline: Improve compile-time argument checking block/mq-deadline: Improve the sysfs show and store macros block/mq-deadline: Reserve 25% of scheduler tags for synchronous
requests
block/mq-deadline: Micro-optimize the batching algorithm block/mq-deadline: Add I/O priority support block/mq-deadline: Track I/O statistics
block/mq-deadline: Add cgroup support
block/mq-deadline: Prioritize high-priority requests

 Documentation/admin-guide/cgroup-v2.rst |   55 ++
 block/Kconfig                           |   19 +-
 block/Kconfig.iosched                   |    6 +
 block/Makefile                          |    3 +
 block/blk-cgroup.c                      |   14 +-
 block/blk-ioprio.c                      |  262 +++++
 block/blk-ioprio.h                      |   19 +
 block/blk-mq-debugfs.c                  |   15 +
 block/blk-rq-qos.h                      |   14 +-
 block/mq-deadline-cgroup.c              |  126 +++
 block/mq-deadline-cgroup.h              |  114 +++
 block/mq-deadline-main.c                | 1173 +++++++++++++++++++++++
 block/mq-deadline.c                     |  815 ----------------
 13 files changed, 1797 insertions(+), 838 deletions(-)
 create mode 100644 block/blk-ioprio.c
 create mode 100644 block/blk-ioprio.h
 create mode 100644 block/mq-deadline-cgroup.c
 create mode 100644 block/mq-deadline-cgroup.h
 create mode 100644 block/mq-deadline-main.c
 delete mode 100644 block/mq-deadline.c