Skip to content

perf intel-pt: Add PEBS-via-PT side-band

Adrian Hunter linux-perf-users lkml 3 versions – Applied

Status from this message: I've picked up the first. But if acme wants to route the whole lot:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 8 repliesApplied
  2. v23 patches 2 repliesSuperseded
  3. v13 patches 5 repliesSuperseded

Changes in v3 from the cover letter

perf/x86: Add new event for AUX output counter index
Do not set assign callback unless x86_pmu.intel_cap.pebs_output_pt_available

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3perf/x86: Add new event for AUX output counter indexarch/x86/events/core.c arch/x86/events/intel/core.c arch/x86/events/perf_event.h +3 more+69 -08 replies
2/3perf tools: Add support for PERF_RECORD_AUX_OUTPUT_HW_IDtools/include/uapi/linux/perf_event.h tools/lib/perf/include/perf/event.h tools/perf/builtin-inject.c +7 more+66 -20 replies
3/3perf intel-pt: Add support for PERF_RECORD_AUX_OUTPUT_HW_IDtools/perf/Documentation/perf-intel-pt.txt tools/perf/util/intel-pt.c+87 -50 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAlexander ShishkinAndi KleenPeter Zijlstra (Intel)
1/3A-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH V3 0/3] perf intel-pt: Add PEBS-via-PT side-band

Hi

PEBS output to Intel Processor Trace was introduced with Atom processors based on Tremont. Currently there is software support only for a single PEBS-via-PT event.

Here is support for multiple PEBS-via-PT events.

The first patch is the kernel change which adds a new event, namely PERF_RECORD_AUX_OUTPUT_HW_ID which contains the counter index. That is output when the PEBS-via-PT event is enabled in hardware. There is an optimization, to report the index only when it changes for the event. That will work only so long as all PEBS-via-PT events are scheduled together, which they are for a recording session because they are in a single group.

Also no attribute bit is used to select the new event, so a new kernel is not compatible with older perf tools. The assumption being that PEBS-via-PT is sufficiently esoteric that users will not be troubled by this.

The second patch adds the usual boiler plate to perf tools for a new event.

The third patch adds support for processing the new event by perf tool's Intel PT decoder.

Changes in V3:
perf/x86: Add new event for AUX output counter index
Do not set assign callback unless x86_pmu.intel_cap.pebs_output_pt_available

Changes in V2:
perf/x86: Add new event for AUX output counter index
Use callback from x86_assign_hw_event

Adrian Hunter (3):
perf/x86: Add new event for AUX output counter index perf tools: Add support for PERF_RECORD_AUX_OUTPUT_HW_ID perf intel-pt: Add support for PERF_RECORD_AUX_OUTPUT_HW_ID

 arch/x86/events/core.c                     |  6 +++
 arch/x86/events/intel/core.c               | 16 ++++++
 arch/x86/events/perf_event.h               |  1 +
 include/linux/perf_event.h                 |  1 +
 include/uapi/linux/perf_event.h            | 15 ++++++
 kernel/events/core.c                       | 30 +++++++++++
 tools/include/uapi/linux/perf_event.h      | 15 ++++++
 tools/lib/perf/include/perf/event.h        |  6 +++
 tools/perf/Documentation/perf-intel-pt.txt |  7 ++-
 tools/perf/builtin-inject.c                |  4 +-
 tools/perf/builtin-record.c                |  2 +-
 tools/perf/util/event.c                    | 18 +++++++
 tools/perf/util/event.h                    |  5 ++
 tools/perf/util/intel-pt.c                 | 85 ++++++++++++++++++++++++++++--
 tools/perf/util/machine.c                  | 10 ++++
 tools/perf/util/machine.h                  |  2 +
 tools/perf/util/session.c                  |  5 ++
 tools/perf/util/tool.h                     |  1 +
 18 files changed, 222 insertions(+), 7 deletions(-)

Regards
Adrian