Fix out of bounds when parsing TCP options
Status from this message: This series was applied to netdev/net.git (refs/heads/master):
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 4 repliesApplied 3/3
- v13 patches 7 repliesSuperseded
Patches in v2 All 3 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | netfilter: synproxy: Fix out of bounds when parsing TCP optionsnet/ | +5 | 1 reply | Applied |
| 2/3 | mptcp: Fix out of bounds when parsing TCP optionsnet/ | +2 | 3 replies | Applied |
| 3/3 | sch_cake: Fix out of bounds when parsing TCP options and headernet/ | +5 | 0 replies | Applied |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Mat Martineau | Toke Høiland-Jørgensen | Florian Westphal |
|---|---|---|---|
| 1/3 | R-b | ||
| 2/3 | R-b | ||
| 3/3 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH net v2 0/3] Fix out of bounds when parsing TCP options
This series fixes out-of-bounds access in various places in the kernel where parsing of TCP options takes place. Fortunately, many more occurrences don't have this bug.
v2 changes:
synproxy: Added an early return when length < 0 to avoid calling skb_header_pointer with negative length.
sch_cake: Added doff validation to avoid parsing garbage.
Maxim Mikityanskiy (3):
netfilter: synproxy: Fix out of bounds when parsing TCP options
mptcp: Fix out of bounds when parsing TCP options
sch_cake: Fix out of bounds when parsing TCP options and header
net/mptcp/options.c | 2 ++ net/netfilter/nf_synproxy_core.c | 5 +++++ net/sched/sch_cake.c | 6 +++++- 3 files changed, 12 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.1