Skip to content

net: ipa: memory region rework, part 1

Alex Elder lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesApplied 11/11

Patches in v1 All 11 applied

#Subject and filesSizeRepliesApplied
1/11net: ipa: define IPA_MEM_END_MARKERdrivers/net/ipa/ipa_data-v4.11.c drivers/net/ipa/ipa_data-v4.2.c drivers/net/ipa/ipa_mem.c +1 more+5 -20 repliesApplied
2/11net: ipa: store memory region id in descriptordrivers/net/ipa/ipa_data-v3.5.1.c drivers/net/ipa/ipa_data-v4.11.c drivers/net/ipa/ipa_data-v4.2.c +3 more+106 -10 repliesApplied
3/11net: ipa: validate memory regions unconditionallydrivers/net/ipa/ipa_mem.c+3 -140 repliesApplied
4/11net: ipa: separate memory validation from initializationdrivers/net/ipa/ipa_mem.c+32 -80 repliesApplied
5/11net: ipa: separate region range check from other validationdrivers/net/ipa/ipa_mem.c+26 -30 repliesApplied
6/11net: ipa: validate memory regions at init timedrivers/net/ipa/ipa_mem.c+4 -40 repliesApplied
7/11net: ipa: pass memory configuration data to ipa_mem_valid()drivers/net/ipa/ipa_mem.c+14 -150 repliesApplied
8/11net: ipa: introduce ipa_mem_id_optional()drivers/net/ipa/ipa_mem.c drivers/net/ipa/ipa_mem.h+53 -100 repliesApplied
9/11net: ipa: validate memory regions based on versiondrivers/net/ipa/ipa_mem.c+61 -00 repliesApplied
10/11net: ipa: flag duplicate memory regionsdrivers/net/ipa/ipa_mem.c+9 -00 repliesApplied
11/11net: ipa: use bitmap to check for missing regionsdrivers/net/ipa/ipa_mem.c+5 -80 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 00/11] net: ipa: memory region rework, part 1

This is the first portion of a very long series of patches that has been split in two. Once these patches are accepted, I'll post the remaining patches.

The combined series reworks the way memory regions are defined in the configuration data, and in the process solidifies code that ensures configurations are valid.

In this portion (part 1), most of the focus is on improving validation of code. This validation is now done unconditionally (something I promised Leon Romanovsky I would work on). Validation will occur earlier than before, catching configuration problems as early as possible and permitting the rest of the driver to avoid needing to do some error checking. There will now be checks to ensure all defined regions are supported by the hardware, that required regions are all defined, and that there are no duplicate regions.

The second portion (part 2) is mainly a set of small but pervasive changes whose result is to have the memory region array not be indexed by region ID. I'll provide further explanation when I post that series.

-Alex

Alex Elder (11):
net: ipa: define IPA_MEM_END_MARKER
net: ipa: store memory region id in descriptor
net: ipa: validate memory regions unconditionally
net: ipa: separate memory validation from initialization
net: ipa: separate region range check from other validation
net: ipa: validate memory regions at init time
net: ipa: pass memory configuration data to ipa_mem_valid()
net: ipa: introduce ipa_mem_id_optional()
net: ipa: validate memory regions based on version
net: ipa: flag duplicate memory regions
net: ipa: use bitmap to check for missing regions

 drivers/net/ipa/ipa_data-v3.5.1.c |  15 +++
 drivers/net/ipa/ipa_data-v4.11.c  |  24 +++-
 drivers/net/ipa/ipa_data-v4.2.c   |  20 ++-
 drivers/net/ipa/ipa_data-v4.5.c   |  23 ++++
 drivers/net/ipa/ipa_data-v4.9.c   |  26 +++-
 drivers/net/ipa/ipa_mem.c         | 196 ++++++++++++++++++++++++++----
 drivers/net/ipa/ipa_mem.h         |  25 ++--
 7 files changed, 291 insertions(+), 38 deletions(-)
Signature · 1 line
2.27.0