Skip to content

tests: migration-test: Fix agressive test skip, add dirty ring test

Peter Xu qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 8 repliesIn review
  2. v12 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- patch 2: detect dirty ring only for __linux__ [Dave]
- Add r-b for Dave on both patches

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tests: migration-test: Still run the rest even if uffd missingtests/qtest/migration-test.c+5 -61 reply
2/2tests: migration-test: Add dirty ring testtests/qtest/migration-test.c+55 -36 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDr. David Alan GilbertJuan Quintela
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] tests: migration-test: Fix agressive test skip, add dirty ring test

Based-on: <[email protected]>

v2:
- patch 2: detect dirty ring only for __linux__ [Dave]
- Add r-b for Dave on both patches

Patch 1 is a fix for migration test not really running on new kernels. The problem is uffd check now will constantly fail after upstream commit 37cd0575b8510159 - that means any host kernel newer than 5.11.

Patch 1 makes it slightly better by only skipping the two postcopy tests that needs uffd on these kernels. When we want to run the full test, we can do:

  $ sudo QTEST_QEMU_BINARY=./qemu-system-x86_64 ./tests/qtest/migration-test

Then the uffd check will pass, and postcopy tests will be run.

Patch 2 of this series adds the dirty ring test that just got merged into qemu. It needs the other patch "[PATCH] KVM: Fix dirty ring mmap incorrect size due to renaming accident", and that's majorly why we need the "Based-on" tag.

Not sure what's the easiest way for the series as it'll depend on the other kvm patch. Perhaps if I can try to get ack from Dave so Paolo could queue it too along with the kvm fix (for either the whole series or patch 2 only)? I'll leave that to maintainers to decide..

Please review, thanks.

Peter Xu (2):
tests: migration-test: Still run the rest even if uffd missing
tests: migration-test: Add dirty ring test

 tests/qtest/migration-test.c | 69 +++++++++++++++++++++++++++++++-----
 1 file changed, 60 insertions(+), 9 deletions(-)
Signature · 1 line
2.31.1