Skip to content

target/i386/sev: Housekeeping (OVMF + SEV-disabled binaries)

Philippe Mathieu-Daudé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest23 patches 21 repliesIn review
  2. v111 patches 14 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23MAINTAINERS: Add Connor Kuehl as reviewer for AMD SEVMAINTAINERS+7 -02 replies
2/23qapi/misc-target: Wrap long 'SEV Attestation Report' long linesqapi/misc-target.json+10 -73 replies
3/23qapi/misc-target: Group SEV QAPI definitionsqapi/misc-target.json+40 -413 replies
4/23target/i386/monitor: Return QMP error when SEV is disabled in buildtarget/i386/monitor.c+5 -00 replies
5/23target/i386/cpu: Add missing 'qapi/error.h' headertarget/i386/cpu.c+1 -00 replies
6/23target/i386/sev_i386.h: Remove unused headerstarget/i386/sev-stub.c target/i386/sev_i386.h+1 -40 replies
7/23target/i386/sev: Remove sev_get_me_mask()target/i386/sev-stub.c target/i386/sev.c target/i386/sev_i386.h+0 -150 replies
8/23target/i386/sev: Mark unreachable code with g_assert_not_reached()target/i386/sev-stub.c+2 -20 replies
9/23target/i386/sev: sev_get_attestation_report use g_autofreetarget/i386/sev.c+3 -80 replies
10/23target/i386/sev: Restrict SEV to system emulationtarget/i386/meson.build target/i386/sev-stub.c target/i386/sev-sysemu-stub.c+63 -440 replies
11/23target/i386/sev: Move qmp_query_sev_attestation_report() to sev.ctarget/i386/monitor.c target/i386/sev-sysemu-stub.c target/i386/sev.c +1 more+13 -130 replies
12/23target/i386/sev: Move qmp_sev_inject_launch_secret() to sev.ctarget/i386/monitor.c target/i386/sev-sysemu-stub.c target/i386/sev.c+34 -340 replies
13/23target/i386/sev: Move qmp_query_sev_capabilities() to sev.ctarget/i386/monitor.c target/i386/sev-sysemu-stub.c target/i386/sev.c +1 more+8 -100 replies
14/23target/i386/sev: Move qmp_query_sev_launch_measure() to sev.ctarget/i386/monitor.c target/i386/sev-sysemu-stub.c target/i386/sev.c +1 more+20 -210 replies
15/23target/i386/sev: Move qmp_query_sev() & hmp_info_sev() to sev.ctarget/i386/monitor.c target/i386/sev-sysemu-stub.c target/i386/sev.c +1 more+46 -420 replies
16/23monitor: Restrict 'info sev' to x86 targetsinclude/monitor/hmp-target.h include/monitor/hmp.h target/i386/sev-sysemu-stub.c +1 more+3 -30 replies
17/23hw/i386/acpi-common: Remove unused includeshw/i386/acpi-common.c+0 -50 replies
18/23hw/i386: Rename acpi-build.c -> acpi-pc.chw/i386/acpi-pc.c hw/i386/meson.build+1 -10 replies
19/23hw/i386: Move pc_madt_cpu_entry() to acpi-pc.chw/i386/acpi-common.c hw/i386/acpi-pc.c+39 -404 replies
20/23hw/acpi: Do not restrict ACPI core routines to x86 architecturehw/acpi/meson.build+2 -12 replies
21/23hw/i386: Introduce X86_FW_OVMF Kconfig symbolMAINTAINERS hw/i386/Kconfig hw/i386/meson.build +4 more+169 -1071 reply
22/23hw/acpi/Kconfig: Add missing Kconfig dependencies (build error)hw/acpi/Kconfig+4 -01 reply
23/23hw/i386/Kconfig: Add missing Kconfig dependency (runtime error)hw/i386/Kconfig+1 -01 reply

Reviews trailers per patch

11 of 23 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchConnor KuehlDr. David Alan GilbertPhilippe Mathieu-DaudéBrijesh SinghGerd HoffmannMichael S. TsirkinMarkus Armbruster
SeriesA-b
1/23R-b
2/23R-b
3/23R-b
4/23R-b R-b
5/23R-b R-b
6/23R-b
7/23R-b R-b
8/23R-b
9/23R-b R-b
10/23
11/23
12/23
13/23
14/23
15/23
16/23
17/23
18/23
19/23
20/23
21/23
22/23R-b
23/23R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/23] target/i386/sev: Housekeeping (OVMF + SEV-disabled binaries)

Hi,

While testing James & Dov patch:
https://www.mail-archive.com/[email protected]/msg810571.html
I wasted some time trying to figure out how OVMF was supposed to behave until realizing the binary I was using was built without SEV support... Then wrote this series to help other developers to not hit the same problem.

Some SEV patches I was following have been queued on Eduardo's 'x86-next' tree, so I used his tree as base, and included David and Connor patches to reduce merge conflicts.

Patches 1-16 are SEV related,
patches 17-23 are OVMF related.

Special comment for Laszlo: Please don't review this version, wait for the respin (hoping the SEV cleanup patch get accepted, the respin will be focused on OVMF).

Based-on: https://gitlab.com/ehabkost/qemu/-/commits/x86-next/
Supersedes: <[email protected]>

Connor Kuehl (1):
MAINTAINERS: Add Connor Kuehl as reviewer for AMD SEV

Dr. David Alan Gilbert (1):
target/i386/sev: sev_get_attestation_report use g_autofree

Philippe Mathieu-Daudé (21):
qapi/misc-target: Wrap long 'SEV Attestation Report' long lines qapi/misc-target: Group SEV QAPI definitions target/i386/monitor: Return QMP error when SEV is disabled in build target/i386/cpu: Add missing 'qapi/error.h' header target/i386/sev_i386.h: Remove unused headers target/i386/sev: Remove sev_get_me_mask() target/i386/sev: Mark unreachable code with g_assert_not_reached() target/i386/sev: Restrict SEV to system emulation target/i386/sev: Move qmp_query_sev_attestation_report() to sev.c target/i386/sev: Move qmp_sev_inject_launch_secret() to sev.c target/i386/sev: Move qmp_query_sev_capabilities() to sev.c target/i386/sev: Move qmp_query_sev_launch_measure() to sev.c target/i386/sev: Move qmp_query_sev() & hmp_info_sev() to sev.c
monitor: Restrict 'info sev' to x86 targets hw/i386/acpi-common: Remove unused includes
hw/i386: Rename acpi-build.c -> acpi-pc.c
hw/i386: Move pc_madt_cpu_entry() to acpi-pc.c
hw/acpi: Do not restrict ACPI core routines to x86 architecture hw/i386: Introduce X86_FW_OVMF Kconfig symbol hw/acpi/Kconfig: Add missing Kconfig dependencies (build error) hw/i386/Kconfig: Add missing Kconfig dependency (runtime error)

 qapi/misc-target.json               |  78 ++++++++--------
 include/hw/i386/pc.h                |   1 +
 include/monitor/hmp-target.h        |   1 +
 include/monitor/hmp.h               |   1 -
 target/i386/sev_i386.h              |  11 ---
 hw/i386/acpi-common.c               |  45 ----------
 hw/i386/{acpi-build.c => acpi-pc.c} |  39 ++++++++
 hw/i386/pc_sysfw.c                  | 107 ----------------------
 hw/i386/pc_sysfw_ovmf-stubs.c       |  26 ++++++
 hw/i386/pc_sysfw_ovmf.c             | 135 ++++++++++++++++++++++++++++
 target/i386/cpu.c                   |   1 +
 target/i386/monitor.c               |  91 -------------------
 target/i386/sev-stub.c              |  49 +---------
 target/i386/sev-sysemu-stub.c       |  69 ++++++++++++++
 target/i386/sev.c                   | 130 +++++++++++++++++++++------
 MAINTAINERS                         |   8 ++
 hw/acpi/Kconfig                     |   4 +
 hw/acpi/meson.build                 |   3 +-
 hw/i386/Kconfig                     |   5 ++
 hw/i386/meson.build                 |   4 +-
 target/i386/meson.build             |   4 +-
 21 files changed, 443 insertions(+), 369 deletions(-)
 rename hw/i386/{acpi-build.c => acpi-pc.c} (98%)
 create mode 100644 hw/i386/pc_sysfw_ovmf-stubs.c
 create mode 100644 hw/i386/pc_sysfw_ovmf.c
 create mode 100644 target/i386/sev-sysemu-stub.c
Signature · 1 line
2.31.1