Skip to content

iio: accel: bmc150: Add support for BMA253/BMA254

Stephan Gerhold linux-devicetree linux-iio 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 5 repliesIn review
  2. v29 patches 7 repliesSuperseded
  3. v16 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- Add new "iio: accel: bmc150: Clarify combo modules in Kconfig" patch
- Sort "one-line" chip name lists as well, not just multi-line ones

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10iio: accel: bmc150: Fix bma222 scale unitdrivers/iio/accel/bmc150-accel-core.c+5 -40 replies
2/10iio: accel: bmc150: Clarify combo modules in Kconfigdrivers/iio/accel/Kconfig+5 -20 replies
3/10iio: accel: bmc150: Drop misleading/duplicate chip identifiersdrivers/iio/accel/bmc150-accel-core.c drivers/iio/accel/bmc150-accel-i2c.c drivers/iio/accel/bmc150-accel-spi.c +1 more+37 -670 replies
4/10iio: accel: bmc150: Drop duplicated documentation of supported chipsdrivers/iio/accel/bmc150-accel-core.c drivers/iio/accel/bmc150-accel-i2c.c+2 -180 replies
5/10iio: accel: bmc150: Sort all chip names alphabetically / by chip IDdrivers/iio/accel/bmc150-accel-core.c drivers/iio/accel/bmc150-accel-i2c.c drivers/iio/accel/bmc150-accel-spi.c+42 -420 replies
6/10dt-bindings: iio: accel: bma255: Document bosch,bma253Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml+1 -00 replies
7/10iio: accel: bmc150: Add device IDs for BMA253drivers/iio/accel/Kconfig drivers/iio/accel/bmc150-accel-core.c drivers/iio/accel/bmc150-accel-i2c.c +1 more+5 -20 replies
8/10dt-bindings: iio: bma255: Allow multiple interruptsDocumentation/devicetree/bindings/iio/accel/bosch,bma255.yaml+6 -14 replies
9/10dt-bindings: iio: accel: bma180/bma255: Move bma254 to bma255 schemaDocumentation/devicetree/bindings/iio/accel/bosch,bma180.yaml Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml+2 -20 replies
10/10iio: accel: bma180/bmc150: Move BMA254 to bmc150-accel driverdrivers/iio/accel/Kconfig drivers/iio/accel/bma180.c drivers/iio/accel/bmc150-accel-core.c +1 more+18 -840 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchLinus WalleijAndy ShevchenkoHans de Goede
1/10R-b
2/10R-b
3/10R-b R-b R-b
4/10R-b
5/10R-b
6/10R-b R-b R-b
7/10R-b R-b R-b
8/10R-b R-b R-b
9/10R-b R-b R-b
10/10R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/10] iio: accel: bmc150: Add support for BMA253/BMA254

The Bosch BMA253 accelerometer is very similar to both BMA254 and BMA255. The current situation is very confusing: BMA254 is supported by the bma180 driver, but BMA255 is supported by the bmc150-accel driver.

It turns out the bma180 and bmc150-accel drivers have quite some overlap, and BMA253/BMA254 would be a bit better supported in bmc150-accel (which has support for the motion trigger/interrupt).

This series adds BMA253 support to bmc150-accel and also moves BMA254 over to bmc150, removing some unnecessary code from the bma180 driver.

In v2 I also sneaked in a small fix for the scale table of BMA222 to simplify backporting for the stable people.

---
Changes in v3:
- Add new "iio: accel: bmc150: Clarify combo modules in Kconfig" patch
- Sort "one-line" chip name lists as well, not just multi-line ones

v2: https://lore.kernel.org/linux-iio/[email protected]/
Changes in v2:
- Add new "iio: accel: bmc150: Fix bma222 scale unit" patch at the beginning so the stable people can backport it without conflicts
- Add Reviewed-by: from Hans and Andy for all previous patches
- Add patch 3 and 4 to have all the chip lists in a consistent order
- Fix last patch to also drop BMA254 from the file header in bma180.c

v1: https://lore.kernel.org/linux-iio/[email protected]/

Stephan Gerhold (10):
iio: accel: bmc150: Fix bma222 scale unit
iio: accel: bmc150: Clarify combo modules in Kconfig
iio: accel: bmc150: Drop misleading/duplicate chip identifiers
iio: accel: bmc150: Drop duplicated documentation of supported chips
iio: accel: bmc150: Sort all chip names alphabetically / by chip ID
dt-bindings: iio: accel: bma255: Document bosch,bma253
iio: accel: bmc150: Add device IDs for BMA253
dt-bindings: iio: bma255: Allow multiple interrupts
dt-bindings: iio: accel: bma180/bma255: Move bma254 to bma255 schema
iio: accel: bma180/bmc150: Move BMA254 to bmc150-accel driver

 .../bindings/iio/accel/bosch,bma180.yaml      |  3 +-
 .../bindings/iio/accel/bosch,bma255.yaml      |  9 +-
 drivers/iio/accel/Kconfig                     | 11 ++-
 drivers/iio/accel/bma180.c                    | 92 +++----------------
 drivers/iio/accel/bmc150-accel-core.c         | 87 ++++++------------
 drivers/iio/accel/bmc150-accel-i2c.c          | 52 +++++------
 drivers/iio/accel/bmc150-accel-spi.c          | 31 ++++---
 drivers/iio/accel/bmc150-accel.h              | 10 --
 8 files changed, 98 insertions(+), 197 deletions(-)
Signature · 1 line
2.32.0