Skip to content

RFC linux-user/s390x: save/restore condition code state during signal handling

Jonathan Albrecht qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 patch 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1linux-user/s390x: save/restore condition code state during signal handlinglinux-user/s390x/signal.c+35 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC 0/1] linux-user/s390x: save/restore condition code state during signal handling

Peter Bao <[email protected]> and I have been looking at some issues with qemu user mode x86_64 host/s390x guest when running go1.14+ executables. From the qemu cpu traces, it looks like the condition code is not restored after a signal handler is run. This affects go1.14+ because it uses signals heavily to implement the async preempt feature in the goroutine scheduler that was added in go1.14.

This patch tries save and restore the condition code related fields when handling a signal. We're submitting it as an RFC since we're new to qemu and not sure if this is s390x specific. We have some C code (s390x specific) that reproduces the issue and can try to add it as a unit test.

Jonathan Albrecht (1):
linux-user/s390x: save/restore condition code state during signal
handling

 linux-user/s390x/signal.c | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
Signature · 1 line
2.31.1