vfio-ccw: Fix garbage sense data on I/O error
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 patch 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | vfio-ccw: Keep passthrough sense data intacthw/ hw/ | +2 | 4 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/1] vfio-ccw: Fix garbage sense data on I/O error
Hi Conny,
Per our offline discussion, here's a fix for the error when a guest issues "dasdfmt -M quick". It basically reverts commit 334e76850bbb ("vfio/ccw: update sense data if a unit check is pending") and modifies the check that builds sense data in the TSCH handler.
I opted to NOT disable PMCW.CSENSE, because doing so prevents vfio-ccw devices from coming online at all (didn't pursue deep enough to explain why). Turning it off in reaction to a unit check (in this now-reverted codepath) works, but only because of the corresponding PMCW.CSENSE check in the TSCH code.
I don't know if anything is needed for the (unaltered) ECW data that commit b498484ed49a ("s390x/css: sense data endianness") addressed for the copied sense_data bytes, but figure we can use this as a starting point. Thoughts?
Eric Farman (1):
vfio-ccw: Keep passthrough sense data intact
hw/s390x/css.c | 3 ++- hw/vfio/ccw.c | 6 ------ 2 files changed, 2 insertions(+), 7 deletions(-)
Signature · 1 line
2.25.1