fix icmpv6 id dependeny handling
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 4 repliesIn review
- v13 patches 0 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | netlink_delinearize: add missing icmp id/sequence supportsrc/ | +65 | 4 replies | |
| 2/3 | payload: do not remove icmp echo dependencysrc/ | +37 | 0 replies | |
| 3/3 | tests: add a icmp-reply only and icmpv6 id test casestests/ tests/ tests/ +3 more | +123 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH nft v2 0/3] fix icmpv6 id dependeny handling
v2: in patch 1, make sure set has elements and is anonymous.
Pablo reported following bug:
input: icmpv6 id 1
output: icmpv6 type { echo-request, echo-reply } icmpv6 parameter-problem 65536/16
First patch fixes delinearization to handle this correctly. Second patch fixes a bug related to dependency removal. Third patch adds test cases for this bug.
src/netlink_delinearize.c | 68 ++++++++++++++++++++++++++++++++++++-- src/payload.c | 61 ++++++++++++++++++++-------------- tests/py/ip/icmp.t | 1 tests/py/ip/icmp.t.json | 28 +++++++++++++++ tests/py/ip/icmp.t.payload.ip | 9 +++++ tests/py/ip6/icmpv6.t | 3 + tests/py/ip6/icmpv6.t.json | 61 ++++++++++++++++++++++++++++++++++ tests/py/ip6/icmpv6.t.payload.ip6 | 21 +++++++++++ 8 files changed, 225 insertions(+), 27 deletions(-)