Skip to content

net: WWAN link creation improvements

Sergey Ryazanov netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 7 repliesApplied 10/10
  2. v110 patches 18 repliesSuperseded

Changes in v2 from the cover letter

* rebased on top of latest net-next
* patch that reworks the creation of mhi_net default netdev was dropped; as Loic explained, this network device has different purpose depending on a driver mode; Loic has a plan to rework the mhi_net driver, so we will defer the default netdev creation reworkings
* add a new patch that creates a default network interface for IOSM modems
* 7th, 8th, 10th patches have a minor updates (see the patches for details)

Patches in v2 All 10 applied

#Subject and filesSizeRepliesApplied
1/10wwan_hwsim: support network interface creationdrivers/net/wwan/wwan_hwsim.c+48 -00 repliesApplied
2/10wwan: core: relocate ops registering codedrivers/net/wwan/wwan_core.c+71 -710 repliesApplied
3/10wwan: core: require WWAN netdev setup callback existencedrivers/net/wwan/wwan_core.c+1 -11 replyApplied
4/10wwan: core: multiple netdevs deletion supportdrivers/net/wwan/wwan_core.c+1 -11 replyApplied
5/10wwan: core: remove all netdevs on ops unregisteringdrivers/net/wwan/wwan_core.c+31 -91 replyApplied
6/10net: iosm: drop custom netdev(s) removingdrivers/net/wwan/iosm/iosm_ipc_wwan.c+1 -140 repliesApplied
7/10wwan: core: no more hold netdev ops owning moduledrivers/net/mhi/net.c drivers/net/wwan/wwan_core.c drivers/net/wwan/wwan_hwsim.c +1 more+1 -151 replyApplied
8/10wwan: core: support default netdev creationdrivers/net/mhi/net.c drivers/net/wwan/iosm/iosm_ipc_wwan.c drivers/net/wwan/wwan_core.c +2 more+86 -53 repliesApplied
9/10net: iosm: create default link via WWAN coredrivers/net/wwan/iosm/iosm_ipc_imem_ops.h drivers/net/wwan/iosm/iosm_ipc_wwan.c+5 -10 repliesApplied
10/10wwan: core: add WWAN common private data for netdevdrivers/net/mhi/net.c drivers/net/mhi/proto_mbim.c drivers/net/wwan/iosm/iosm_ipc_wwan.c +2 more+61 -150 repliesApplied

Reviews trailers per patch

5 of 10 patches have a Reviewed-by or Acked-by.

PatchM Chetan KumarLoic Poulain
1/10
2/10
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 00/10] net: WWAN link creation improvements

This series is intended to make the WWAN network links management easier for WWAN device drivers.

The series begins with adding support for network links creation to the WWAN HW simulator to facilitate code testing. Then there are a couple of changes that prepe the WWAN core code for further modifications. The following patches (4-6) simplify driver unregistering procedures by performing the created links cleanup in the WWAN core. 7th patch is to avoid the odd hold of a driver module. Next patches (8th and 9th) make it easier for drivers to create a network interface for a default data channel. Finally, 10th patch adds support for reporting of data link (aka channel aka context) id to make user aware which network interface is bound to which WWAN device data channel.

All core changes have been tested with the HW simulator. The MHI and IOSM drivers were only compile tested as I have no access to this hardware. So the coresponding patches require ACK from the driver authors.

Changelog:
v1 -> v2:
* rebased on top of latest net-next
* patch that reworks the creation of mhi_net default netdev was dropped; as Loic explained, this network device has different purpose depending on a driver mode; Loic has a plan to rework the mhi_net driver, so we will defer the default netdev creation reworkings
* add a new patch that creates a default network interface for IOSM modems
* 7th, 8th, 10th patches have a minor updates (see the patches for details)

Sergey Ryazanov (10):
wwan_hwsim: support network interface creation
wwan: core: relocate ops registering code
wwan: core: require WWAN netdev setup callback existence
wwan: core: multiple netdevs deletion support
wwan: core: remove all netdevs on ops unregistering
net: iosm: drop custom netdev(s) removing
wwan: core: no more hold netdev ops owning module
wwan: core: support default netdev creation
net: iosm: create default link via WWAN core
wwan: core: add WWAN common private data for netdev

 drivers/net/mhi/net.c                     |  18 +-
 drivers/net/mhi/proto_mbim.c              |   5 +-
 drivers/net/wwan/iosm/iosm_ipc_imem_ops.h |   3 +
 drivers/net/wwan/iosm/iosm_ipc_wwan.c     |  31 +--
 drivers/net/wwan/wwan_core.c              | 258 ++++++++++++++++------
 drivers/net/wwan/wwan_hwsim.c             |  47 ++++
 include/linux/wwan.h                      |  28 ++-
 7 files changed, 282 insertions(+), 108 deletions(-)
Signature · 1 line
2.26.3