Skip to content

rkisp1 support for px30

Heiko Stuebner linux-devicetree linux-media linux-rockchip 10 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest10 patches 0 repliesNew
  2. v6 posting 2/210 patches 9 repliesSuperseded
  3. v6 posting 1/20 of 7 patches 2 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v5 posting 2/20 of 7 patches0 repliesSuperseded
v5 posting 1/210 patches4 repliesSuperseded
v4 posting 2/210 patches1 replySuperseded
v4 posting 1/20 of 7 patches0 repliesSuperseded
v3 posting 2/210 patches1 replySuperseded
v3 posting 1/20 of 7 patches0 repliesSuperseded
v27 patches8 repliesSuperseded

Changes in v7 from the cover letter

- address comments from Laurent
* some constifying
* rst document detailing version differences
- add received Acks/Reviews

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10media: rockchip: rkisp1: remove unused irq variabledrivers/media/platform/rockchip/rkisp1/rkisp1-common.h drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c+0 -30 replies
2/10dt-bindings: media: rkisp1: fix pclk clock-nameDocumentation/devicetree/bindings/media/rockchip-isp1.yaml+1 -10 replies
3/10dt-bindings: media: rkisp1: document different irq possibilitiesDocumentation/devicetree/bindings/media/rockchip-isp1.yaml+31 -140 replies
4/10media: rockchip: rkisp1: allow separate interruptsdrivers/media/platform/rockchip/rkisp1/rkisp1-capture.c drivers/media/platform/rockchip/rkisp1/rkisp1-common.h drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c +1 more+58 -280 replies
5/10media: rockchip: rkisp1: make some isp-param functions variabledrivers/media/platform/rockchip/rkisp1/rkisp1-common.h drivers/media/platform/rockchip/rkisp1/rkisp1-params.c+65 -270 replies
6/10media: rockchip: rkisp1: make some isp-stats functions variabledrivers/media/platform/rockchip/rkisp1/rkisp1-common.h drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c+22 -30 replies
7/10media: rockchip: rkisp1: add prefixes for v10 specific partsdrivers/media/platform/rockchip/rkisp1/rkisp1-params.c drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c+237 -2380 replies
8/10media: rockchip: rkisp1: add support for v12 isp variantsDocumentation/driver-api/media/drivers/rkisp1.rst drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c drivers/media/platform/rockchip/rkisp1/rkisp1-params.c +2 more+608 -20 replies
9/10dt-bindings: media: rkisp1: document px30 isp compatibleDocumentation/devicetree/bindings/media/rockchip-isp1.yaml+66 -10 replies
10/10media: rockchip: rkisp1: add support for px30 isp versiondrivers/media/platform/rockchip/rkisp1/rkisp1-dev.c+25 -00 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchRob HerringDafna HirschfeldLaurent Pinchart
1/10R-b
2/10A-b
3/10R-b
4/10R-b
5/10R-b R-b
6/10R-b R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/10] rkisp1 support for px30

This series adds support for the slightly different v12 variant of the ISP used for example in the px30 soc.

changes in v7:
- address comments from Laurent
* some constifying
* rst document detailing version differences
- add received Acks/Reviews

changes in v6:
- camera compatible in px30 binding example (Rob's bot)
- move a last wrong positionen constant define (a v12 addition should not be added in the v10-prefix change) (Dafna)
- rename size to clk_size in match-data struct (Dafna)

changes in v5:
- handle interrupt-names as conditional required property (Dafna)
- add second example for showing interrupt-names (Dafna)

changes in v4:
- clean up multi-irq case (Dafna)
Now each variant can have a list of interrupts
and their respective handlers, with or without
interrupt-names

changes in v3:
- add necessary binding additions
- fix pclk naming in binding
- move v12 clk_ctrl register bits to v12 addition patch
- fix rebase artefact with hst_enable

changes in v2 (from rfc):
- split out phy patch into a separate series
- drop dts patches for now
- split v12 addition and v10 prefixes into separate patches to enable easier review (Dafna)
- remove {stats,params}_config structs, we can just use the correct constant (Dafna)
- adapt to styling comments from Dafna and Helen
- add patch to remove the unused irq variable in struct rkisp

Heiko Stuebner (10):
media: rockchip: rkisp1: remove unused irq variable
dt-bindings: media: rkisp1: fix pclk clock-name
dt-bindings: media: rkisp1: document different irq possibilities
media: rockchip: rkisp1: allow separate interrupts
media: rockchip: rkisp1: make some isp-param functions variable
media: rockchip: rkisp1: make some isp-stats functions variable
media: rockchip: rkisp1: add prefixes for v10 specific parts
media: rockchip: rkisp1: add support for v12 isp variants
dt-bindings: media: rkisp1: document px30 isp compatible
media: rockchip: rkisp1: add support for px30 isp version

 .../bindings/media/rockchip-isp1.yaml         | 114 +++-
 .../driver-api/media/drivers/rkisp1.rst       |  43 ++
 .../platform/rockchip/rkisp1/rkisp1-capture.c |   9 +-
 .../platform/rockchip/rkisp1/rkisp1-common.h  |  44 +-
 .../platform/rockchip/rkisp1/rkisp1-dev.c     |  81 ++-
 .../platform/rockchip/rkisp1/rkisp1-isp.c     |  29 +-
 .../platform/rockchip/rkisp1/rkisp1-params.c  | 557 ++++++++++++++----
 .../platform/rockchip/rkisp1/rkisp1-regs.h    | 406 ++++++++-----
 .../platform/rockchip/rkisp1/rkisp1-stats.c   | 107 +++-
 9 files changed, 1093 insertions(+), 297 deletions(-)
 create mode 100644 Documentation/driver-api/media/drivers/rkisp1.rst
Signature · 1 line
2.29.2