Skip to content

crypto: Make QCryptoTLSCreds* structures private

Philippe Mathieu-Daudé qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest7 patches 4 repliesIn review
  2. v56 patches 5 repliesSuperseded
  3. v47 patches 15 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v37 patches2 repliesSuperseded
v27 patches4 repliesSuperseded

Changes in v6 from the cover letter

- Also convert qemu-nbd (Akihiko Odaki)

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7crypto/tlscreds: Introduce qcrypto_tls_creds_check_endpoint() helpercrypto/tlscreds.c include/crypto/tlscreds.h+26 -00 replies
2/7block/nbd: Use qcrypto_tls_creds_check_endpoint()block/nbd.c blockdev-nbd.c+6 -60 replies
3/7qemu-nbd: Use qcrypto_tls_creds_check_endpoint()qemu-nbd.c+7 -124 replies
4/7chardev/socket: Use qcrypto_tls_creds_check_endpoint()chardev/char-socket.c+6 -120 replies
5/7migration/tls: Use qcrypto_tls_creds_check_endpoint()migration/tls.c+1 -50 replies
6/7ui/vnc: Use qcrypto_tls_creds_check_endpoint()ui/vnc.c+4 -30 replies
7/7crypto: Make QCryptoTLSCreds* structures privatecrypto/tls-cipher-suites.c crypto/tlscredsanon.c crypto/tlscredspriv.h +8 more+58 -560 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonDaniel P. BerrangéEric BlakeAkihiko Odaki
1/7R-b R-b
2/7R-b R-b
3/7R-b T-b
4/7R-b R-b
5/7R-b R-b
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/7] crypto: Make QCryptoTLSCreds* structures private

Missing review: #3 (qemu-nbd)

Follow Daniel suggestion to simplify qcrypto TLS implementations, aiming to solve the OSX build failure.

Since v5:
- Also convert qemu-nbd (Akihiko Odaki)

Since v4:
- Do not introduce qcrypto_tls_session_check_role (Richard, Daniel)
- Added R-b tags

Since v3:
- Added missing @errp docstring description

Since v2:
- Add Error* argument (Daniel)
- Move structure definitions to "tlscredspriv.h"

Philippe Mathieu-Daudé (7):
crypto/tlscreds: Introduce qcrypto_tls_creds_check_endpoint() helper block/nbd: Use qcrypto_tls_creds_check_endpoint()
qemu-nbd: Use qcrypto_tls_creds_check_endpoint() chardev/socket: Use qcrypto_tls_creds_check_endpoint() migration/tls: Use qcrypto_tls_creds_check_endpoint() ui/vnc: Use qcrypto_tls_creds_check_endpoint()
crypto: Make QCryptoTLSCreds* structures private

 crypto/tlscredspriv.h              | 45 ++++++++++++++++++++++++++++++
 include/crypto/tls-cipher-suites.h |  6 ----
 include/crypto/tlscreds.h          | 30 ++++++++++----------
 include/crypto/tlscredsanon.h      | 12 --------
 include/crypto/tlscredspsk.h       | 12 --------
 include/crypto/tlscredsx509.h      | 10 -------
 block/nbd.c                        |  6 ++--
 blockdev-nbd.c                     |  6 ++--
 chardev/char-socket.c              | 18 ++++--------
 crypto/tls-cipher-suites.c         |  7 +++++
 crypto/tlscreds.c                  | 12 ++++++++
 crypto/tlscredsanon.c              |  2 ++
 crypto/tlscredspsk.c               |  2 ++
 crypto/tlscredsx509.c              |  1 +
 crypto/tlssession.c                |  1 +
 migration/tls.c                    |  6 +---
 qemu-nbd.c                         | 19 +++++--------
 ui/vnc.c                           |  7 +++--
 18 files changed, 108 insertions(+), 94 deletions(-)
Signature · 1 line
2.31.1