Skip to content

i2c: aspeed: Late ack Tx done irqs and fix unhandled Tx done with NAK

Quan Nguyen linux-arm-kernel linux-aspeed linux-i2c lkml openbmc 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 1 replyIn review

Changes in v2 from the cover letter

+ Split these patches to separate series [Joel]
+ Added the Fixes lines [Joel]
+ Fixed multiline comment [Joel]
+ Refactor irq clearing code [Joel, Guenter]
+ Revised commit message [Joel, Quan]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2i2c: aspeed: Fix unhandled Tx done with NAKdrivers/i2c/busses/i2c-aspeed.c+5 -00 replies
2/2i2c: aspeed: Acknowledge Tx done with and without ACK irq latedrivers/i2c/busses/i2c-aspeed.c+9 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] i2c: aspeed: Late ack Tx done irqs and fix unhandled Tx done with NAK

This series consists of two patches to fix the below issues observed when testing with slave mode:
+ Unhandled Tx done with NAK
+ Early ack'ed of Tx done (ACK and NAK) causing "Unexpected Ack on read request".

v2:
+ Split these patches to separate series [Joel]
+ Added the Fixes lines [Joel]
+ Fixed multiline comment [Joel]
+ Refactor irq clearing code [Joel, Guenter]
+ Revised commit message [Joel, Quan]

v1:
+ These patches are first introduced in
https://lkml.org/lkml/2021/5/19/205

Quan Nguyen (2):
i2c: aspeed: Fix unhandled Tx done with NAK
i2c: aspeed: Acknowledge Tx done with and without ACK irq late

 drivers/i2c/busses/i2c-aspeed.c | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)
Signature · 1 line
2.28.0