Skip to content

e2fsprogs: fix compiler warnings introduced since v1.45.4

Eric Biggers linux-ext4 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6libext2fs: improve jbd_debug() implementationdebugfs/journal.c e2fsck/journal.c lib/ext2fs/kernel-jbd.h+5 -291 reply
2/6e2fsck: sync fc_do_one_pass() changes from kernele2fsck/recovery.c+2 -31 reply
3/6mke2fs: use ext2fs_get_device_size2() on all platformsmisc/mke2fs.c+0 -61 reply
4/6Fix -Wunused-parameter warningsdebugfs/journal.c e2fsck/jfs_user.h e2fsck/journal.c +3 more+14 -81 reply
5/6Fix -Wunused-variable warningse2fsck/extents.c e2fsck/journal.c e2fsck/rehash.c +5 more+6 -121 reply
6/6libext2fs: fix a -Wunused-label warninglib/ext2fs/unix_io.c+0 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] e2fsprogs: fix compiler warnings introduced since v1.45.4

Fix various compiler warnings that were introduced since e2fsprogs v1.45.4, including the following types of warnings:

-Wunused-variable (enabled by -Wall)
-Wunused-label (enabled by -Wall)
-Wunused-parameter

Note, there were also -Wpointer-arith (arithmetic on a void pointer is a GNU extension) warnings introduced, but I don't find those to be very useful. But I can send out a patch for those too if people want it.

Also fix a -Wincompatible-pointer-types warning in the Windows build.

Eric Biggers (6):
libext2fs: improve jbd_debug() implementation
e2fsck: sync fc_do_one_pass() changes from kernel
mke2fs: use ext2fs_get_device_size2() on all platforms Fix -Wunused-parameter warnings
Fix -Wunused-variable warnings
libext2fs: fix a -Wunused-label warning

 debugfs/journal.c       |  7 ++-----
 e2fsck/extents.c        |  2 +-
 e2fsck/jfs_user.h       |  3 ++-
 e2fsck/journal.c        | 18 +++++-------------
 e2fsck/pass1b.c         |  3 ++-
 e2fsck/pass2.c          |  3 ++-
 e2fsck/recovery.c       |  5 ++---
 e2fsck/rehash.c         |  2 +-
 lib/e2p/errcode.c       |  1 -
 lib/e2p/fgetflags.c     |  2 +-
 lib/e2p/fsetflags.c     |  1 -
 lib/ext2fs/kernel-jbd.h | 26 +++++---------------------
 lib/ext2fs/mkjournal.c  |  1 -
 lib/ext2fs/unix_io.c    |  1 -
 lib/support/mkquota.c   |  3 ++-
 misc/mke2fs.c           |  8 ++------
 16 files changed, 27 insertions(+), 59 deletions(-)

base-commit: 32fda1e5a338ff676ae7f7e3e2bc256e7a7e2855

Signature · 1 line
2.32.0.272.g935e593368-goog