Skip to content

Overlayfs fileattr related fixes

Amir Goldstein linux-fsdevel linux-unionfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 9 repliesIn review
  2. v23 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fs: add generic helper for filling statx attribute flagsfs/orangefs/inode.c fs/stat.c include/linux/fs.h +1 more+24 -61 reply
2/4ovl: pass ovl_fs to ovl_check_setxattr()fs/overlayfs/copy_up.c fs/overlayfs/dir.c fs/overlayfs/namei.c +2 more+16 -150 replies
3/4ovl: copy up sync/noatime fileattr flagsfs/overlayfs/copy_up.c fs/overlayfs/inode.c fs/overlayfs/overlayfs.h+78 -215 replies
4/4ovl: consistent behavior for immutable/append-only inodesfs/overlayfs/copy_up.c fs/overlayfs/inode.c fs/overlayfs/overlayfs.h +1 more+195 -72 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/4] Overlayfs fileattr related fixes

Miklos,

Following patch set addresses your comments to v2. It passed all the old and new xfstests [3].

Thanks,
Amir.

Changes since v2 [2]:
- Rename overlay.xflags => overlay.protected
- Generic vfs helper for filling statx flags
- Un-generalize flag conversion helpers
- Do not be forgiving with noxattr upper fs

Changes since v1 [1]:
- Store (i),(a) flags in xattr text format
- Copy up (A),(S) flags to upper fileattr
- Fixes the problems with setting ovl dirs and hardlinks immutable

[1] https://lore.kernel.org/linux-unionfs/CAJfpeguMQca-+vTdzoDdDWNJraWyqMa3vYRFDWPMk_R6-L7Obw@mail.gmail.com/
[2] https://lore.kernel.org/linux-unionfs/CAOQ4uxgdWwrOa79BRzZ1PS6SxmLtywQCAr3+WLRZPx38aHHyQw@mail.gmail.com/
[3] https://github.com/amir73il/xfstests/commits/ovl-xflags

Amir Goldstein (4):
fs: add generic helper for filling statx attribute flags
ovl: pass ovl_fs to ovl_check_setxattr()
ovl: copy up sync/noatime fileattr flags
ovl: consistent behavior for immutable/append-only inodes

 fs/orangefs/inode.c      |   7 +--
 fs/overlayfs/copy_up.c   |  72 +++++++++++++++++++----
 fs/overlayfs/dir.c       |   6 +-
 fs/overlayfs/inode.c     |  74 +++++++++++++++++++-----
 fs/overlayfs/namei.c     |   2 +-
 fs/overlayfs/overlayfs.h |  44 ++++++++++++--
 fs/overlayfs/util.c      | 122 +++++++++++++++++++++++++++++++++++++--
 fs/stat.c                |  18 ++++++
 include/linux/fs.h       |   1 +
 include/linux/stat.h     |   4 ++
 10 files changed, 307 insertions(+), 43 deletions(-)
Signature · 1 line
2.32.0