Skip to content

RFC Meson-8b and Meson-gxbb USB phy code re-structure

Anand Moon linux-amlogic linux-arm-kernel linux-phy lkml oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 28 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8phy: amlogic: meson8b-usb2: Use clock bulk to get clocks for phydrivers/phy/amlogic/phy-meson8b-usb2.c+23 -212 replies
2/8phy: amlogic: meson8b-usb2: Use phy init callback functiondrivers/phy/amlogic/phy-meson8b-usb2.c+10 -22 replies
3/8phy: amlogic: meson8b-usb2: Use phy exit callback functiondrivers/phy/amlogic/phy-meson8b-usb2.c+10 -10 replies
4/8phy: amlogic: meson8b-usb2: Use phy set_mode callback functiondrivers/phy/amlogic/phy-meson8b-usb2.c+43 -195 replies
5/8phy: amlogic: meson8b-usb2: Reorder phy poweroff callback functiondrivers/phy/amlogic/phy-meson8b-usb2.c+11 -132 replies
6/8phy: amlogic: meson8b-usb2: Use phy reset callback functiondrivers/phy/amlogic/phy-meson8b-usb2.c+25 -109 replies
7/8phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode.drivers/phy/amlogic/phy-meson8b-usb2.c+5 -23 replies
8/8phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFERdrivers/phy/amlogic/phy-meson8b-usb2.c+2 -21 reply

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchMartin Blumenstingl
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure

On Odroid C1+ and Odroid C2 USB feature is broken this code changes are just re-structure the code so that proper callback function execute in proper order.

Code changes losely based on phy-meson-gxl-usb2.c

Initially if we connect USB HDD at initial boot it get detected. but after that usb hotplug of USB HDD is broken.
I did not observe and USB debug events messages to trace the root cause.

Another issue I observed is increase of USB interrupts event even if there is not much activity on USB ports.
I tried some clk changes but it did not workout for me.

$ cat /proc/interrupts | grep usb
 45:          0          0          0          0     GICv2  62 Level     c9000000.usb, dwc2_hsotg:usb1
 46:   17488032          0          0          0     GICv2  63 Level     c9100000.usb, dwc2_hsotg:usb2

Thanks
-Anand

Anand Moon (8):
phy: amlogic: meson8b-usb2: Use clock bulk to get clocks for phy
phy: amlogic: meson8b-usb2: Use phy init callback function
phy: amlogic: meson8b-usb2: Use phy exit callback function
phy: amlogic: meson8b-usb2: Use phy set_mode callback function
phy: amlogic: meson8b-usb2: Reorder phy poweroff callback function
phy: amlogic: meson8b-usb2: Use phy reset callback function
phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset
mode.
phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER

 drivers/phy/amlogic/phy-meson8b-usb2.c | 159 +++++++++++++++++--------
 1 file changed, 109 insertions(+), 50 deletions(-)
Signature · 1 line
2.31.1