Explicity steer l3bank multicast reads when necessary
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 1 replyIn review
v2 from the cover letter
- Use {} as table terminator and check for end==0 instead of 0xFFFFFF on loop iteration. (Rodrigo)
- Use gt->uncore instead of gt->i915->uncore. (Tvrtko)
- Now that wa_list_verify() uses _fw accessors we need to explicitly grab forcewake.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | drm/i915: extract steered reg access to common functiondrivers/ drivers/ drivers/ | +63 | 0 replies | |
| 2/3 | drm/i915: Add GT support for multiple types of multicast steeringdrivers/ drivers/ drivers/ +2 more | +142 | 0 replies | |
| 3/3 | drm/i915: Add support for explicit L3BANK steeringdrivers/ drivers/ drivers/ | +46 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Rodrigo Vivi |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Intel-gfx] [CI 0/3] Explicity steer l3bank multicast reads when necessary
We've recently learned that when steering reads of multicast registers that use 'subslice' replication, it's not only important to steer to a subslice that isn't fused off, but also to steer to the lowest-numbered subslice. This is because when Render Power Gating is enabled, grabbing forcewake will only cause the hardware to power up a single subslice (referred to as the "minconfig") until/unless a real workload is being run on the EUs. If we try to read back a value from a register instance other than the minconfig subslice, the read operation will either return 0 or random garbage.
Unfortunately this extra requirement to steer to the minconfig means that the steering target we use for subslice-replicated registers may not select a valid instance for l3bank-replicated registers. In cases where the two types of multicast registers do not have compatible steering targets, we'll initialize the steering control register to the proper subslice target at driver load, and then explicitly re-steer individual reads of l3bank registers as they occur at runtime.
This series sets up an infrastructure to handle explicit resteering of multiple multicast register types, and then applies it to l3bank registers. Our next upcoming platform (which we'll probably start upstreaming soon) will bring several more types of multicast registers, each with their own steering criteria, so the infrastructure here is partially in preparation for those extra multicast types that will be arriving soon.
v2:
- Use {} as table terminator and check for end==0 instead of 0xFFFFFF on loop iteration. (Rodrigo)
- Use gt->uncore instead of gt->i915->uncore. (Tvrtko)
- Now that wa_list_verify() uses _fw accessors we need to explicitly grab forcewake.
v2.1:
- Rebase
v3:
- The L3BANK fuse value is a disable mask rather than an enable mask. We need to invert it before applying ffs() to select a valid instance.
v4:
- The selected L3BANK ID goes in the subslice field of the steering register, not the slice field.
v4.1:
- Rebase
Daniele Ceraolo Spurio (1):
drm/i915: extract steered reg access to common function
Matt Roper (2):
drm/i915: Add GT support for multiple types of multicast steering drm/i915: Add support for explicit L3BANK steering
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 41 +----- drivers/gpu/drm/i915/gt/intel_gt.c | 102 +++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt.h | 8 ++ drivers/gpu/drm/i915/gt/intel_gt_types.h | 26 ++++ drivers/gpu/drm/i915/gt/intel_workarounds.c | 123 ++++++++---------- .../gpu/drm/i915/gt/selftest_workarounds.c | 2 +- drivers/gpu/drm/i915/intel_uncore.c | 55 ++++++++ drivers/gpu/drm/i915/intel_uncore.h | 6 + 8 files changed, 251 insertions(+), 112 deletions(-)
Signature · 6 lines
2.25.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx