Skip to content

RFC Introduce memdev driver

Ben Widawsky linux-cxl 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5cxl/region: Only allow CXL capable targetsdrivers/cxl/mem.h drivers/cxl/region.c+16 -11 reply
2/5cxl/mem: Introduce CXL mem driverdrivers/cxl/Makefile drivers/cxl/core.c drivers/cxl/cxl.h +3 more+56 -10 replies
3/5cxl/memdev: Determine CXL.mem capabilitydrivers/cxl/acpi.c drivers/cxl/core.c drivers/cxl/cxl.h +2 more+55 -61 reply
4/5cxl/pci: Export CXL DVSEC functionalitydrivers/cxl/pci.c drivers/cxl/pci.h+3 -11 reply
5/5cxl/mem: Check that the device is CXL.mem capabledrivers/cxl/mem.c drivers/cxl/pci.h+22 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/5] Introduce memdev driver

The concept of the memdev has existed since the initial support for CXL.io landed in 5.12. Here, supported is furthered by adding a driver that is capable of reporting whether or not the device is also CXL.mem capable. With this, the region driver is able to consume these devices for programming interleave (or x1) sets. Unlike the region driver, no explicit sysfs interaction is needed to utilize this driver.

The logic encapsulated here checks two things:
1. The device itself is CXL.mem enabled.
2. The device's upstream is CXL.mem enabled [1].

What's currently missing is for the cxlmem driver to add the device as an upstream port (since it has HDM decoders). I'm still working out those details. HDM decoder programming still remains undone as well, and isn't pertinent to this series perse.

The patches are based on top of my region patches [2].

The code itself is pretty rough for now, and so I'm mostly looking for feedback as to whether or not the memdev driver is serving its purpose and checking what needs to be checked on bind. If however you come along something glaringly bad, or feel like reviewing not fully tested code (I know it builds), by all means...

[1]: This series doesn't actually add real support for switches which would also need to make the determination of CXL.mem enabling.
[2]: https://lore.kernel.org/linux-cxl/[email protected]/

Ben Widawsky (5):
cxl/region: Only allow CXL capable targets cxl/mem: Introduce CXL mem driver cxl/memdev: Determine CXL.mem capability cxl/pci: Export CXL DVSEC functionality cxl/mem: Check that the device is CXL.mem capable

 drivers/cxl/Makefile |   3 +-
 drivers/cxl/acpi.c   |   9 +++-
 drivers/cxl/core.c   |   7 +++
 drivers/cxl/cxl.h    |   2 +
 drivers/cxl/mem.c    | 102 +++++++++++++++++++++++++++++++++++++++++++
 drivers/cxl/mem.h    |   3 ++
 drivers/cxl/pci.c    |   7 ++-
 drivers/cxl/pci.h    |   7 ++-
 drivers/cxl/region.c |  12 ++++-
 9 files changed, 147 insertions(+), 5 deletions(-)
 create mode 100644 drivers/cxl/mem.c
Signature · 1 line
2.32.0