Skip to content

Introduce i915_sched_engine object

Matthew Brost dri-devel intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

v2 from the cover letter

(Daniel Vetter):
- Split into several smaller patches
- Add kernel doc for i915_sched_engine
(Matthew Brost):
- Drop wrapper functions for tasklet as eventually tasklet will be dropped

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/i915: Move priolist to new i915_sched_engine objectDocumentation/gpu/i915.rst drivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_engine_pm.c +7 more+192 -900 replies
2/8drm/i915: Add i915_sched_engine_is_empty functiondrivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_execlists_submission.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 more+11 -50 replies
3/8drm/i915: Reset sched_engine.no_priolist immediately after dequeuedrivers/gpu/drm/i915/gt/intel_engine_pm.c drivers/gpu/drm/i915/gt/intel_execlists_submission.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 more+10 -20 replies
4/8drm/i915: Move active tracking to i915_sched_enginedrivers/gpu/drm/i915/gt/intel_engine.h drivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_engine_types.h +10 more+140 -1360 replies
5/8drm/i915: Move engine->schedule to i915_sched_enginedrivers/gpu/drm/i915/gem/i915_gem_wait.c drivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c +8 more+33 -340 replies
6/8drm/i915: Add kick_backend function to i915_sched_enginedrivers/gpu/drm/i915/gt/intel_execlists_submission.c drivers/gpu/drm/i915/i915_scheduler.c drivers/gpu/drm/i915/i915_scheduler_types.h+60 -600 replies
7/8drm/i915: Update i915_scheduler to operate on i915_sched_enginedrivers/gpu/drm/i915/gt/intel_execlists_submission.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c drivers/gpu/drm/i915/i915_scheduler.c +1 more+32 -290 replies
8/8drm/i915: Move submission tasklet to i915_sched_enginedrivers/gpu/drm/i915/gt/intel_engine.h drivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_engine_types.h +10 more+100 -900 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchJason EkstrandDaniele Ceraolo Spurio
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] Introduce i915_sched_engine object

As discussed in [1] we are breaking that large series into a several smaller ones. This series is stand alone patch part of step #4 which has no other dependencies or patches relevant to it.

v2:
(Daniel Vetter):
- Split into several smaller patches
- Add kernel doc for i915_sched_engine
(Matthew Brost):
- Drop wrapper functions for tasklet as eventually tasklet will be dropped

v3:
(Jason Ekstrand)
- Address his comments, change logs in individual patches
- Squash documentation patch into previous patches as needed
(Checkpatch)
- Fix warnings
(Docs)
- Fix warnings

v4:
(Daniele)
- Update a comments / commit messages
- Set queue_priority_hint

v5:
(CI)
- Rebase and fix build error

v6:
- Rebase

[1] https://patchwork.freedesktop.org/series/89844/

Matthew Brost (8):
drm/i915: Move priolist to new i915_sched_engine object drm/i915: Add i915_sched_engine_is_empty function drm/i915: Reset sched_engine.no_priolist immediately after dequeue drm/i915: Move active tracking to i915_sched_engine drm/i915: Move engine->schedule to i915_sched_engine drm/i915: Add kick_backend function to i915_sched_engine drm/i915: Update i915_scheduler to operate on i915_sched_engine drm/i915: Move submission tasklet to i915_sched_engine

 Documentation/gpu/i915.rst                    |   5 +
 drivers/gpu/drm/i915/gem/i915_gem_wait.c      |   4 +-
 drivers/gpu/drm/i915/gt/intel_engine.h        |  16 -
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  72 ++--
 .../gpu/drm/i915/gt/intel_engine_heartbeat.c  |   4 +-
 drivers/gpu/drm/i915/gt/intel_engine_pm.c     |   4 +-
 drivers/gpu/drm/i915/gt/intel_engine_types.h  |  49 +--
 drivers/gpu/drm/i915/gt/intel_engine_user.c   |   2 +-
 .../drm/i915/gt/intel_execlists_submission.c  | 325 +++++++++++-------
 .../gpu/drm/i915/gt/intel_ring_submission.c   |  12 +-
 drivers/gpu/drm/i915/gt/mock_engine.c         |  17 +-
 drivers/gpu/drm/i915/gt/selftest_execlists.c  |  34 +-
 drivers/gpu/drm/i915/gt/selftest_hangcheck.c  |   6 +-
 drivers/gpu/drm/i915/gt/selftest_lrc.c        |   6 +-
 drivers/gpu/drm/i915/gt/selftest_reset.c      |   2 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |  70 ++--
 drivers/gpu/drm/i915/i915_gpu_error.c         |   4 +-
 drivers/gpu/drm/i915/i915_request.c           |  42 +--
 drivers/gpu/drm/i915/i915_request.h           |   2 +-
 drivers/gpu/drm/i915/i915_scheduler.c         | 168 +++++----
 drivers/gpu/drm/i915/i915_scheduler.h         |  47 ++-
 drivers/gpu/drm/i915/i915_scheduler_types.h   |  89 +++++
 22 files changed, 556 insertions(+), 424 deletions(-)
Signature · 1 line
2.28.0