modules: add meta-data database
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest34 patches 11 repliesIn review
- v324 patches 8 repliesSuperseded
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/34 | modules: add modinfo macrosinclude/ | +25 | 2 replies | |
| 2/34 | modules: collect module meta-datameson.build scripts/ | +83 | 0 replies | |
| 3/34 | modules: generate modinfo.cinclude/ meson.build scripts/ +2 more | +128 | 0 replies | |
| 4/34 | modules: check if all dependencies can be satisfiedscripts/ | +14 | 0 replies | |
| 5/34 | modules: add qxl module annotationshw/ | +4 | 0 replies | |
| 6/34 | modules: add virtio-gpu module annotationshw/ hw/ hw/ +7 more | +18 | 0 replies | |
| 7/34 | modules: add chardev module annotationschardev/ chardev/ | +5 | 0 replies | |
| 8/34 | modules: add audio module annotationsaudio/ | +2 | 0 replies | |
| 9/34 | modules: add usb-redir module annotationshw/ | +1 | 0 replies | |
| 10/34 | modules: add ccid module annotationshw/ hw/ | +2 | 0 replies | |
| 11/34 | modules: add ui module annotationsui/ ui/ ui/ +2 more | +20 | 0 replies | |
| 12/34 | modules: add s390x module annotationshw/ | +3 | 0 replies | |
| 13/34 | modules: add block module annotationsblock/ | +1 | 0 replies | |
| 14/34 | modules: use modinfo for dependenciesutil/ | +21 | 0 replies | |
| 15/34 | modules: use modinfo for qom loadutil/ | +24 | 0 replies | |
| 16/34 | modules: use modinfo for qemu opts loadsoftmmu/ stubs/ util/ | +19 | 0 replies | |
| 17/34 | modules: add tracepointsutil/ util/ | +7 | 0 replies | |
| 18/34 | modules: check arch and block load on mismatchinclude/ softmmu/ util/ | +33 | 0 replies | |
| 19/34 | modules: check arch on qom lookuputil/ | +6 | 2 replies | |
| 20/34 | modules: target-specific module build infrastructuremeson.build | +37 | 0 replies | |
| 21/34 | modules: add documentation for module sourcesetsdocs/ | +17 | 0 replies | |
| 22/34 | modules: add module_obj() note to QOM docsdocs/ | +8 | 0 replies | |
| 23/34 | modules: module.h kerneldoc annotationsinclude/ | +45 | 0 replies | |
| 24/34 | modules: hook up modules.h to docs builddocs/ docs/ | +6 | 0 replies | |
| 25/34 | accel: autoload modulesaccel/ accel/ | +2 | 0 replies | |
| 26/34 | accel: add qtest module annotationsaccel/ | +2 | 0 replies | |
| 27/34 | accel: build qtest modularaccel/ meson.build | +8 | 0 replies | |
| 28/34 | accel: add tcg module annotationsaccel/ accel/ | +2 | 0 replies | |
| 29/34 | accel: build tcg modularaccel/ meson.build | +17 | 0 replies | |
| 30/34 | monitor: allow register hmp commandsinclude/ monitor/ monitor/ | +26 | 2 replies | |
| 31/34 | usb: drop usb_host_dev_is_scsi_storage hookhw/ hw/ hw/ +4 more | +17 | 0 replies | |
| 32/34 | monitor/usb: register 'info usbhost' dynamicallyhmp-commands-info.hx hw/ hw/ +1 more | +2 | 0 replies | |
| 33/34 | usb: build usb-host as modulehw/ hw/ | +7 | 0 replies | |
| 34/34 | monitor/tcg: move tcg hmp commands to accel/tcg, register them dynamicallyaccel/ accel/ hmp-commands-info.hx +1 more | +30 | 1 reply |
Reviews trailers per patch
10 of 34 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Paolo Bonzini | David Gibson | Jose R. Ziviani | Dr. David Alan Gilbert |
|---|---|---|---|---|
| Series | R-b | |||
| 1/34 | ||||
| 2/34 | ||||
| 3/34 | ||||
| 4/34 | ||||
| 5/34 | ||||
| 6/34 | ||||
| 7/34 | ||||
| 8/34 | ||||
| 9/34 | ||||
| 10/34 | ||||
| 11/34 | ||||
| 12/34 | ||||
| 13/34 | ||||
| 14/34 | R-b | |||
| 15/34 | R-b | |||
| 16/34 | R-b | |||
| 17/34 | ||||
| 18/34 | ||||
| 19/34 | ||||
| 20/34 | ||||
| 21/34 | R-b | |||
| 22/34 | R-b | |||
| 23/34 | R-b | |||
| 24/34 | R-b | |||
| 25/34 | ||||
| 26/34 | ||||
| 27/34 | ||||
| 28/34 | ||||
| 29/34 | ||||
| 30/34 | A-b | |||
| 31/34 | A-b | |||
| 32/34 | ||||
| 33/34 | ||||
| 34/34 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v4 00/34] modules: add meta-data database
This patch series adds support for module meta-data. Today this is either hard-coded in qemu (see qemu_load_module_for_opts) or handled with manually maintained lists in util/module (see module_deps[] and qom_modules[]). This series replaced that scheme with annotation macros, so the meta-data can go into the module source code and -- for example -- the module_obj() annotations can go next to the TypeInfo struct for the object class.
Patches 1-3 put the infrastructure in place: Add the annotation macros, add a script to collect the meta-data, add a script to compile the meta-data into C source code which we can then add to qemu.
Patch 4 - check module dependencies (Jose, new in v4).
Patches 5-13 add annotations macros to the modules we have.
Patches 14-16 put the modinfo database into use and remove the module_deps[] and qom_modules[] lists.
Patch 16 adds two tracepoints for easier trouble-shooting.
Patches 18-20 add support for target-specific modules.
Patches 21-24 add documentation for all of the above (new in v4, was separate series).
Patches 25-29 start building accelerators modular. So far it is only qtest (all archs) and a small fraction of tcg (x86 only).
Patches 30-34 add support for registering hmp commands so they can be implemented as module (new in v4, was separate series).
take care,
Gerd
Gerd Hoffmann (33):
modules: add modinfo macros
modules: collect module meta-data
modules: generate modinfo.c
modules: add qxl module annotations
modules: add virtio-gpu module annotations
modules: add chardev module annotations
modules: add audio module annotations
modules: add usb-redir module annotations
modules: add ccid module annotations
modules: add ui module annotations
modules: add s390x module annotations
modules: add block module annotations
modules: use modinfo for dependencies
modules: use modinfo for qom load
modules: use modinfo for qemu opts load
modules: add tracepoints
modules: check arch and block load on mismatch
modules: check arch on qom lookup
modules: target-specific module build infrastructure
modules: add documentation for module sourcesets
modules: add module_obj() note to QOM docs
modules: module.h kerneldoc annotations
modules: hook up modules.h to docs build
accel: autoload modules
accel: add qtest module annotations
accel: build qtest modular
accel: add tcg module annotations
accel: build tcg modular
monitor: allow register hmp commands
usb: drop usb_host_dev_is_scsi_storage hook monitor/usb: register 'info usbhost' dynamically
usb: build usb-host as module
monitor/tcg: move tcg hmp commands to accel/tcg, register them
dynamically
Jose R. Ziviani (1):
modules: check if all dependencies can be satisfied
scripts/modinfo-collect.py | 67 +++++++++++ scripts/modinfo-generate.py | 97 ++++++++++++++++ include/hw/usb.h | 7 +- include/monitor/monitor.h | 3 + include/qemu/module.h | 74 ++++++++++++ accel/accel-common.c | 2 +- accel/accel-softmmu.c | 2 +- accel/qtest/qtest.c | 2 + accel/tcg/hmp.c | 29 +++++ accel/tcg/tcg-accel-ops.c | 1 + accel/tcg/tcg-all.c | 1 + audio/spiceaudio.c | 2 + block/iscsi-opts.c | 1 + chardev/baum.c | 1 + chardev/spice.c | 4 + hw/display/qxl.c | 4 + hw/display/vhost-user-gpu-pci.c | 1 + hw/display/vhost-user-gpu.c | 1 + hw/display/vhost-user-vga.c | 1 + hw/display/virtio-gpu-base.c | 1 + hw/display/virtio-gpu-gl.c | 3 + hw/display/virtio-gpu-pci-gl.c | 3 + hw/display/virtio-gpu-pci.c | 2 + hw/display/virtio-gpu.c | 1 + hw/display/virtio-vga-gl.c | 3 + hw/display/virtio-vga.c | 2 + hw/ppc/spapr.c | 2 +- hw/s390x/virtio-ccw-gpu.c | 3 + hw/usb/ccid-card-emulated.c | 1 + hw/usb/ccid-card-passthru.c | 1 + hw/usb/dev-storage-bot.c | 1 + hw/usb/dev-storage-classic.c | 1 + hw/usb/dev-uas.c | 1 + hw/usb/host-libusb.c | 38 ++---- hw/usb/host-stub.c | 45 ------- hw/usb/redirect.c | 1 + monitor/hmp.c | 7 ++ monitor/misc.c | 34 +++--- softmmu/vl.c | 24 ++-- stubs/module-opts.c | 4 - ui/egl-headless.c | 4 + ui/gtk.c | 4 + ui/sdl2.c | 4 + ui/spice-app.c | 3 + ui/spice-core.c | 5 + util/module.c | 200 ++++++++++++++++++-------------- accel/qtest/meson.build | 8 +- accel/tcg/meson.build | 6 +- docs/devel/build-system.rst | 17 +++ docs/devel/index.rst | 1 + docs/devel/modules.rst | 5 + docs/devel/qom.rst | 8 ++ hmp-commands-info.hx | 3 - hw/usb/meson.build | 10 +- meson.build | 82 +++++++++++++ util/trace-events | 4 + 56 files changed, 624 insertions(+), 218 deletions(-) create mode 100755 scripts/modinfo-collect.py create mode 100755 scripts/modinfo-generate.py create mode 100644 accel/tcg/hmp.c delete mode 100644 hw/usb/host-stub.c create mode 100644 docs/devel/modules.rst
Signature · 1 line
2.31.1