Skip to content

Updates for Radxa ROCK Pi 4

Alex Bee linux-arm-kernel linux-devicetree linux-rockchip lkml 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest5 patches 2 repliesApplied

Changes in v2 from the cover letter

- added additional compatibles for the new revisions (Heiko)
- renamed ES8316 audio card name to "Analog" (Johan)
- added patch for SPDIF
- aligned spelling of board name(s)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5dt-bindings: Add doc for ROCK Pi 4 A+ and B+Documentation/devicetree/bindings/arm/rockchip.yaml+3 -11 reply
2/5arm64: dts: rockchip: Add RK3399 ROCK Pi 4A+ boardarch/arm64/boot/dts/rockchip/Makefile arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a-plus.dts+15 -00 replies
3/5arm64: dts: rockchip: Add RK3399 ROCK Pi 4B+ boardarch/arm64/boot/dts/rockchip/Makefile arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts+48 -00 replies
4/5arm64: dts: rockchip: add ES8316 codec for ROCK Pi 4arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi+28 -00 replies
5/5arm64: dts: rockchip: add SPDIF node for ROCK Pi 4arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi+26 -00 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/5A-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] Updates for Radxa ROCK Pi 4

Hi list,

This series adds support for 2 new revisions of Radxa's ROCK Pi 4, namely ROCK Pi 4A+ and ROCK Pi 4B+. While most things are in common with the previous 4A and 4B revisions, they have OP1 revision of the SoC and eMMC soldered on board.
Patch 4 and 5 add SPDIF and anlog Codec to the common device tree, since they are in place in previous revisions as well. It superseeds
https://lore.kernel.org/linux-rockchip/[email protected]/

There is no example (which I could find) for Rockchip on how to deal with "+" revisions - so I looked up other SoCs and the rule seems to be to use the "+" for the model name (which is the "offical" name), but use "-plus" for compatible name and device tree files names (see "Raspberry Pi Model A+", for instance).

A short node for testing ES8316 codec:
The driver disables the headphone jack by default - for testing one would have to enable it via amixer with:
amixer [card index] 'Right Headphone Mixer Right DAC' on amixer [card index] 'Left Headphone Mixer Left DAC' on

Alex

Changes in v2:
- added additional compatibles for the new revisions (Heiko)
- renamed ES8316 audio card name to "Analog" (Johan)
- added patch for SPDIF
- aligned spelling of board name(s)

Alex Bee (5):
dt-bindings: Add doc for ROCK Pi 4 A+ and B+
arm64: dts: rockchip: Add RK3399 ROCK Pi 4A+ board
arm64: dts: rockchip: Add RK3399 ROCK Pi 4B+ board
arm64: dts: rockchip: add ES8316 codec for ROCK Pi 4
arm64: dts: rockchip: add SPDIF node for ROCK Pi 4

 .../devicetree/bindings/arm/rockchip.yaml     |  4 +-
 arch/arm64/boot/dts/rockchip/Makefile         |  2 +
 .../boot/dts/rockchip/rk3399-rock-pi-4.dtsi   | 54 +++++++++++++++++++
 .../dts/rockchip/rk3399-rock-pi-4a-plus.dts   | 14 +++++
 .../dts/rockchip/rk3399-rock-pi-4b-plus.dts   | 47 ++++++++++++++++
 5 files changed, 120 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a-plus.dts
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts

base-commit: 009c9aa5be652675a06d5211e1640e02bbb1c33d

Signature · 1 line
2.27.0