Skip to content

delete useless function return values & remove meaningless if(r) check code

Bernard Zhao amd-gfx dri-devel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/radeon: remove meaningless if(r) check codedrivers/gpu/drm/radeon/cik.c drivers/gpu/drm/radeon/evergreen.c drivers/gpu/drm/radeon/ni.c +1 more+4 -120 replies
2/4drm/radeon: remove meaningless if(r) check codedrivers/gpu/drm/radeon/r100.c drivers/gpu/drm/radeon/r300.c drivers/gpu/drm/radeon/r420.c +2 more+5 -160 replies
3/4drm/radeon: remove meaningless if(r) check codedrivers/gpu/drm/radeon/rs400.c drivers/gpu/drm/radeon/rs600.c drivers/gpu/drm/radeon/rs690.c +2 more+5 -150 replies
4/4drm/radeon: delete useless return valuesdrivers/gpu/drm/radeon/radeon.h drivers/gpu/drm/radeon/radeon_fence.c+2 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] delete useless function return values & remove meaningless if(r) check code

Function radeon_fence_driver_init always returns success, the function type maybe coule be changed to void. This patch series will first delete the check of the return value of the function call radeon_fence_driver_init, then, optimise the function declaration and function to void type.

Bernard Zhao (4):
drm/radeon: remove meaningless if(r) check code drm/radeon: remove meaningless if(r) check code drm/radeon: remove meaningless if(r) check code drm/radeon: delete useless return values

 drivers/gpu/drm/radeon/cik.c          | 4 +---
 drivers/gpu/drm/radeon/evergreen.c    | 4 +---
 drivers/gpu/drm/radeon/ni.c           | 4 +---
 drivers/gpu/drm/radeon/r100.c         | 4 +---
 drivers/gpu/drm/radeon/r300.c         | 4 +---
 drivers/gpu/drm/radeon/r420.c         | 5 +----
 drivers/gpu/drm/radeon/r520.c         | 4 +---
 drivers/gpu/drm/radeon/r600.c         | 4 +---
 drivers/gpu/drm/radeon/radeon.h       | 2 +-
 drivers/gpu/drm/radeon/radeon_fence.c | 5 +----
 drivers/gpu/drm/radeon/rs400.c        | 4 +---
 drivers/gpu/drm/radeon/rs600.c        | 4 +---
 drivers/gpu/drm/radeon/rs690.c        | 4 +---
 drivers/gpu/drm/radeon/rv515.c        | 4 +---
 drivers/gpu/drm/radeon/rv770.c        | 4 +---
 drivers/gpu/drm/radeon/si.c           | 4 +---
 16 files changed, 16 insertions(+), 48 deletions(-)
Signature · 1 line
2.31.0