Skip to content

Overwritten file detection and fixes, one more step to TLP build

Herve Codina buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15package/pkg-generic.mk: detect files overwritten in TARGET_DIR and HOST_DIRpackage/pkg-generic.mk+23 -01 reply
1/15package/pkg-generic.mk: detect files overwritten in TARGET_DIR and HOST_DIR+0 -03 replies
1/15package/pkg-generic.mk: detect files overwritten in TARGET_DIR and HOST_DIR+0 -01 reply
2/15package/e2fsprogs: fix fsck overwrite in HOST_DIRpackage/e2fsprogs/e2fsprogs.mk+1 -02 replies
2/15package/e2fsprogs: fix fsck overwrite in HOST_DIR+0 -00 replies
2/15package/e2fsprogs: fix fsck overwrite in HOST_DIR+0 -00 replies
3/15package/pkg-generic.mk: Remove Info documents dir entrypackage/pkg-generic.mk+3 -01 reply
3/15package/pkg-generic.mk: Remove Info documents dir entry+0 -02 replies
3/15package/pkg-generic.mk: Remove Info documents dir entry+0 -00 replies
4/15package/pkg-generic.mk: Fix .la files overwrite detectionpackage/pkg-generic.mk+1 -12 replies
4/15package/pkg-generic.mk: Fix .la files overwrite detection+0 -03 replies
4/15package/pkg-generic.mk: Fix .la files overwrite detection+0 -00 replies
4/15package/pkg-generic.mk: Fix .la files overwrite detection+0 -01 reply
5/15package/pkg-generic.mk: Perform .la files fixup in per-package HOST_DIRpackage/pkg-generic.mk+3 -12 replies
5/15package/pkg-generic.mk: Perform .la files fixup in per-package HOST_DIR+0 -00 replies
5/15package/pkg-generic.mk: Perform .la files fixup in per-package HOST_DIR+0 -00 replies
6/15package/pkg-generic.mk: Introduce <PKG>_PER_PACKAGE_TWEAK_HOOKSpackage/pkg-generic.mk+2 -03 replies
6/15package/pkg-generic.mk: Introduce <PKG>_PER_PACKAGE_TWEAK_HOOKS+0 -00 replies
6/15package/pkg-generic.mk: Introduce <PKG>_PER_PACKAGE_TWEAK_HOOKS+0 -00 replies
6/15package/pkg-generic.mk: Introduce <PKG>_PER_PACKAGE_TWEAK_HOOKS+0 -01 reply
7/15package/apr-util: Use <PKG>_PER_PACKAGE_TWEAK_HOOKSpackage/apr-util/apr-util.mk+8 -41 reply
7/15package/apr-util: Use <PKG>_PER_PACKAGE_TWEAK_HOOKS+0 -01 reply
7/15package/apr-util: Use <PKG>_PER_PACKAGE_TWEAK_HOOKS+0 -00 replies
8/15package/apache: Move APACHE_FIXUP_APR_LIBTOOL to <PKG>_PER_PACKAGE_TWEAK_HOOKSpackage/apache/apache.mk+1 -11 reply
9/15package/pkg-python: Remove _sysconfigdata*.pyc files when _sysconfigdata*.py are changedpackage/pkg-python.mk+3 -11 reply
9/15package/pkg-python: Remove _sysconfigdata*.pyc files when _sysconfigdata*.py are changed+0 -01 reply
9/15package/pkg-python: Remove _sysconfigdata*.pyc files when _sysconfigdata*.py are changed+0 -00 replies
10/15package/pkg-generic.mk: Move python fixup to generic package infrastructurepackage/pkg-generic.mk package/pkg-python.mk+17 -121 reply
10/15package/pkg-generic.mk: Move python fixup to generic package infrastructure+0 -01 reply
11/15package/owfs: Remove Python sysconfigdata fixuppackage/owfs/owfs.mk+0 -91 reply
11/15package/owfs: Remove Python sysconfigdata fixup+0 -00 replies
12/15package/pkg-generic.mk: Generate final rsync exclude file listpackage/pkg-generic.mk+28 -01 reply
12/15package/pkg-generic.mk: Generate final rsync exclude file list+0 -01 reply
13/15Makefile: Rsync global {TARGET, HOST}_DIR using exclusion file listMakefile+22 -22 replies
13/15Makefile: Rsync global {TARGET, HOST}_DIR using exclusion file list+0 -01 reply
13/15Makefile: Rsync global {TARGET, HOST}_DIR using exclusion file list+0 -00 replies
14/15Makefile: Breaks hardlinks in global {TARGET, HOST}_DIR on per-package buildMakefile+1 -11 reply
15/15package/pkg-generic.mk: Fix per-package <pkg>-{reconfigure, rebuild, reinstall}package/pkg-generic.mk+26 -01 reply
15/15package/pkg-generic.mk: Fix per-package <pkg>-{reconfigure, rebuild, reinstall}+0 -00 replies

Reviews trailers per patch

14 of 39 patches have a Reviewed-by or Acked-by.

PatchThomas PetazzoniYann E. MORIN
1/15
1/15
1/15
2/15R-b R-b
2/15R-b R-b
2/15R-b R-b
3/15
3/15
3/15
4/15R-b
4/15R-b
4/15R-b
4/15R-b
5/15
5/15
5/15
6/15
6/15
6/15
6/15
7/15R-b
7/15R-b
7/15R-b
8/15R-b
9/15
9/15
9/15
10/15
10/15
11/15R-b
11/15R-b
12/15
12/15
13/15
13/15
13/15
14/15R-b
15/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Buildroot] [PATCH 00/15] Overwritten file detection and fixes, one more step to TLP build

Hi,

This series fixes some issues in the TLP build feature.
The starting point was the work done by Thomas Petazzoni on overwrites detection (PATCH 1).

Based on this work, this series fixes some overwrites, introduces and uses <PKG>_PER_PACKAGE_TWEAK_HOOKS. This variable is used to collect specific per-package path tweaks needed by per-package build.
With this tweaks collected in this variable, they can be re-applied when they are needed (<pkg>_{reconfigure,rebuild,reinstall}).

It also reworks the final {HOST,TARGET}_DIR rsync.
For each packages only files generated by the package are rsynced (PATCH 13). This is done using an exclusion list computed in (PATCH 12).
In order to avoid modifications performed in target-finalize step to be seen as overwrites on next build, the final {HOST,TARGET}_DIR do not contain any hardlink anymore and are a full copy of expected files and directories (PATCH 14).

The last patch (PATCH 15) fixes <pkg>_{reconfigure,rebuild,reinstall} recreating per-package {HOST,TARGET}_DIR from scratch.
Indeed, for a given package, re-generating the same file is detected as an overwrite. The simplest way to avoid this is to fully discard previous per-package {HOST,TARGET}_DIR directory and recreate them.

To have a TLP build fully fonctionnal, several things are still missing:
- Be sure that all buildroot packages do not perform any overwrites.
- Undo tweak stuff that have be done for per-package build (fixup-libtool-files, fixup-python-files, <PKG>_PER_PACKAGE_TWEAK_HOOKS) after collecting files in final {HOST,STAGING}_DIR.
This mainly means reverting .../per-package/xxxxx/... path to point to the correct ones in final {HOST,STAGING}_DIR.

I hope this series will help in TLP build feature.

Best regards,
Herv? Codina

Herve Codina (14):
package/e2fsprogs: fix fsck overwrite in HOST_DIR package/pkg-generic.mk: Remove Info documents dir entry package/pkg-generic.mk: Fix .la files overwrite detection package/pkg-generic.mk: Perform .la files fixup in per-package
HOST_DIR
package/pkg-generic.mk: Introduce <PKG>_PER_PACKAGE_TWEAK_HOOKS package/apr-util: Use <PKG>_PER_PACKAGE_TWEAK_HOOKS package/apache: Move APACHE_FIXUP_APR_LIBTOOL to
<PKG>_PER_PACKAGE_TWEAK_HOOKS
package/pkg-python: Remove _sysconfigdata*.pyc files when
_sysconfigdata*.py are changed
package/pkg-generic.mk: Move python fixup to generic package
infrastructure
package/owfs: Remove Python sysconfigdata fixup package/pkg-generic.mk: Generate final rsync exclude file list
Makefile: Rsync global {TARGET,HOST}_DIR using exclusion file list
Makefile: Breaks hardlinks in global {TARGET,HOST}_DIR on per-package
build
package/pkg-generic.mk: Fix per-package

    <pkg>-{reconfigure,rebuild,reinstall}

Thomas Petazzoni (1):
package/pkg-generic.mk: detect files overwritten in TARGET_DIR and
HOST_DIR

 Makefile                       |  24 +++++++-
 package/apache/apache.mk       |   2 +-
 package/apr-util/apr-util.mk   |  12 ++--
 package/e2fsprogs/e2fsprogs.mk |   1 +
 package/owfs/owfs.mk           |   9 ---
 package/pkg-generic.mk         | 103 ++++++++++++++++++++++++++++++++-
 package/pkg-python.mk          |  10 ----
 7 files changed, 134 insertions(+), 27 deletions(-)
Signature · 1 line
2.31.1