RFC KVM: PPC: Book3S HV P9: entry/exit optimisations round 1
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest43 patches 23 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/43 | powerpc/64s: Remove WORT SPR from POWER9/10arch/ arch/ | +0 | 1 reply | |
| 2/43 | KMV: PPC: Book3S HV P9: Use set_dec to set decrementer to hostarch/ | +1 | 0 replies | |
| 3/43 | KVM: PPC: Book3S HV P9: Use host timer accounting to avoid decrementer readarch/ arch/ arch/ | +13 | 0 replies | |
| 4/43 | KVM: PPC: Book3S HV P9: Use large decrementer for HDECarch/ arch/ arch/ | +5 | 0 replies | |
| 5/43 | KVM: PPC: Book3S HV P9: Reduce mftb per guest entry/exitarch/ arch/ | +5 | 0 replies | |
| 6/43 | powerpc/time: add API for KVM to re-arm the host timer/decrementerarch/ arch/ arch/ | +49 | 0 replies | |
| 7/43 | KVM: PPC: Book3S HV: POWER10 enable HAIL when running radix guestsarch/ | +25 | 1 reply | |
| 8/43 | powerpc/64s: Keep AMOR SPR a constant ~0 at runtimearch/ arch/ arch/ +3 more | +13 | 1 reply | |
| 9/43 | KVM: PPC: Book3S HV: Don't always save PMU for guest capable of nestingarch/ | +0 | 0 replies | |
| 10/43 | powerpc/64s: Always set PMU control registers to frozen/disabled when not in usearch/ arch/ arch/ +1 more | +17 | 9 replies | |
| 11/43 | KVM: PPC: Book3S HV P9: Implement PMU save/restore in Carch/ arch/ arch/ +1 more | +200 | 3 replies | |
| 12/43 | KVM: PPC: Book3S HV P9: Factor out yield_count incrementarch/ | +12 | 1 reply | |
| 13/43 | KVM: PPC: Book3S HV P9: Factor PMU save/load into context switch functionsarch/ | +23 | 0 replies | |
| 14/43 | KVM: PPC: Book3S HV P9: Demand fault PMU SPRs when marked not inusearch/ arch/ arch/ | +105 | 0 replies | |
| 15/43 | KVM: PPC: Book3S HV: CTRL SPR does not require read-modify-writearch/ arch/ | +7 | 0 replies | |
| 16/43 | KVM: PPC: Book3S HV P9: Move SPRG restore to restore_p9_host_os_sprsarch/ | +2 | 0 replies | |
| 17/43 | KVM: PPC: Book3S HV P9: Reduce mtmsrd instructions required to save host SPRsarch/ arch/ arch/ | +64 | 0 replies | |
| 18/43 | KVM: PPC: Book3S HV P9: Improve mtmsrd scheduling by delaying MSR[EE] disablearch/ | +18 | 0 replies | |
| 19/43 | KVM: PPC: Book3S HV P9: Add kvmppc_stop_thread to match kvmppc_start_threadarch/ | +9 | 1 reply | |
| 20/43 | KVM: PPC: Book3S HV: Change dec_expires to be relative to guest timebasearch/ arch/ arch/ +3 more | +49 | 0 replies | |
| 21/43 | KVM: PPC: Book3S HV P9: Move TB updatesarch/ | +18 | 0 replies | |
| 22/43 | KVM: PPC: Book3S HV P9: Optimise timebase readsarch/ arch/ arch/ | +65 | 0 replies | |
| 23/43 | KVM: PPC: Book3S HV P9: Avoid SPR scoreboard stallsarch/ arch/ | +15 | 0 replies | |
| 24/43 | KVM: PPC: Book3S HV P9: Only execute mtSPR if the value changedarch/ | +39 | 0 replies | |
| 25/43 | KVM: PPC: Book3S HV P9: Juggle SPR switching aroundarch/ | +4 | 0 replies | |
| 26/43 | KVM: PPC: Book3S HV P9: Move vcpu register save/restore into functionsarch/ | +33 | 0 replies | |
| 27/43 | KVM: PPC: Book3S HV P9: Move host OS save/restore functions to built-inarch/ arch/ arch/ | +372 | 2 replies | |
| 28/43 | KVM: PPC: Book3S HV P9: Move nested guest entry into its own functionarch/ | +67 | 0 replies | |
| 29/43 | KVM: PPC: Book3S HV P9: Move remaining SPR and MSR access into low level entryarch/ arch/ | +96 | 0 replies | |
| 30/43 | KVM: PPC: Book3S HV P9: Implement TM fastpath for guest entry/exitarch/ | +20 | 0 replies | |
| 31/43 | KVM: PPC: Book3S HV P9: Switch PMU to guest as late as possiblearch/ arch/ | +4 | 0 replies | |
| 32/43 | KVM: PPC: Book3S HV P9: Restrict DSISR canary workaround to processors that requirarch/ arch/ | +6 | 0 replies | |
| 33/43 | KVM: PPC: Book3S HV P9: More SPR speed improvementsarch/ | +40 | 0 replies | |
| 34/43 | KVM: PPC: Book3S HV P9: Demand fault EBB facility registersarch/ arch/ arch/ +1 more | +34 | 1 reply | |
| 35/43 | KVM: PPC: Book3S HV P9: Demand fault TM facility registersarch/ arch/ arch/ +1 more | +31 | 1 reply | |
| 36/43 | KVM: PPC: Book3S HV P9: Use Linux SPR save/restore to manage some host SPRsarch/ arch/ arch/ +2 more | +72 | 0 replies | |
| 37/43 | KVM: PPC: Book3S HV P9: Comment and fix MMU context switching codearch/ arch/ | +33 | 0 replies | |
| 38/43 | KVM: PPC: Book3S HV P9: Test dawr_enabled() before saving host DAWR SPRsarch/ | +20 | 2 replies | |
| 39/43 | KVM: PPC: Book3S HV P9: Don't restore PSSCR if not neededarch/ arch/ | +24 | 0 replies | |
| 40/43 | KVM: PPC: Book3S HV P9: Avoid tlbsync sequence on radix guest exitarch/ arch/ | +26 | 0 replies | |
| 41/43 | KVM: PPC: Book3S HV Nested: Avoid extra mftb() in nested entryarch/ arch/ arch/ | +13 | 0 replies | |
| 42/43 | KVM: PPC: Book3S HV P9: Improve mfmsr performance on entryarch/ arch/ arch/ | +47 | 0 replies | |
| 43/43 | KVM: PPC: Book3S HV P9: Optimise hash guest SLB savingarch/ | +18 | 0 replies |
Reviews trailers per patch
9 of 43 patches have a Reviewed-by or Acked-by.
| Patch | Alexey Kardashevskiy | Fabiano Rosas |
|---|---|---|
| 1/43 | R-b | |
| 2/43 | ||
| 3/43 | ||
| 4/43 | R-b | |
| 5/43 | R-b | |
| 6/43 | ||
| 7/43 | R-b | |
| 8/43 | R-b | |
| 9/43 | ||
| 10/43 | ||
| 11/43 | ||
| 12/43 | R-b | |
| 13/43 | ||
| 14/43 | ||
| 15/43 | ||
| 16/43 | ||
| 17/43 | ||
| 18/43 | ||
| 19/43 | R-b | |
| 20/43 | ||
| 21/43 | ||
| 22/43 | ||
| 23/43 | ||
| 24/43 | ||
| 25/43 | ||
| 26/43 | ||
| 27/43 | ||
| 28/43 | ||
| 29/43 | ||
| 30/43 | ||
| 31/43 | ||
| 32/43 | ||
| 33/43 | ||
| 34/43 | R-b | |
| 35/43 | R-b | |
| 36/43 | ||
| 37/43 | ||
| 38/43 | ||
| 39/43 | ||
| 40/43 | ||
| 41/43 | ||
| 42/43 | ||
| 43/43 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 00/43] KVM: PPC: Book3S HV P9: entry/exit optimisations round 1
This series applies to powerpc topic/ppc-kvm branch (KVM Cify series in particular), plus "KVM: PPC: Book3S HV Nested: Reflect L2 PMU in-use to L0 when L2 SPRs are live" posted to kvm-ppc.
This reduces radix guest full entry/exit latency on POWER9 and POWER10 by almost 2x (hash is similar but it's still significantly slower than the P7/8 real mode handler). Nested HV guests should see speedups with some smaller improvements in the L1, plus the L0 switching sees many of the same speedups as a direct guest.
It does this in several main ways:
- Rearrange code to optimise SPR accesses. Mainly, avoid scoreboard stalls.
- Test SPR values to avoid mtSPRs where possible. mtSPRs are expensive.
- Reduce mftb. mftb is expensive.
- Demand fault certain facilities to avoid saving and/or restoring them (at the cost of fault when they are used, but this is mitigated over a number of entries, like the facilities when context switching processes). PM, TM, and EBB so far.
- Defer some sequences that are made just in case a guest is interrupted in the middle of a critical section to the case where the guest is scheduled on a different CPU, rather than every time (at the cost of an extra IPI in this case). Namely the tlbsync sequence for radix with GTSE, which is very expensive.
Some of the numbers quoted in changelogs may have changed a bit with patches being updated, reordered, etc. They give a bit of a guide, but I might remove them from the final submission because they're too much to maintain.
Thanks,
Nick
Nicholas Piggin (43):
powerpc/64s: Remove WORT SPR from POWER9/10
KMV: PPC: Book3S HV P9: Use set_dec to set decrementer to host
KVM: PPC: Book3S HV P9: Use host timer accounting to avoid decrementer
read
KVM: PPC: Book3S HV P9: Use large decrementer for HDEC
KVM: PPC: Book3S HV P9: Reduce mftb per guest entry/exit powerpc/time: add API for KVM to re-arm the host timer/decrementer
KVM: PPC: Book3S HV: POWER10 enable HAIL when running radix guests powerpc/64s: Keep AMOR SPR a constant ~0 at runtime
KVM: PPC: Book3S HV: Don't always save PMU for guest capable of
nesting
powerpc/64s: Always set PMU control registers to frozen/disabled when
not in use
KVM: PPC: Book3S HV P9: Implement PMU save/restore in C
KVM: PPC: Book3S HV P9: Factor out yield_count increment
KVM: PPC: Book3S HV P9: Factor PMU save/load into context switch
functions
KVM: PPC: Book3S HV P9: Demand fault PMU SPRs when marked not inuse
KVM: PPC: Book3S HV: CTRL SPR does not require read-modify-write
KVM: PPC: Book3S HV P9: Move SPRG restore to restore_p9_host_os_sprs
KVM: PPC: Book3S HV P9: Reduce mtmsrd instructions required to save
host SPRs
KVM: PPC: Book3S HV P9: Improve mtmsrd scheduling by delaying MSR[EE]
disable
KVM: PPC: Book3S HV P9: Add kvmppc_stop_thread to match
kvmppc_start_thread
KVM: PPC: Book3S HV: Change dec_expires to be relative to guest
timebase
KVM: PPC: Book3S HV P9: Move TB updates
KVM: PPC: Book3S HV P9: Optimise timebase reads
KVM: PPC: Book3S HV P9: Avoid SPR scoreboard stalls
KVM: PPC: Book3S HV P9: Only execute mtSPR if the value changed
KVM: PPC: Book3S HV P9: Juggle SPR switching around
KVM: PPC: Book3S HV P9: Move vcpu register save/restore into functions
KVM: PPC: Book3S HV P9: Move host OS save/restore functions to
built-in
KVM: PPC: Book3S HV P9: Move nested guest entry into its own function
KVM: PPC: Book3S HV P9: Move remaining SPR and MSR access into low
level entry
KVM: PPC: Book3S HV P9: Implement TM fastpath for guest entry/exit
KVM: PPC: Book3S HV P9: Switch PMU to guest as late as possible
KVM: PPC: Book3S HV P9: Restrict DSISR canary workaround to processors
that require it
KVM: PPC: Book3S HV P9: More SPR speed improvements
KVM: PPC: Book3S HV P9: Demand fault EBB facility registers
KVM: PPC: Book3S HV P9: Demand fault TM facility registers
KVM: PPC: Book3S HV P9: Use Linux SPR save/restore to manage some host
SPRs
KVM: PPC: Book3S HV P9: Comment and fix MMU context switching code
KVM: PPC: Book3S HV P9: Test dawr_enabled() before saving host DAWR
SPRs
KVM: PPC: Book3S HV P9: Don't restore PSSCR if not needed
KVM: PPC: Book3S HV P9: Avoid tlbsync sequence on radix guest exit
KVM: PPC: Book3S HV Nested: Avoid extra mftb() in nested entry
KVM: PPC: Book3S HV P9: Improve mfmsr performance on entry
KVM: PPC: Book3S HV P9: Optimise hash guest SLB saving
arch/powerpc/include/asm/asm-prototypes.h | 5 - arch/powerpc/include/asm/kvm_asm.h | 1 + arch/powerpc/include/asm/kvm_book3s.h | 6 + arch/powerpc/include/asm/kvm_book3s_64.h | 4 +- arch/powerpc/include/asm/kvm_host.h | 5 +- arch/powerpc/include/asm/switch_to.h | 2 + arch/powerpc/include/asm/time.h | 19 +- arch/powerpc/kernel/cpu_setup_power.c | 12 +- arch/powerpc/kernel/dt_cpu_ftrs.c | 8 +- arch/powerpc/kernel/process.c | 30 + arch/powerpc/kernel/time.c | 54 +- arch/powerpc/kvm/book3s_64_mmu_radix.c | 4 + arch/powerpc/kvm/book3s_hv.c | 628 +++++++++---------- arch/powerpc/kvm/book3s_hv.h | 36 ++ arch/powerpc/kvm/book3s_hv_interrupts.S | 13 +- arch/powerpc/kvm/book3s_hv_nested.c | 21 +- arch/powerpc/kvm/book3s_hv_p9_entry.c | 725 +++++++++++++++++++--- arch/powerpc/kvm/book3s_hv_rmhandlers.S | 74 +-- arch/powerpc/mm/book3s64/radix_pgtable.c | 15 - arch/powerpc/perf/core-book3s.c | 7 + arch/powerpc/platforms/powernv/idle.c | 10 +- 21 files changed, 1143 insertions(+), 536 deletions(-) create mode 100644 arch/powerpc/kvm/book3s_hv.h
Signature · 1 line
2.23.0