Skip to content

KVM: selftests: Add x86 mmu_role test and cleanups

Sean Christopherson kvm lkml 1 version Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/19KVM: selftests: Remove errant asm/barrier.h include to fix arm64 buildtools/testing/selftests/kvm/dirty_log_test.c+0 -10 replies
2/19KVM: selftests: Zero out the correct page in the Hyper-V features testtools/testing/selftests/kvm/x86_64/hyperv_features.c+1 -10 replies
3/19KVM: selftests: Unconditionally use memslot 0 when loading elf binarytools/testing/selftests/kvm/dirty_log_test.c tools/testing/selftests/kvm/hardware_disable_test.c tools/testing/selftests/kvm/include/kvm_util.h +3 more+7 -100 replies
4/19KVM: selftests: Unconditionally use memslot 0 for x86's GDT/TSS setuptools/testing/selftests/kvm/lib/x86_64/processor.c+8 -100 replies
5/19KVM: selftests: Use "standard" min virtual address for Hyper-V pagestools/testing/selftests/kvm/x86_64/hyperv_features.c+1 -10 replies
6/19KVM: selftests: Add helpers to allocate N pages of virtual memorytools/testing/selftests/kvm/include/kvm_util.h tools/testing/selftests/kvm/lib/kvm_util.c tools/testing/selftests/kvm/lib/x86_64/svm.c +3 more+59 -240 replies
7/19KVM: selftests: Lower the min virtual address for misc page allocationstools/testing/selftests/kvm/lib/kvm_util.c+1 -10 replies
8/19KVM: selftests: Use alloc_page helper for x86-64's GDT/ITD/TSS allocationstools/testing/selftests/kvm/lib/x86_64/processor.c+4 -60 replies
9/19KVM: selftests: Use alloc page helper for xAPIC IPI testtools/testing/selftests/kvm/x86_64/xapic_ipi_test.c+1 -10 replies
10/19KVM: selftests: Use "standard" min virtual address for CPUID test alloctools/testing/selftests/kvm/x86_64/get_cpuid_test.c+1 -20 replies
11/19KVM: selftest: Unconditionally use memslot 0 for vaddr allocationstools/testing/selftests/kvm/include/kvm_util.h tools/testing/selftests/kvm/lib/aarch64/processor.c tools/testing/selftests/kvm/lib/elf.c +4 more+18 -210 replies
12/19KVM: selftests: Unconditionally use memslot '0' for page table allocationstools/testing/selftests/kvm/dirty_log_test.c tools/testing/selftests/kvm/include/kvm_util.h tools/testing/selftests/kvm/kvm_page_table_test.c +13 more+31 -350 replies
13/19KVM: selftests: Unconditionally allocate EPT tables in memslot 0tools/testing/selftests/kvm/include/x86_64/vmx.h tools/testing/selftests/kvm/lib/x86_64/vmx.c tools/testing/selftests/kvm/x86_64/vmx_apic_access_test.c +1 more+17 -220 replies
14/19KVM: selftests: Add wrapper to allocate page table pagetools/testing/selftests/kvm/include/kvm_util.h tools/testing/selftests/kvm/lib/aarch64/processor.c tools/testing/selftests/kvm/lib/kvm_util.c +3 more+23 -390 replies
15/19KVM: selftests: Rename x86's page table "address" to "pfn"tools/testing/selftests/kvm/lib/x86_64/processor.c+22 -250 replies
16/19KVM: selfests: Add PTE helper for x86-64 in preparation for hugepagestools/testing/selftests/kvm/lib/x86_64/processor.c+31 -280 replies
17/19KVM: selftests: Genericize upper level page table entry structtools/testing/selftests/kvm/lib/x86_64/processor.c+26 -650 replies
18/19KVM: selftests: Add hugepage support for x86-64tools/testing/selftests/kvm/include/x86_64/processor.h tools/testing/selftests/kvm/lib/x86_64/processor.c+67 -240 replies
19/19KVM: sefltests: Add x86-64 test to verify MMU reacts to CPUID updatestools/testing/selftests/kvm/.gitignore tools/testing/selftests/kvm/Makefile tools/testing/selftests/kvm/include/x86_64/processor.h +1 more+152 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/19] KVM: selftests: Add x86 mmu_role test and cleanups

The primary intent of this series is to allow x86-64 tests to create arbitrary hugepages and use the new functionality to abuse x86's CPUID APIs to test KVM MMU behavior.

The majority of the prep work refactors the selftests APIs related to memory allocation. The core memory allocation APIs within the selftests don't provide defaults for memslot or min virtual address, which has led to a ridiculous amount of magic and duplicate code. Literally zero tests use non-standard values in a meaningful way, and if a test comes along that has a legitimate use case, it should use lower-level helpers.

Patches 01 and 02 are fixes for bugs found during the refactoring.

As for the mmu_role test itself, the idea is to change the vCPU model while the guest is running (via KVM_SET_CPUID2) to verify that KVM reconfigures its MMUs when the vCPU model is changed. E.g. toggling guest support for 1gb hugepages and changing guest MAXPHYADDR.

Sadly, the test doesn't pass when KVM is using TDP paging (even with all my mmu_role fixes) because KVM doesn't fully support manipulating GBPAGES and MAXPHYADDR (and other CPUID-based properties that affect the MMU) while the guest is running. And practically speaking, KVM will never fully support such behavior becuase (a) there is likely no sane use case,
(b) fixing the issues is very costly (memory consumption), (c) GBPAGES and potentially other features _can't_ be handled correctly due to lack of hardware support, and (d) userspace can workaround all issues simply by deleting a memslot.

All that said, I purposely made the test off-by-default instead of requiring TDP. Partly because detecting whether TDP is enabled is a pain becuase it's per-vendor, but also because running the test with TDP enabled is still interesting to some extent, e.g. the test will fail, but it shouldn't crash KVM, trigger WARNs, etc...

Sean Christopherson (19):
KVM: selftests: Remove errant asm/barrier.h include to fix arm64 build
KVM: selftests: Zero out the correct page in the Hyper-V features test
KVM: selftests: Unconditionally use memslot 0 when loading elf binary
KVM: selftests: Unconditionally use memslot 0 for x86's GDT/TSS setup
KVM: selftests: Use "standard" min virtual address for Hyper-V pages
KVM: selftests: Add helpers to allocate N pages of virtual memory
KVM: selftests: Lower the min virtual address for misc page
allocations
KVM: selftests: Use alloc_page helper for x86-64's GDT/ITD/TSS
allocations
KVM: selftests: Use alloc page helper for xAPIC IPI test
KVM: selftests: Use "standard" min virtual address for CPUID test
alloc
KVM: selftest: Unconditionally use memslot 0 for vaddr allocations
KVM: selftests: Unconditionally use memslot '0' for page table
allocations
KVM: selftests: Unconditionally allocate EPT tables in memslot 0
KVM: selftests: Add wrapper to allocate page table page
KVM: selftests: Rename x86's page table "address" to "pfn"
KVM: selfests: Add PTE helper for x86-64 in preparation for hugepages
KVM: selftests: Genericize upper level page table entry struct
KVM: selftests: Add hugepage support for x86-64
KVM: sefltests: Add x86-64 test to verify MMU reacts to CPUID updates

 tools/testing/selftests/kvm/.gitignore        |   1 +
 tools/testing/selftests/kvm/Makefile          |   1 +
 tools/testing/selftests/kvm/dirty_log_test.c  |   5 +-
 .../selftests/kvm/hardware_disable_test.c     |   2 +-
 .../testing/selftests/kvm/include/kvm_util.h  |  18 +-
 .../selftests/kvm/include/x86_64/processor.h  |  11 +
 .../selftests/kvm/include/x86_64/vmx.h        |  10 +-
 .../selftests/kvm/kvm_page_table_test.c       |   2 +-
 .../selftests/kvm/lib/aarch64/processor.c     |  34 +--
 .../testing/selftests/kvm/lib/aarch64/ucall.c |   2 +-
 tools/testing/selftests/kvm/lib/elf.c         |   6 +-
 tools/testing/selftests/kvm/lib/kvm_util.c    |  62 ++++-
 .../selftests/kvm/lib/perf_test_util.c        |   2 +-
 .../selftests/kvm/lib/s390x/processor.c       |  17 +-
 .../selftests/kvm/lib/x86_64/processor.c      | 254 ++++++++----------
 tools/testing/selftests/kvm/lib/x86_64/svm.c  |   9 +-
 tools/testing/selftests/kvm/lib/x86_64/vmx.c  |  52 ++--
 .../testing/selftests/kvm/memslot_perf_test.c |   2 +-
 .../selftests/kvm/set_memory_region_test.c    |   2 +-
 tools/testing/selftests/kvm/steal_time.c      |   2 +-
 .../selftests/kvm/x86_64/get_cpuid_test.c     |   3 +-
 .../selftests/kvm/x86_64/hyperv_clock.c       |   2 +-
 .../selftests/kvm/x86_64/hyperv_features.c    |   8 +-
 .../selftests/kvm/x86_64/mmu_role_test.c      | 147 ++++++++++
 .../selftests/kvm/x86_64/set_boot_cpu_id.c    |   2 +-
 .../kvm/x86_64/vmx_apic_access_test.c         |   2 +-
 .../selftests/kvm/x86_64/vmx_dirty_log_test.c |   8 +-
 .../selftests/kvm/x86_64/xapic_ipi_test.c     |   4 +-
 .../selftests/kvm/x86_64/xen_shinfo_test.c    |   2 +-
 .../selftests/kvm/x86_64/xen_vmcall_test.c    |   2 +-
 30 files changed, 414 insertions(+), 260 deletions(-)
 create mode 100644 tools/testing/selftests/kvm/x86_64/mmu_role_test.c
Signature · 1 line
2.32.0.288.g62a8d224e6-goog