Skip to content

GuC submission support

Matthew Brost dri-devel intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest47 patches 118 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/47drm/i915/guc: Relax CTB response timeoutdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c+4 -21 reply
2/47drm/i915/guc: Improve error message for unsolicited CT responsedrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c+7 -31 reply
3/47drm/i915/guc: Increase size of CTB buffersdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c+8 -33 replies
4/47drm/i915/guc: Add non blocking CTB send functiondrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h+82 -107 replies
5/47drm/i915/guc: Add stall timer to non blocking CTB send functiondrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h+48 -32 replies
6/47drm/i915/guc: Optimize CTB writes and readsdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h+51 -313 replies
7/47drm/i915/guc: Module load failure test for CT buffer creationdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c+8 -00 replies
8/47drm/i915/guc: Add new GuC interface defines and structuresdrivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h+55 -02 replies
9/47drm/i915/guc: Remove GuC stage descriptor, add lrc descriptordrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+25 -1161 reply
10/47drm/i915/guc: Add lrc descriptor context lookup arraydrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+35 -23 replies
11/47drm/i915/guc: Implement GuC submission taskletdrivers/gpu/drm/i915/gt/intel_context_types.h drivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+127 -1172 replies
12/47drm/i915/guc: Add bypass tasklet submission path to GuCdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+29 -81 reply
13/47drm/i915/guc: Implement GuC context operations for new intefacedrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context_types.h drivers/gpu/drm/i915/gt/intel_lrc_reg.h +5 more+677 -552 replies
14/47drm/i915/guc: Insert fence on context when deregisteringdrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context_types.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 more+63 -21 reply
15/47drm/i915/guc: Defer context unpin until scheduling is disableddrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context.h drivers/gpu/drm/i915/gt/intel_context_types.h +3 more+179 -41 reply
16/47drm/i915/guc: Disable engine barriers with GuC during unpindrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context.h drivers/gpu/drm/i915/gt/selftest_context.c+12 -14 replies
17/47drm/i915/guc: Extend deregistration fence to schedule disabledrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+30 -73 replies
18/47drm/i915: Disable preempt busywait when using GuC schedulingdrivers/gpu/drm/i915/gt/gen8_engine_cs.c+4 -21 reply
19/47drm/i915/guc: Ensure request ordering via completion fencesdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c drivers/gpu/drm/i915/i915_request.c+13 -51 reply
20/47drm/i915/guc: Disable semaphores when using GuC schedulingdrivers/gpu/drm/i915/gem/i915_gem_context.c+4 -22 replies
21/47drm/i915/guc: Ensure G2H response has space in bufferdrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h +2 more+87 -233 replies
22/47drm/i915/guc: Update intel_gt_wait_for_idle to work with GuCdrivers/gpu/drm/i915/gem/i915_gem_mman.c drivers/gpu/drm/i915/gt/intel_gt.c drivers/gpu/drm/i915/gt/intel_gt.h +11 more+137 -273 replies
23/47drm/i915/guc: Update GuC debugfs to support new GuCdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h drivers/gpu/drm/i915/gt/uc/intel_guc_debugfs.c +3 more+104 -15 replies
24/47drm/i915/guc: Add several request trace pointsdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c drivers/gpu/drm/i915/i915_request.c drivers/gpu/drm/i915/i915_trace.h+43 -24 replies
25/47drm/i915: Add intel_context tracingdrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c drivers/gpu/drm/i915/i915_trace.h+166 -23 replies
26/47drm/i915/guc: GuC virtual enginesdrivers/gpu/drm/i915/gem/i915_gem_context.c drivers/gpu/drm/i915/gem/i915_gem_context.h drivers/gpu/drm/i915/gt/intel_context_types.h +7 more+429 -1321 reply
27/47drm/i915: Track 'serial' counts for virtual enginesdrivers/gpu/drm/i915/gt/intel_engine_types.h drivers/gpu/drm/i915/gt/intel_execlists_submission.c drivers/gpu/drm/i915/gt/intel_ring_submission.c +3 more+39 -12 replies
28/47drm/i915: Hold reference to intel_context over life of i915_requestdrivers/gpu/drm/i915/i915_request.c+22 -324 replies
29/47drm/i915/guc: Disable bonding extension with GuC submissiondrivers/gpu/drm/i915/gem/i915_gem_context.c+5 -01 reply
30/47drm/i915/guc: Direct all breadcrumbs for a class to single breadcrumbsdrivers/gpu/drm/i915/gt/intel_breadcrumbs.c drivers/gpu/drm/i915/gt/intel_breadcrumbs.h drivers/gpu/drm/i915/gt/intel_breadcrumbs_types.h +6 more+131 -361 reply
31/47drm/i915/guc: Reset implementation for new GuC interfacedrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context_types.h drivers/gpu/drm/i915/gt/intel_engine_types.h +12 more+649 -1716 replies
32/47drm/i915: Reset GPU immediately if submission is disableddrivers/gpu/drm/i915/gt/intel_engine_heartbeat.c drivers/gpu/drm/i915/gt/intel_engine_heartbeat.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +3 more+80 -131 reply
33/47drm/i915/guc: Add disable interrupts to guc sanitizedrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_uc.c+19 -181 reply
34/47drm/i915/guc: Suspend/resume implementation for new interfacedrivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h drivers/gpu/drm/i915/gt/uc/intel_guc.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +2 more+53 -511 reply
35/47drm/i915/guc: Handle context reset notificationdrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 more+50 -02 replies
36/47drm/i915/guc: Handle engine reset failure notificationdrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+48 -01 reply
37/47drm/i915/guc: Enable the timer expired interrupt for GuCdrivers/gpu/drm/i915/gt/intel_rps.c+4 -01 reply
38/47drm/i915/guc: Provide mmio list to be saved/restored on engine resetdrivers/gpu/drm/i915/gt/intel_workarounds.c drivers/gpu/drm/i915/gt/intel_workarounds_types.h drivers/gpu/drm/i915/gt/uc/intel_guc.h +2 more+222 -260 replies
39/47drm/i915/guc: Don't complain about reset racesdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_uc.c drivers/gpu/drm/i915/gt/uc/intel_uc.h+9 -11 reply
40/47drm/i915/guc: Enable GuC engine resetdrivers/gpu/drm/i915/gt/uc/intel_guc_ads.c+1 -21 reply
41/47drm/i915/guc: Capture error state on context resetdrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context.h drivers/gpu/drm/i915/gt/intel_engine.h +4 more+91 -261 reply
42/47drm/i915/guc: Fix for error capture after full GPU reset with GuCdrivers/gpu/drm/i915/gt/intel_engine.h drivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c +6 more+229 -471 reply
43/47drm/i915/guc: Hook GuC scheduling policies updrivers/gpu/drm/i915/gt/intel_engine_types.h drivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c +1 more+53 -53 replies
44/47drm/i915/guc: Connect reset modparam updates to GuC policy flagsdrivers/gpu/drm/i915/gt/uc/intel_guc_ads.c drivers/gpu/drm/i915/i915_debugfs_params.c+32 -11 reply
45/47drm/i915/guc: Include scheduling policies in the debugfs state dumpdrivers/gpu/drm/i915/gt/uc/intel_guc_ads.c drivers/gpu/drm/i915/gt/uc/intel_guc_ads.h drivers/gpu/drm/i915/gt/uc/intel_guc_debugfs.c+17 -01 reply
46/47drm/i915/guc: Add golden context to GuC ADSdrivers/gpu/drm/i915/gt/intel_gt.c drivers/gpu/drm/i915/gt/uc/intel_guc.c drivers/gpu/drm/i915/gt/uc/intel_guc.h +4 more+199 -300 replies
47/47drm/i915/guc: Unblock GuC submission on Gen11+drivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h +1 more+19 -719 replies

Reviews trailers per patch

31 of 47 patches have a Reviewed-by or Acked-by.

PatchMichal WajdeczkoMatthew BrostJohn Harrison
1/47R-b
2/47R-b
3/47R-b
4/47
5/47
6/47
7/47R-b
8/47R-b
9/47R-b
10/47R-b
11/47
12/47R-b
13/47
14/47R-b
15/47R-b
16/47R-b
17/47R-b
18/47R-b
19/47
20/47
21/47R-b
22/47
23/47
24/47R-b
25/47R-b
26/47
27/47
28/47R-b
29/47R-b
30/47
31/47
32/47R-b
33/47R-b
34/47R-b
35/47
36/47R-b
37/47R-b
38/47
39/47R-b
40/47R-b
41/47R-b
42/47R-b
43/47R-b
44/47R-b
45/47R-b
46/47
47/47R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/47] GuC submission support

As discussed in [1], [2] we are enabling GuC submission support in the i915. This is a subset of the patches in step 5 described in [1], basically it is absolute to enable CI with GuC submission on gen11+ platforms.

This series itself will likely be broken down into smaller patch sets to merge. Likely into CTBs changes, basic submission, virtual engines, and resets.

A following series will address the missing patches remaining from [1].

Locally tested on TGL machine and basic tests seem to be passing.

[1] https://patchwork.freedesktop.org/series/89844/
[2] https://patchwork.freedesktop.org/series/91417/

Daniele Ceraolo Spurio (1):
drm/i915/guc: Unblock GuC submission on Gen11+

John Harrison (10):
drm/i915/guc: Module load failure test for CT buffer creation drm/i915: Track 'serial' counts for virtual engines drm/i915/guc: Provide mmio list to be saved/restored on engine reset drm/i915/guc: Don't complain about reset races drm/i915/guc: Enable GuC engine reset
drm/i915/guc: Fix for error capture after full GPU reset with GuC drm/i915/guc: Hook GuC scheduling policies up drm/i915/guc: Connect reset modparam updates to GuC policy flags drm/i915/guc: Include scheduling policies in the debugfs state dump drm/i915/guc: Add golden context to GuC ADS

Matthew Brost (36):
drm/i915/guc: Relax CTB response timeout
drm/i915/guc: Improve error message for unsolicited CT response drm/i915/guc: Increase size of CTB buffers
drm/i915/guc: Add non blocking CTB send function drm/i915/guc: Add stall timer to non blocking CTB send function drm/i915/guc: Optimize CTB writes and reads
drm/i915/guc: Add new GuC interface defines and structures drm/i915/guc: Remove GuC stage descriptor, add lrc descriptor drm/i915/guc: Add lrc descriptor context lookup array drm/i915/guc: Implement GuC submission tasklet drm/i915/guc: Add bypass tasklet submission path to GuC drm/i915/guc: Implement GuC context operations for new inteface drm/i915/guc: Insert fence on context when deregistering drm/i915/guc: Defer context unpin until scheduling is disabled drm/i915/guc: Disable engine barriers with GuC during unpin drm/i915/guc: Extend deregistration fence to schedule disable drm/i915: Disable preempt busywait when using GuC scheduling drm/i915/guc: Ensure request ordering via completion fences drm/i915/guc: Disable semaphores when using GuC scheduling drm/i915/guc: Ensure G2H response has space in buffer drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC drm/i915/guc: Update GuC debugfs to support new GuC drm/i915/guc: Add several request trace points
drm/i915: Add intel_context tracing
drm/i915/guc: GuC virtual engines
drm/i915: Hold reference to intel_context over life of i915_request drm/i915/guc: Disable bonding extension with GuC submission drm/i915/guc: Direct all breadcrumbs for a class to single breadcrumbs drm/i915/guc: Reset implementation for new GuC interface drm/i915: Reset GPU immediately if submission is disabled drm/i915/guc: Add disable interrupts to guc sanitize drm/i915/guc: Suspend/resume implementation for new interface drm/i915/guc: Handle context reset notification drm/i915/guc: Handle engine reset failure notification drm/i915/guc: Enable the timer expired interrupt for GuC drm/i915/guc: Capture error state on context reset

 drivers/gpu/drm/i915/gem/i915_gem_context.c   |   30 +-
 drivers/gpu/drm/i915/gem/i915_gem_context.h   |    1 +
 drivers/gpu/drm/i915/gem/i915_gem_mman.c      |    3 +-
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c      |    6 +-
 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c   |   41 +-
 drivers/gpu/drm/i915/gt/intel_breadcrumbs.h   |   14 +-
 .../gpu/drm/i915/gt/intel_breadcrumbs_types.h |    7 +
 drivers/gpu/drm/i915/gt/intel_context.c       |   41 +-
 drivers/gpu/drm/i915/gt/intel_context.h       |   31 +-
 drivers/gpu/drm/i915/gt/intel_context_types.h |   49 +
 drivers/gpu/drm/i915/gt/intel_engine.h        |   72 +-
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  182 +-
 .../gpu/drm/i915/gt/intel_engine_heartbeat.c  |   71 +-
 .../gpu/drm/i915/gt/intel_engine_heartbeat.h  |    4 +
 drivers/gpu/drm/i915/gt/intel_engine_types.h  |   12 +-
 .../drm/i915/gt/intel_execlists_submission.c  |  234 +-
 .../drm/i915/gt/intel_execlists_submission.h  |   11 -
 drivers/gpu/drm/i915/gt/intel_gt.c            |   21 +
 drivers/gpu/drm/i915/gt/intel_gt.h            |    2 +
 drivers/gpu/drm/i915/gt/intel_gt_pm.c         |    6 +-
 drivers/gpu/drm/i915/gt/intel_gt_requests.c   |   22 +-
 drivers/gpu/drm/i915/gt/intel_gt_requests.h   |    9 +-
 drivers/gpu/drm/i915/gt/intel_lrc_reg.h       |    1 -
 drivers/gpu/drm/i915/gt/intel_reset.c         |   20 +-
 .../gpu/drm/i915/gt/intel_ring_submission.c   |   28 +
 drivers/gpu/drm/i915/gt/intel_rps.c           |    4 +
 drivers/gpu/drm/i915/gt/intel_workarounds.c   |   46 +-
 .../gpu/drm/i915/gt/intel_workarounds_types.h |    1 +
 drivers/gpu/drm/i915/gt/mock_engine.c         |   41 +-
 drivers/gpu/drm/i915/gt/selftest_context.c    |   10 +
 drivers/gpu/drm/i915/gt/selftest_execlists.c  |   20 +-
 .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |   15 +
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |   82 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |  106 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c    |  460 +++-
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.h    |    3 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c     |  318 ++-
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h     |   22 +-
 .../gpu/drm/i915/gt/uc/intel_guc_debugfs.c    |   25 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h   |   88 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 2197 +++++++++++++++--
 .../gpu/drm/i915/gt/uc/intel_guc_submission.h |   17 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         |  102 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc.h         |   11 +
 drivers/gpu/drm/i915/i915_debugfs.c           |    2 +
 drivers/gpu/drm/i915/i915_debugfs_params.c    |   31 +
 drivers/gpu/drm/i915/i915_gem_evict.c         |    1 +
 drivers/gpu/drm/i915/i915_gpu_error.c         |   25 +-
 drivers/gpu/drm/i915/i915_reg.h               |    2 +
 drivers/gpu/drm/i915/i915_request.c           |  159 +-
 drivers/gpu/drm/i915/i915_request.h           |   21 +
 drivers/gpu/drm/i915/i915_scheduler.c         |    6 +
 drivers/gpu/drm/i915/i915_scheduler.h         |    6 +
 drivers/gpu/drm/i915/i915_scheduler_types.h   |    5 +
 drivers/gpu/drm/i915/i915_trace.h             |  197 +-
 .../gpu/drm/i915/selftests/igt_live_test.c    |    2 +-
 .../gpu/drm/i915/selftests/mock_gem_device.c  |    3 +-
 57 files changed, 4159 insertions(+), 787 deletions(-)
Signature · 1 line
2.28.0