block/export: Conditionally ignore set-context error
Status from this message: Thanks, applied to the block branch.
Get series with b4
b4 am [email protected]Versions newest first
Changes in v2 from the cover letter
- Letting bdrv_try_set_aio_context() return an error and then just discarding it conditionally is kind of not right.
If we want to ignore the error, decide so from the start: Depending on fixed_iothread, pass either errp or NULL.
- Patch 2: Reference output has changed because of 30ebb9aa920.
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | block/export: Conditionally ignore set-context errorblock/ | +4 | 1 reply | |
| 2/2 | iotests/307: Test iothread conflict for exportstests/ tests/ | +23 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Vladimir Sementsov-Ogievskiy |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/2] block/export: Conditionally ignore set-context error
Hi,
I had this v2 lying around for quite some time but for some reason never sent it. I probably just forgot. Sorry.
v1:
https://lists.nongnu.org/archive/html/qemu-block/2021-04/msg00584.html
Changes in v2:
- Letting bdrv_try_set_aio_context() return an error and then just discarding it conditionally is kind of not right.
If we want to ignore the error, decide so from the start: Depending on fixed_iothread, pass either errp or NULL.
- Patch 2: Reference output has changed because of 30ebb9aa920.
git-backport-diff against v1:
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/2:[0009] [FC] 'block/export: Conditionally ignore set-context error' 002/2:[0002] [FC] 'iotests/307: Test iothread conflict for exports'
Max Reitz (2):
block/export: Conditionally ignore set-context error iotests/307: Test iothread conflict for exports
block/export/export.c | 5 ++++- tests/qemu-iotests/307 | 15 +++++++++++++++ tests/qemu-iotests/307.out | 8 ++++++++ 3 files changed, 27 insertions(+), 1 deletion(-)
Signature · 1 line
2.31.1