Skip to content

net: macsec: fix key length when offloading

Antoine Tenart netdev 1 version Applied

Status from this message: This series was applied to netdev/net.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesApplied 3/3

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3net: macsec: fix the length used to copy the key for offloadingdrivers/net/macsec.c include/net/macsec.h+3 -30 repliesApplied
2/3net: phy: mscc: fix macsec key lengthdrivers/net/phy/mscc/mscc_macsec.c drivers/net/phy/mscc/mscc_macsec.h+2 -20 repliesApplied
3/3net: atlantic: fix the macsec key lengthdrivers/net/ethernet/aquantia/atlantic/aq_macsec.h+2 -20 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 0/3] net: macsec: fix key length when offloading

Hello,

The key length used to copy the key to offloading drivers and to store it is wrong and was working by chance as it matched the default key length. But using a different key length fails. Fix it by using instead the max length accepted in uAPI to store the key and the actual key length when copying it.

This was tested on the MSCC PHY driver but not on the Atlantic MAC (looking at the code it looks ok, but testing would be appreciated).

Thanks,
Antoine

Antoine Tenart (3):
net: macsec: fix the length used to copy the key for offloading
net: phy: mscc: fix macsec key length
net: atlantic: fix the macsec key length

 drivers/net/ethernet/aquantia/atlantic/aq_macsec.h | 4 ++--
 drivers/net/macsec.c                               | 4 ++--
 drivers/net/phy/mscc/mscc_macsec.c                 | 2 +-
 drivers/net/phy/mscc/mscc_macsec.h                 | 2 +-
 include/net/macsec.h                               | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)
Signature · 1 line
2.31.1