Skip to content

s390x: Add snippet support

Janosch Frank kvm linux-s390 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesIn review
  2. v13 patches 5 repliesSuperseded

Changes in v2 from the cover letter

* Minor flat.lds fixes
* mvpg-sie.c include cleanup
* mvpg-sie.c added some comments
* mvpg-sie.c replace pei report calculations with variables src/dst

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3s390x: snippets: Add gitignore as well as linker script and start assembly.gitignore s390x/snippets/c/cstart.S s390x/snippets/c/flat.lds+68 -01 reply
2/3s390x: snippets: Add snippet compilations390x/Makefile+21 -60 replies
3/3s390x: mvpg: Add SIE mvpg tests390x/Makefile s390x/mvpg-sie.c s390x/snippets/c/mvpg-snippet.c +1 more+189 -04 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchThomas HuthJanosch Frank
1/3R-b
2/3A-b A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [kvm-unit-tests PATCH v2 0/3] s390x: Add snippet support

The SIE support allows us to run guests and test the hypervisor's (V)SIE implementation. However it requires that the guest instructions are binary which limits the complexity of the guest code.

The snippet support provides a way to write guest code as ASM or C and simply memcpy it into guest memory. Some of the KVM-unit-test library can be re-used which further speeds up guest code development.

The included mvpg-sie test helped us to deliver the KVM mvpg fixes which Claudio posted a short while ago. In the future I'll post Secure Execution snippet support patches which was my initial goal with this series anyway.

v2:
* Minor flat.lds fixes
* mvpg-sie.c include cleanup
* mvpg-sie.c added some comments
* mvpg-sie.c replace pei report calculations with variables src/dst

RFC -> V1:
* Replaced handle_validity() with assert()
* Added clearing of registers before sigp in cstart.S
* Added a nice way to compile the snippets

Janosch Frank (2):
s390x: snippets: Add gitignore as well as linker script and start
assembly
s390x: mvpg: Add SIE mvpg test

Steffen Eiden (1):
s390x: snippets: Add snippet compilation

 .gitignore                      |   1 +
 s390x/Makefile                  |  29 ++++--
 s390x/mvpg-sie.c                | 151 ++++++++++++++++++++++++++++++++
 s390x/snippets/c/cstart.S       |  16 ++++
 s390x/snippets/c/flat.lds       |  51 +++++++++++
 s390x/snippets/c/mvpg-snippet.c |  33 +++++++
 s390x/unittests.cfg             |   3 +
 7 files changed, 278 insertions(+), 6 deletions(-)
 create mode 100644 s390x/mvpg-sie.c
 create mode 100644 s390x/snippets/c/cstart.S
 create mode 100644 s390x/snippets/c/flat.lds
 create mode 100644 s390x/snippets/c/mvpg-snippet.c
Signature · 1 line
2.30.2