Skip to content

Python: packaging cleanups

John Snow qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest15 patches 11 repliesIn review
  2. v212 patches 8 repliesSuperseded
  3. v111 patches 32 repliesSuperseded

Changes in v3 from the cover letter

001/15:[down] 'python/qom: Do not use 'err' name at module scope' 010/15:[down] 'python: only check qemu/ subdir with flake8' 015/15:[down] 'python: Fix broken ReST docstrings'

- 01: Update library for pylint 2.9.0 which happened ~2hrs ago
- 10: Fix pylint checking stuff it shouldn't (Wainer)
- 15: Also new, it helps me along with Sphinx doc work.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15python/qom: Do not use 'err' name at module scopepython/qemu/qmp/qom.py+2 -22 replies
2/15python: expose typing information via PEP 561python/qemu/machine/py.typed python/qemu/qmp/py.typed python/qemu/utils/py.typed +1 more+4 -00 replies
3/15python: Remove global pylint suppressionspython/qemu/machine/machine.py python/qemu/machine/qtest.py python/setup.cfg+6 -30 replies
4/15python: Re-lock pipenv at *oldest* supported versionspython/Pipfile.lock python/setup.cfg+56 -610 replies
5/15python: README.rst touchupspython/README.rst+9 -80 replies
6/15python: Add no-install usage instructionspython/README.rst+28 -00 replies
7/15python: rename 'venv-check' target to 'check-pipenv'.gitlab-ci.d/static_checks.yml python/Makefile python/README.rst+13 -120 replies
8/15python: update help text for check-toxpython/Makefile+6 -20 replies
9/15python: Fix .PHONY Make specifierspython/Makefile+8 -20 replies
10/15python: only check qemu/ subdir with flake8python/setup.cfg python/tests/flake8.sh+1 -32 replies
11/15python: add 'make check-dev' invocationpython/Makefile+33 -25 replies
12/15python: Update help text on 'make check', 'make develop'python/Makefile+7 -30 replies
13/15python: Update help text on 'make clean', 'make distclean'python/Makefile+7 -40 replies
14/15python: remove auto-generated pyproject.toml filepython/Makefile+2 -00 replies
15/15python: Fix broken ReST docstringspython/qemu/machine/__init__.py python/qemu/machine/machine.py python/qemu/qmp/__init__.py +2 more+8 -62 replies

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchWillian RampazzoWainer dos Santos Moschetta
1/15R-b R-b
2/15R-b R-b
3/15R-b R-b
4/15R-b R-b
5/15R-b R-b
6/15R-b R-b
7/15R-b R-b
8/15R-b R-b
9/15R-b R-b
10/15R-b T-b R-b
11/15R-b A-b T-b R-b A-b
12/15R-b R-b
13/15R-b R-b
14/15R-b R-b
15/15R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/15] Python: packaging cleanups

This series is a collection of touchups and small fixes to the Python packaging series that was initiated with commit ea1213b7.

It fixes a small handful of annoyances and adjusts some readme files, help text, and so on.

I'd like to make sure this is included prior to the 6.1 RC testing period. (And now, at the very least, patch #01 needs to go in ASAP.)

V3:
001/15:[down] 'python/qom: Do not use 'err' name at module scope' 010/15:[down] 'python: only check qemu/ subdir with flake8' 015/15:[down] 'python: Fix broken ReST docstrings'

- 01: Update library for pylint 2.9.0 which happened ~2hrs ago
- 10: Fix pylint checking stuff it shouldn't (Wainer)
- 15: Also new, it helps me along with Sphinx doc work.

V2:
007/12:[0002] [FC] 'python: update help text for check-tox' 008/12:[down] 'python: Fix .PHONY Make specifiers' 009/12:[down] 'python: add 'make check-dev' invocation'

- 07: Changed '3.6-3.10' to '3.6 - 3.10'.
(Kept Willian's RB)
- 08: New, based on Wainer's observation I had missed 'check-tox'.
- 09: Renamed targets based on Wainer's review.

Status:

[01] python-qom-do-not-use-err-at  #              [SOB] JS
[02] python-expose-typing          # [RB] WR,WdSM [SOB] JS
[03] python-remove-global-pylint   # [RB] WR,WdSM [SOB] JS
[04] python-re-lock-pipenv-at      # [RB] WR,WdSM [SOB] JS
[05] python-readme.rst-touchups    # [RB] WR,WdSM [SOB] JS
[06] python-add-no-install-usage   # [RB] WR,WdSM [SOB] JS
[07] python-rename-venv-check      # [RB] WR,WdSM [SOB] JS
[08] python-update-help-text-for   # [RB] WR,WdSM [SOB] JS
[09] python-fix-.phony-make        # [RB] WR,WdSM [SOB] JS
[10] python-only-check-qemu-subdir #              [SOB] JS
[11] python-add-make-check-venv    #              [SOB] JS
[12] python-update-help-text-on    # [RB] WR,WdSM [SOB] JS
[13] python-update-help-text-on-1  # [RB] WR,WdSM [SOB] JS
[14] python-remove-auto-generated  # [RB] WR,WdSM [SOB] JS
[15] python-fix-broken-rest        #              [SOB] JS

John Snow (15):
python/qom: Do not use 'err' name at module scope
python: expose typing information via PEP 561
python: Remove global pylint suppressions
python: Re-lock pipenv at *oldest* supported versions
python: README.rst touchups
python: Add no-install usage instructions
python: rename 'venv-check' target to 'check-pipenv'
python: update help text for check-tox
python: Fix .PHONY Make specifiers
python: only check qemu/ subdir with flake8
python: add 'make check-dev' invocation
python: Update help text on 'make check', 'make develop'
python: Update help text on 'make clean', 'make distclean'
python: remove auto-generated pyproject.toml file
python: Fix broken ReST docstrings

 python/README.rst               |  47 ++++++++++---
 .gitlab-ci.d/static_checks.yml  |   2 +-
 python/Makefile                 |  89 +++++++++++++++++++------
 python/Pipfile.lock             | 113 +++++++++++++++-----------------
 python/qemu/machine/__init__.py |   6 +-
 python/qemu/machine/machine.py  |   6 +-
 python/qemu/machine/py.typed    |   0
 python/qemu/machine/qtest.py    |   2 +
 python/qemu/qmp/__init__.py     |   1 +
 python/qemu/qmp/py.typed        |   0
 python/qemu/qmp/qom.py          |   4 +-
 python/qemu/qmp/qom_common.py   |   2 +-
 python/qemu/utils/accel.py      |   2 +-
 python/qemu/utils/py.typed      |   0
 python/setup.cfg                |  14 ++--
 python/tests/flake8.sh          |   2 +-
 16 files changed, 186 insertions(+), 104 deletions(-)
 create mode 100644 python/qemu/machine/py.typed
 create mode 100644 python/qemu/qmp/py.typed
 create mode 100644 python/qemu/utils/py.typed
Signature · 1 line
2.31.1