Skip to content

Allow deferred execution of iomem_get_mapping()

Krzysztof Wilczyński linux-pci 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 6 repliesIn review
  2. v23 patches 0 repliesSuperseded
  3. v12 patches 11 repliesSuperseded

Changes in v3 from the cover letter

Squashed first two patches from v2 into a single patch to resolve compile time issues.
Carried over Dan Williams' review from v2 as there are no code or functional changes.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2sysfs: Invoke iomem_get_mapping() from the sysfs open callbackdrivers/pci/pci-sysfs.c fs/sysfs/file.c include/linux/sysfs.h+5 -51 reply
2/2sysfs: Rename struct bin_attribute member to f_mappingdrivers/pci/pci-sysfs.c fs/sysfs/file.c include/linux/sysfs.h+6 -61 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDan WilliamsBjorn Helgaas
1/2R-b A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Allow deferred execution of iomem_get_mapping()

Hello,

At the moment, the dependency on iomem_get_mapping() that is currently used in the pci_create_resource_files() and pci_create_legacy_files() stops us from completely retiring the late_initcall() that is used to invoke pci_sysfs_init() when creating sysfs object for PCI devices.

This dependency on iomem_get_mapping() stops us from retiring the late_initcall at the moment as when we convert dynamically added sysfs objects, that are primarily added in the pci_create_resource_files() and pci_create_legacy_files(), as these attributes are added before the VFS completes its initialisation, and since most of the PCI devices are typically enumerated in subsys_initcall this leads to a failure and an Oops related to iomem_get_mapping() access.

See relevant conversations:
https://lore.kernel.org/linux-pci/[email protected]/
https://lore.kernel.org/linux-pci/20210313215747.GA2394467@bjorn-Precision-5520/

After some deliberation about the problem at hand, Dan Williams suggested a solution to the problem, as per:
https://lore.kernel.org/linux-pci/CAPcyv4i0y_4cMGEpNVShLUyUk3nyWH203Ry3S87BqnDJE0Rmxg@mail.gmail.com/

The idea is to defer execution of the iomem_get_mapping() to only when the sysfs open callback is run, and thus removing the reliance of fs_initcalls to complete before any other sub-system that uses the iomem_get_mapping().

Currently, the PCI sub-system will benefit the most from this change allowing for it to complete the transition from dynamically created to static sysfs objects.

This series aims to take Dan Williams' idea through the finish line.

Related to:
https://lore.kernel.org/linux-pci/20210527205845.GA1421476@bjorn-Precision-5520/
https://lore.kernel.org/linux-pci/[email protected]/
https://lore.kernel.org/linux-pci/20200716110423.xtfyb3n6tn5ixedh@pali/

Krzysztof

---
Changes in v3:
Squashed first two patches from v2 into a single patch to resolve compile time issues.
Carried over Dan Williams' review from v2 as there are no code or functional changes.

Changes in v2:
Added "Signed-off-by" and "Reviewed-by" from Dan Williams as per his feedback.
Added third patch that renames struct bin_attribute member "mapping" to "f_mapping" to keep the naming consistent with struct file. N.B. this patch can definitely be dropped as the rename is not required for anything else to work.

Krzysztof Wilczyński (2):
sysfs: Invoke iomem_get_mapping() from the sysfs open callback
sysfs: Rename struct bin_attribute member to f_mapping

 drivers/pci/pci-sysfs.c | 6 +++---
 fs/sysfs/file.c         | 4 ++--
 include/linux/sysfs.h   | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)
Signature · 1 line
2.32.0