Skip to content

btrfs: allow BTRFS_IOC_SNAP_DESTROY_V2 to remove ghost subvolume

Qu Wenruo linux-btrfs oe-kbuild oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: return -EINVAL if some user wants to remove uuid/data_reloc treefs/btrfs/ioctl.c+2 -11 reply
2/3btrfs: remove dead comment on btrfs_add_dead_root()fs/btrfs/transaction.c+4 -31 reply
3/3btrfs: allow BTRFS_IOC_SNAP_DESTROY_V2 to remove ghost subvolumefs/btrfs/ioctl.c+78 -04 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchAnand Jain
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] btrfs: allow BTRFS_IOC_SNAP_DESTROY_V2 to remove ghost subvolume

Since we're busting ghost subvolumes, the branch is now called ghost_busters:
https://github.com/adam900710/linux/tree/ghost_busters

The first two patches are just cleanup found during the development.

The first is a missing check for subvolid range, the missing check itself won't cause any harm, just returning -ENOENT from dentry lookup, other than the expected -EINVAL.

The 2nd is a super old dead comment from the early age of btrfs.

The final patch is the real work to allow patched "btrfs subvolume delete -i" to delete ghost subvolume.
Tested with the image dump of previous submitted btrfs-progs patchset.

Qu Wenruo (3):
btrfs: return -EINVAL if some user wants to remove uuid/data_reloc
tree
btrfs: remove dead comment on btrfs_add_dead_root()
btrfs: allow BTRFS_IOC_SNAP_DESTROY_V2 to remove ghost subvolume

 fs/btrfs/ioctl.c       | 81 +++++++++++++++++++++++++++++++++++++++++-
 fs/btrfs/transaction.c |  7 ++--
 2 files changed, 84 insertions(+), 4 deletions(-)
Signature · 1 line
2.32.0