Skip to content

Add support for ECDSA-signed kernel modules

Stefan Berger keyrings linux-integrity linux-security-module lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest2 patches 3 repliesIn review
  2. v72 patches 1 replySuperseded

Changes in v8 from the cover letter

- Removed R-b tags and reordered Cc tags

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2certs: Trigger creation of RSA module signing key if it's not an RSA keycerts/Makefile+8 -02 replies
2/2certs: Add support for using elliptic curve keys for signing modulescerts/Kconfig certs/Makefile crypto/asymmetric_keys/pkcs7_parser.c+47 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJarkko Sakkinen
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/2] Add support for ECDSA-signed kernel modules

From: Stefan Berger <[email protected]>

This series adds support for ECDSA-signed kernel modules. It also attempts to address a kbuild issue where a developer created an ECDSA key for signing kernel modules and then builds an older version of the kernel, when bisecting the kernel for example, that does not support ECDSA keys.

The first patch addresses the kbuild issue of needing to delete that ECDSA key if it is in certs/signing_key.pem and trigger the creation of an RSA key. However, for this to work this patch would have to be backported to previous versions of the kernel but would also only work for the developer if he/she used a stable version of the kernel to which this patch was applied. So whether this patch actually achieves the wanted effect is not always guaranteed.

The 2nd patch adds the support for the ECSDA-signed kernel modules.

Stefan

v8:
- Removed R-b tags and reordered Cc tags

v7:
- Changed Kconfig reference to kernel version from 5.11 to 5.13
- Redirecting stderr of openssl to NULL device to address kernel robot detected issue
- Replaced $(CONFIG_MODULE_SIG_KEY) with "certs/signing_key.pem" following Linus's suggestion

v6:
- Patch 2/4 is fixing V4's 1/2 and 4/4 is fixing V4's 2/2. Both fixup patches to be squashed.

v5:
- do not touch the key files if openssl is not installed; likely addresses an issue pointed out by kernel test robot

v4:
- extending 'depends on' with MODULES to (IMA_APPRAISE_MODSIG && MODULES)

v3:
- added missing OIDs for ECDSA signed hashes to pkcs7_sig_note_pkey_algo
- added recommendation to use string hash to Kconfig help text

v2:
- Adjustment to ECDSA key detector string in 2/2
- Rephrased cover letter and patch descriptions with Mimi

Stefan Berger (2):
certs: Trigger creation of RSA module signing key if it's not an RSA
key
certs: Add support for using elliptic curve keys for signing modules

 certs/Kconfig                         | 26 ++++++++++++++++++++++++++
 certs/Makefile                        | 21 +++++++++++++++++++++
 crypto/asymmetric_keys/pkcs7_parser.c |  8 ++++++++
 3 files changed, 55 insertions(+)
Signature · 1 line
2.31.1