powerpc: fast interrupt exit bug and misc fixes
Status from this message: Applied to powerpc/next.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest9 patches 3 repliesApplied
- v29 patches 0 repliesSuperseded
- v11 patch 1 replySuperseded
Changes in v3 from the cover letter
- Fixed 64e patch 3 to really set exit_must_hard_disable.
- Reworded some changelogs.
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | powerpc/64s: fix hash page fault interrupt handlerarch/ | +11 | 0 replies | |
| 2/9 | powerpc/64e: fix CONFIG_RELOCATABLE build warningsarch/ | +11 | 0 replies | |
| 3/9 | powerpc/64e: remove implicit soft-masking and interrupt exit restart logicarch/ arch/ arch/ +1 more | +40 | 2 replies | |
| 4/9 | powerpc/64s: add a table of implicit soft-masked addressesarch/ arch/ arch/ +3 more | +106 | 0 replies | |
| 5/9 | powerpc/64s/interrupt: preserve regs->softe for NMI interruptsarch/ | +3 | 0 replies | |
| 6/9 | powerpc/64: enable MSR[EE] in irq replay pt_regsarch/ arch/ | +5 | 0 replies | |
| 7/9 | powerpc/64/interrupt: add missing kprobe annotations on interrupt exit symbolsarch/ | +6 | 0 replies | |
| 8/9 | powerpc/64s/interrupt: clean up interrupt return labelsarch/ | +5 | 0 replies | |
| 9/9 | powerpc/64s: move ret_from_fork etc above __end_soft_maskedarch/ | +26 | 0 replies |
Reviews trailers per patch
None of the 9 patches has a Reviewed-by or Acked-by.
| Patch | Sachin Sant |
|---|---|
| 1/9 | T-b |
| 2/9 | |
| 3/9 | |
| 4/9 | T-b |
| 5/9 | |
| 6/9 | |
| 7/9 | |
| 8/9 | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/9] powerpc: fast interrupt exit bug and misc fixes
This is a bunch of fixes for powerpc next, mostly a nasty hole in fast interrupt exit code found by Sachin and some other bits along the way while looking at it.
Since v2:
- Fixed 64e patch 3 to really set exit_must_hard_disable.
- Reworded some changelogs.
Since v1:
- Fixed a bisection compile error due to a fix incorrectly going to a later patch.
- Fixed the "add a table of implicit soft-masked addresses" patch to include the low scv vector range as a soft-masked table entry. scv was the original reason for implicit soft masking, and the previous version breaks it. My stress testing was using an image without scv glibc unfortunately.
- Fixed a bug with the same patch that would restore r12 with SRR1 rather than HSRR1 in the case of masked hypervisor interrupts after searching the soft-mask table. Again unfortunately my stress testing was in a guest so no HV interrupts.
Thanks to Michael for noticing these issues.
- Pulled in the hash page fault interrupt handler fix into this series to make the dependencies clear (well it's not exactly dependent but assertions introduced later make the existing bug crash more often).
Thanks,
Nick
Nicholas Piggin (9):
powerpc/64s: fix hash page fault interrupt handler powerpc/64e: fix CONFIG_RELOCATABLE build warnings powerpc/64e: remove implicit soft-masking and interrupt exit restart
logic
powerpc/64s: add a table of implicit soft-masked addresses powerpc/64s/interrupt: preserve regs->softe for NMI interrupts powerpc/64: enable MSR[EE] in irq replay pt_regs powerpc/64/interrupt: add missing kprobe annotations on interrupt exit
symbols
powerpc/64s/interrupt: clean up interrupt return labels powerpc/64s: move ret_from_fork etc above __end_soft_masked
arch/powerpc/include/asm/interrupt.h | 41 +++++++++--- arch/powerpc/include/asm/ppc_asm.h | 7 +++ arch/powerpc/kernel/exceptions-64e.S | 23 +++---- arch/powerpc/kernel/exceptions-64s.S | 64 ++++++++++++++++--- arch/powerpc/kernel/interrupt.c | 2 +- arch/powerpc/kernel/interrupt_64.S | 90 ++++++++++++++++++--------- arch/powerpc/kernel/irq.c | 1 + arch/powerpc/kernel/vmlinux.lds.S | 9 +++ arch/powerpc/lib/restart_table.c | 26 ++++++++ arch/powerpc/mm/book3s64/hash_utils.c | 24 ++++--- 10 files changed, 212 insertions(+), 75 deletions(-)
Signature · 1 line
2.23.0