Skip to content

Bugfixes for send queue overflow by heartbeat

Jack Wang linux-rdma 2 versions – Applied

Status from this message: Applied to for-next, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 3 repliesApplied
  2. v16 patches 0 repliesSuperseded

Changes in v2 from the cover letter

* rebased to latest v5.14-rc1, target rc instread of for-next.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6RDMA/rtrs: Add error messages for failed operations.drivers/infiniband/ulp/rtrs/rtrs.c+3 -00 replies
2/6RDMA/rtrs: move wr_cnt from rtrs_srv_con to rtrs_condrivers/infiniband/ulp/rtrs/rtrs-clt.c drivers/infiniband/ulp/rtrs/rtrs-clt.h drivers/infiniband/ulp/rtrs/rtrs-pri.h +2 more+8 -80 replies
3/6RDMA/rtrs: Enable the same selective signal for heartbeat and IOdrivers/infiniband/ulp/rtrs/rtrs-clt.c drivers/infiniband/ulp/rtrs/rtrs-pri.h drivers/infiniband/ulp/rtrs/rtrs-srv.c +1 more+18 -80 replies
4/6RDMA/rtrs: Make rtrs_post_rdma_write_imm_empty staticdrivers/infiniband/ulp/rtrs/rtrs-pri.h drivers/infiniband/ulp/rtrs/rtrs.c+5 -70 replies
5/6RDMA/rtrs: Remove unused flags parameterdrivers/infiniband/ulp/rtrs/rtrs.c+2 -30 replies
6/6RDMA/rtrs: Move sq_wr_avail to rtrs_condrivers/infiniband/ulp/rtrs/rtrs-clt.c drivers/infiniband/ulp/rtrs/rtrs-pri.h drivers/infiniband/ulp/rtrs/rtrs-srv.c +2 more+7 -50 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchAleksei MarovGioh KimMd Haris Iqbal
1/6R-b R-b R-b
2/6R-b R-b R-b
3/6R-b R-b R-b
4/6R-b R-b R-b
5/6R-b R-b R-b
6/6R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCHv2 for-rc 0/6] Bugfixes for send queue overflow by heartbeat

Hi Jason, hi Doug,

Please consider to include following changes to upstream.

This patchset fix a regression since b38041d50add ("RDMA/rtrs: Do not signal for heatbeat").

In commit b38041d50add, the signal flag is droped to fix the send queue full logic, but introduced a worse bug the send queue overflow on both clt and srv by heartbeat, sorry.

The patchset is orgnized as:
- patch1 debug patch.
- patch2 preparation.
- patch3 signal both IO and heartbeat.
- patch4 cleanup.
- patch5 cleanup
- patch6 move sq_wr_avail to account send queue full correctly.

The patches are created base v5.14-rc1.

Since v1:
* rebased to latest v5.14-rc1, target rc instread of for-next.

v1: https://lore.kernel.org/linux-rdma/[email protected]/T/#t

Jack Wang (6):
RDMA/rtrs: Add error messages for failed operations. RDMA/rtrs: move wr_cnt from rtrs_srv_con to rtrs_con RDMA/rtrs: Enable the same selective signal for heartbeat and IO RDMA/rtrs: Make rtrs_post_rdma_write_imm_empty static RDMA/rtrs: Remove unused flags parameter
RDMA/rtrs: Move sq_wr_avail to rtrs_con

 drivers/infiniband/ulp/rtrs/rtrs-clt.c | 11 ++++++++---
 drivers/infiniband/ulp/rtrs/rtrs-clt.h |  1 -
 drivers/infiniband/ulp/rtrs/rtrs-pri.h |  6 +++---
 drivers/infiniband/ulp/rtrs/rtrs-srv.c | 19 ++++++++++---------
 drivers/infiniband/ulp/rtrs/rtrs-srv.h |  2 --
 drivers/infiniband/ulp/rtrs/rtrs.c     | 23 ++++++++++++++++-------
 6 files changed, 37 insertions(+), 25 deletions(-)
Signature · 1 line
2.25.1