Skip to content

drm/vc4: hdmi: Fix CEC access while disabled

Maxime Ripard dri-devel lkml openrisc 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 8 repliesApplied
  2. v25 patches 2 repliesSuperseded
  3. v14 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Rebased on top of drm-misc-fixes
- Fixed a build error

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/6drm/vc4: select PMdrivers/gpu/drm/vc4/Kconfig drivers/gpu/drm/vc4/vc4_hdmi.c+1 -27 replies
2/6drm/vc4: hdmi: Make sure the controller is powered up during binddrivers/gpu/drm/vc4/vc4_hdmi.c+15 -20 replies
3/6drm/vc4: hdmi: Rework the pre_crtc_configure error handlingdrivers/gpu/drm/vc4/vc4_hdmi.c+14 -70 replies
4/6drm/vc4: hdmi: Split the CEC disable / enable functions in twodrivers/gpu/drm/vc4/vc4_hdmi.c+44 -290 replies
5/6drm/vc4: hdmi: Make sure the device is powered with CECdrivers/gpu/drm/vc4/vc4_hdmi.c+9 -10 replies
6/6drm/vc4: hdmi: Warn if we access the controller while disableddrivers/gpu/drm/vc4/vc4_hdmi_regs.h+6 -00 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchDave Stevenson
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] drm/vc4: hdmi: Fix CEC access while disabled

Hi,

This series aims at fixing a complete and silent hang when one tries to use CEC while the display output is off.

This can be tested with:

echo off > /sys/class/drm/card0-HDMI-A-1/status
cec-ctl --tuner -p 1.0.0.0
cec-compliance

This series addresses it by making sure the HDMI controller is powered up as soon as the CEC device is opened by the userspace.

Let me know what you think,
Maxime

Changes from v2:
- Rebased on top of drm-misc-fixes
- Fixed a build error

Changes from v1:
- More fixes
- Added a big warning if we try to access a register while the device is disabled.
- Fixed the pre_crtc_configure error path

Maxime Ripard (6):
drm/vc4: select PM
drm/vc4: hdmi: Make sure the controller is powered up during bind drm/vc4: hdmi: Rework the pre_crtc_configure error handling drm/vc4: hdmi: Split the CEC disable / enable functions in two drm/vc4: hdmi: Make sure the device is powered with CEC drm/vc4: hdmi: Warn if we access the controller while disabled

 drivers/gpu/drm/vc4/Kconfig         |   1 +
 drivers/gpu/drm/vc4/vc4_hdmi.c      | 125 ++++++++++++++++++----------
 drivers/gpu/drm/vc4/vc4_hdmi_regs.h |   6 ++
 3 files changed, 90 insertions(+), 42 deletions(-)
Signature · 1 line
2.31.1