Skip to content

ICRC cleanup

Bob Pearson linux-rdma 2 versions – Applied

Status from this message: Applied to for-next, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 14 repliesApplied
  2. v15 patches 0 repliesSuperseded

Changes in v2 from the cover letter

Split up the 5 patches in the first version into 9 patches which are each focused on a single change.
Fixed sparse warnings in the first version.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/9RDMA/rxe: Move ICRC checking to a subroutinedrivers/infiniband/sw/rxe/rxe_icrc.c drivers/infiniband/sw/rxe/rxe_loc.h drivers/infiniband/sw/rxe/rxe_recv.c+42 -212 replies
2/9RDMA/rxe: Move rxe_xmit_packet to a subroutinedrivers/infiniband/sw/rxe/rxe_loc.h drivers/infiniband/sw/rxe/rxe_net.c+45 -431 reply
3/9RDMA/rxe: Fixup rxe_send and rxe_loopbackdrivers/infiniband/sw/rxe/rxe_loc.h drivers/infiniband/sw/rxe/rxe_net.c+14 -160 replies
4/9RDMA/rxe: Move ICRC generation to a subroutinedrivers/infiniband/sw/rxe/rxe_comp.c drivers/infiniband/sw/rxe/rxe_icrc.c drivers/infiniband/sw/rxe/rxe_loc.h +4 more+37 -644 replies
5/9RDMA/rxe: Move rxe_crc32 to a subroutinedrivers/infiniband/sw/rxe/rxe.h drivers/infiniband/sw/rxe/rxe_icrc.c+21 -210 replies
6/9RDMA/rxe: Fixup rxe_icrc_hdrdrivers/infiniband/sw/rxe/rxe_icrc.c drivers/infiniband/sw/rxe/rxe_loc.h+3 -40 replies
7/9RDMA/rxe: Move crc32 init code to rxe_icrc.cdrivers/infiniband/sw/rxe/rxe.h drivers/infiniband/sw/rxe/rxe_icrc.c drivers/infiniband/sw/rxe/rxe_loc.h +1 more+22 -90 replies
8/9RDMA/rxe: Add kernel-doc comments to rxe_icrc.cdrivers/infiniband/sw/rxe/rxe_icrc.c+29 -30 replies
9/9RDMA/rxe: Fix types in rxe_icrc.cdrivers/infiniband/sw/rxe/rxe_icrc.c+14 -141 reply

Reviews trailers per patch

2 of 9 patches have a Reviewed-by or Acked-by.

PatchZhu Yanjun
1/9R-b
2/9R-b
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH for-next v2 0/9] ICRC cleanup

This series of patches is a cleanup of the ICRC code in the rxe driver. The end result is to collect all the ICRC focused code into rxe_icrc.c with three APIs that are used by the rest of the driver. One to initialize the crypto engine used to compute crc32, and one each to generate and check the ICRC in a packet.

---
v2:
Split up the 5 patches in the first version into 9 patches which are each focused on a single change.
Fixed sparse warnings in the first version.

Bob Pearson (9):
RDMA/rxe: Move ICRC checking to a subroutine
RDMA/rxe: Move rxe_xmit_packet to a subroutine
RDMA/rxe: Fixup rxe_send and rxe_loopback
RDMA/rxe: Move ICRC generation to a subroutine
RDMA/rxe: Move rxe_crc32 to a subroutine
RDMA/rxe: Fixup rxe_icrc_hdr
RDMA/rxe: Move crc32 init code to rxe_icrc.c
RDMA/rxe: Add kernel-doc comments to rxe_icrc.c
RDMA/rxe: Fix types in rxe_icrc.c

 drivers/infiniband/sw/rxe/rxe.h       |  22 -----
 drivers/infiniband/sw/rxe/rxe_comp.c  |   4 +-
 drivers/infiniband/sw/rxe/rxe_icrc.c  | 124 +++++++++++++++++++++++++-
 drivers/infiniband/sw/rxe/rxe_loc.h   |  61 +++----------
 drivers/infiniband/sw/rxe/rxe_mr.c    |  22 +----
 drivers/infiniband/sw/rxe/rxe_net.c   |  59 ++++++++++--
 drivers/infiniband/sw/rxe/rxe_recv.c  |  23 +----
 drivers/infiniband/sw/rxe/rxe_req.c   |  13 +--
 drivers/infiniband/sw/rxe/rxe_resp.c  |  33 ++-----
 drivers/infiniband/sw/rxe/rxe_verbs.c |  11 +--
 10 files changed, 202 insertions(+), 170 deletions(-)
Signature · 1 line
2.30.2