Skip to content

Kbuild: lto: add make version checking for MODVERSIONS

Lecopzer Chen linux-kbuild lkml 4 versions – NAK

Status from this message: NACK.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 8 repliesNAK
  2. v2 posting 2/22 patches 2 repliesSuperseded
  3. v2 posting 1/22 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches4 repliesSuperseded

Changes in v3 from the cover letter

- fix comment in make-version.sh

Patches in v3

#Subject and filesSizeRepliesApplied
1/2Kbuild: lto: add CONFIG_MAKE_VERSIONMakefile init/Kconfig scripts/make-version.sh+18 -16 replies
2/2Kbuild: lto: add make version checkingarch/Kconfig+1 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNathan ChancellorLecopzer Chen
1/2R-b T-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Kbuild: lto: add make version checking for MODVERSIONS

LTO with MODVERSIONS will fail in generating correct CRC because the makefile rule doesn't work for make with version 3.8X.

Refer to [1]:

Quoted 13 lines

When building modules(CONFIG_...=m), I found some of module versions are incorrect and set to 0.
This can be found in build log for first clean build which shows

WARNING: EXPORT symbol "XXXX" [drivers/XXX/XXX.ko] version generation failed, symbol will not be versioned.

But in second build(incremental build), the WARNING disappeared and the module version becomes valid CRC and make someone who want to change modules without updating kernel image can't insert their modules.

The problematic code is
+ $(foreach n, $(filter-out FORCE,$^), \

Review

Quoted 2 lines
(quoted diff) +2 -0
+   $(if $(wildcard $(n).symversions),      \
+     ; cat $(n).symversions >> [email protected]))

The issue is fixed when make version upgrading to 4.2.

Thus we need to check make version during selecting on LTO Kconfig. Add CONFIG_MAKE_VERSION which means MAKE_VERSION in canonical digits for arithmetic comparisons.

[1] https://lore.kernel.org/lkml/[email protected]/

----
v3:
- fix comment in make-version.sh

v2:
https://lore.kernel.org/lkml/[email protected]/
- change MAKE_VERSION_INT to MAKE_VERSION
- remove $(make-version)
- tweak commit message

v1:
https://lore.kernel.org/lkml/[email protected]/
----

Lecopzer Chen (2):
Kbuild: lto: add CONFIG_MAKE_VERSION
Kbuild: lto: add make version checking

 Makefile                |  2 +-
 arch/Kconfig            |  1 +
 init/Kconfig            |  4 ++++
 scripts/make-version.sh | 13 +++++++++++++
 4 files changed, 19 insertions(+), 1 deletion(-)
 create mode 100755 scripts/make-version.sh
Signature · 1 line
2.18.0