Skip to content

kasan: solve redzone overwritten issue at debug

[email protected] linux-arm-kernel linux-mediatek linux-mm lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest2 patches 6 repliesIn review
  2. v52 patches 2 repliesSuperseded
  3. v42 patches 2 repliesSuperseded

Changes in v6 from the cover letter

- Fix format

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mm: move helper to check slub_debug_enabledmm/slab.h mm/slub.c+11 -180 replies
2/2kasan: Add memzero int for unaligned size at DEBUGmm/kasan/kasan.h+12 -06 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchMarco ElverAndrey Konovalov
1/2
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/2] kasan: solve redzone overwritten issue at debug

From: Yee Lee <[email protected]>

Issue: In SLUB debug, hwtag kasan_unpoison() would overwrite the redzone in those objects with unaligned size.

The first patch Introduces slub_debug_enable_unlikely() to check the state of debug mode.

The second patch Adds memzero_explict() to separate the initialization for such condition. The new code path is executed about 1.1% during nromal booting process. The penalty is acceptable since it only works in debug mode.

=============
Exp: QEMUv5.2(+mte)/SLUB_debug mode
code path exec : 941/80854 (1.1%)

Changed since v6:
- Move helper instead of introducing a new one.

Changed since v5:
- Fix format

Changed since v4:
- Introduce slub_debug_enable_unlikly() to check the debug state.
- Include "slab.h" and Add slub_debug_enable_unlikly() to lead the condition statement.
- Add comment block about this new code path in source code.

Changed since v3:
- Apply IS_ENABLED to wrap codes under SLUB debug mode.
- Replace memset() by memzero_explict().

---

Marco Elver (1):
mm: move helper to check slub_debug_enabled

Yee Lee (1):
kasan: Add memzero int for unaligned size at DEBUG

 mm/kasan/kasan.h | 12 ++++++++++++
 mm/slab.h        | 15 +++++++++++----
 mm/slub.c        | 14 --------------
 3 files changed, 23 insertions(+), 18 deletions(-)
Signature · 1 line
2.18.0