Skip to content

vkms: Switch to shadow-buffered plane state

Thomas Zimmermann dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/gem: Export implementation of shadow-plane helpersdrivers/gpu/drm/drm_gem_atomic_helper.c include/drm/drm_gem_atomic_helper.h+58 -30 replies
2/4drm/vkms: Inherit plane state from struct drm_shadow_plane_statedrivers/gpu/drm/vkms/vkms_composer.c drivers/gpu/drm/vkms/vkms_drv.h drivers/gpu/drm/vkms/vkms_plane.c+12 -110 replies
3/4drm/vkms: Let shadow-plane helpers prepare the plane's FBdrivers/gpu/drm/vkms/vkms_plane.c+1 -370 replies
4/4drm/vkms: Use dma-buf mapping from shadow-plane state for composingdrivers/gpu/drm/vkms/vkms_composer.c drivers/gpu/drm/vkms/vkms_drv.h drivers/gpu/drm/vkms/vkms_plane.c+15 -130 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMelissa WenSumera Priyadarsini
SeriesR-b T-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] vkms: Switch to shadow-buffered plane state

Vkms copies each plane's framebuffer into the output buffer; essentially using a shadow buffer. DRM provides struct drm_shadow_plane_state, which handles the details of mapping/unmapping shadow buffers into memory for active planes.

Convert vkms to the helpers. Makes vkms use shared code and gives more test exposure to shadow-plane helpers.

Thomas Zimmermann (4):
drm/gem: Export implementation of shadow-plane helpers drm/vkms: Inherit plane state from struct drm_shadow_plane_state drm/vkms: Let shadow-plane helpers prepare the plane's FB drm/vkms: Use dma-buf mapping from shadow-plane state for composing

 drivers/gpu/drm/drm_gem_atomic_helper.c | 55 ++++++++++++++++++++++--
 drivers/gpu/drm/vkms/vkms_composer.c    | 26 ++++++-----
 drivers/gpu/drm/vkms/vkms_drv.h         |  6 ++-
 drivers/gpu/drm/vkms/vkms_plane.c       | 57 ++++++-------------------
 include/drm/drm_gem_atomic_helper.h     |  6 +++
 5 files changed, 86 insertions(+), 64 deletions(-)

base-commit: 3d3b5479895dd6dd133571ded4318adf595708ba --
2.32.0