Skip to content

loop: cleanup charging io to mem/blkcg

Ming Lei cgroups linux-block lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 6 repliesIn review
  2. v37 patches 0 repliesSuperseded
  3. v27 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v16 patches15 repliesSuperseded

Changes in v4 from the cover letter

- fix build failure in case of !CONFIG_CGROUPS: changed to use 'struct cgroup_subsys_state' as parameter of the added memcg helper; meantime add helper loop_blkcg_css_id()

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7mm: memcontrol: add helper of memcg_get_e_cssinclude/linux/memcontrol.h+10 -01 reply
2/7loop: clean up blkcg associationdrivers/block/loop.c drivers/block/loop.h+43 -401 reply
3/7loop: conver timer for monitoring idle worker into dworkdrivers/block/loop.c drivers/block/loop.h+38 -390 replies
4/7loop: add __loop_free_idle_workers() for covering freeing workers in clearing FDdrivers/block/loop.c+11 -140 replies
5/7loop: improve loop_process_workdrivers/block/loop.c+13 -80 replies
6/7loop: use xarray to store workersdrivers/block/loop.c drivers/block/loop.h+25 -230 replies
7/7loop: don't add worker into idle listdrivers/block/loop.c+108 -700 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchDan Schatzberg
1/7
2/7A-b
3/7A-b
4/7A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH V4 0/7] loop: cleanup charging io to mem/blkcg

Hello Guys,

Cleanup charging io to mem/blkcg a bit:

- avoid to store blkcg_css/memcg_css in loop_cmd, and store blkcg_css in loop_worker instead

- avoid to acquire ->lo_work_lock in IO path

- simplify blkcg_css query via xarray

- other misc cleanup

V4:
- fix build failure in case of !CONFIG_CGROUPS: changed to use 'struct cgroup_subsys_state' as parameter of the added memcg helper; meantime add helper loop_blkcg_css_id()

V3:
- one patch style change in 7/7
- rebase patch 4/7 against for-5.15/block
- add acked-by tag

V2:
- add helper of memcg_get_e_css
- cleanup #ifdef
- improve the last patch, as discussed with Dan Schatzberg

Ming Lei (7):
mm: memcontrol: add helper of memcg_get_e_css
loop: clean up blkcg association
loop: conver timer for monitoring idle worker into dwork
loop: add __loop_free_idle_workers() for covering freeing workers in
clearing FD
loop: improve loop_process_work
loop: use xarray to store workers
loop: don't add worker into idle list

 drivers/block/loop.c       | 331 +++++++++++++++++++++----------------
 drivers/block/loop.h       |   7 +-
 include/linux/memcontrol.h |  10 ++
 3 files changed, 201 insertions(+), 147 deletions(-)
Signature · 1 line
2.31.1