Skip to content

Make blockdev-reopen stable

Kevin Wolf qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 3 repliesIn review
  2. v56 patches 7 repliesSuperseded

Changes in v6 from the cover letter

- Changed qcow2 fix to set s->data_file = NULL between .prepare and .commit instead of using a separate bool [Vladimir]
- Coding style fixes [Vladimir]

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6qcow2: Fix dangling pointer after reopen for 'file'block/qcow2.c+29 -02 replies
2/6block: Add bdrv_reopen_queue_free()block.c include/block/block.h+17 -60 replies
3/6block: Acquire AioContexts during bdrv_reopen_multiple()block.c block/replication.c blockdev.c +2 more+57 -130 replies
4/6block: Support multiple reopening with x-blockdev-reopenblockdev.c qapi/block-core.json tests/qemu-iotests/155 +7 more+99 -750 replies
5/6iotests: Test reopening multiple devices at the same timetests/qemu-iotests/245 tests/qemu-iotests/245.out+49 -20 replies
6/6block: Make blockdev-reopen stable APIblockdev.c qapi/block-core.json tests/qemu-iotests/155 +7 more+17 -171 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-OgievskiyEric Blake
1/6R-b R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/6] Make blockdev-reopen stable

This series picks up the remaining patches from Berto's series "[PATCH v4 0/6] Allow changing bs->file on reopen", which are not merged into master yet.

Apart from renaming 'x-blockdev-reopen' into 'blockdev-reopen', the remaining functional change in this series is taking a list of nodes to reopen as an argument so that multiple changes to the graph can be made atomically that would be invalid separately (e.g. due to permission checks on the intermediate state).

It also contains a qcow2 fix for a bug introduced by the part of the series that was already picked up in Vladimir's "[PATCH v6 0/9] Allow changing bs->file on reopen".

v6:
- Changed qcow2 fix to set s->data_file = NULL between .prepare and .commit instead of using a separate bool [Vladimir]
- Coding style fixes [Vladimir]

Alberto Garcia (4):
block: Add bdrv_reopen_queue_free()
block: Support multiple reopening with x-blockdev-reopen
iotests: Test reopening multiple devices at the same time
block: Make blockdev-reopen stable API

Kevin Wolf (2):
qcow2: Fix dangling pointer after reopen for 'file'
block: Acquire AioContexts during bdrv_reopen_multiple()

 qapi/block-core.json                          | 24 +++---
 include/block/block.h                         |  3 +
 block.c                                       | 71 +++++++++++++----
 block/qcow2.c                                 | 29 +++++++
 block/replication.c                           |  7 ++
 blockdev.c                                    | 76 ++++++++++--------
 qemu-io-cmds.c                                |  7 +-
 tests/qemu-iotests/155                        |  9 ++-
 tests/qemu-iotests/165                        |  4 +-
 tests/qemu-iotests/245                        | 78 +++++++++++++++----
 tests/qemu-iotests/245.out                    |  4 +-
 tests/qemu-iotests/248                        |  4 +-
 tests/qemu-iotests/248.out                    |  2 +-
 tests/qemu-iotests/296                        | 11 ++-
 tests/qemu-iotests/298                        |  4 +-
 .../tests/remove-bitmap-from-backing          | 22 +++---
 16 files changed, 255 insertions(+), 100 deletions(-)
Signature · 1 line
2.31.1